ByTIC\MediaLibrary\HasMedia\Traits\HasMediaPropertiesTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	generateMediaProperties()	0	8	2
A	mediaProperties()	0	8	2

<?php

namespace ByTIC\MediaLibrary\HasMedia\Traits;

use ByTIC\MediaLibrary\Support\MediaModels;

/**
 * Trait HasMediaPropertiesTrait
 * @package ByTIC\MediaLibrary\HasMedia\Traits
 */
trait HasMediaPropertiesTrait
{
    /**
     * @param $collection
     * @return \ByTIC\MediaLibrary\Models\MediaProperties\MediaProperty|\Nip\Records\AbstractModels\Record
     */
    public function mediaProperties($collection)
    {
        $propertiesRecord = MediaModels::properties()->for($this, $collection);

$this of type ByTIC\MediaLibrary\HasMedia\Traits\HasMediaPropertiesTrait is incompatible with the type Nip\Records\AbstractModels\Record expected by parameter $model of ByTIC\MediaLibrary\Models\MediaProperties\MediaProperties::for().

        if (!is_object($propertiesRecord)) {
            $propertiesRecord = $this->generateMediaProperties($collection);
        }

        return $propertiesRecord;
    }

    /**
     * @param $collection
     * @return \ByTIC\MediaLibrary\Models\MediaProperties\MediaProperty
     */
    protected function generateMediaProperties($collection)
    {
        $propertiesRecord = MediaModels::properties()->createFor($this, $collection);

$this of type ByTIC\MediaLibrary\HasMedia\Traits\HasMediaPropertiesTrait is incompatible with the type Nip\Records\AbstractModels\Record expected by parameter $model of ByTIC\MediaLibrary\Models\MediaProperties\MediaProperties::createFor().

        if ($this->hasRelation('MediaProperties')) {

It seems like hasRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->getRelation('MediaProperties')->getResults()->add($propertiesRecord);

It seems like getRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        return $propertiesRecord;
    }
}