ByTIC\MediaLibrary\Models\MediaRecords\MediaRecord

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	populateFromCollection()	0	4	2
A	populateFromModel()	0	4	1
A	populateFromFile()	0	4	1

<?php

namespace ByTIC\MediaLibrary\Models\MediaRecords;

use Nip\Filesystem\File;
use Nip\Records\Record;

/**
 * Class MediaRecord
 * @package ByTIC\MediaLibrary\Models\MediaRecords
 *
 * @property string $model
 * @property int $model_id
 * @property int $collection_name
 * @property int $file_name
 * @property int $path
 * @property int $disk
 */
class MediaRecord extends Record
{
    /**
     * @param \Nip\Records\AbstractModels\Record $model
     */
    public function populateFromFile(File $file)
    {
        $this->file_name = $file->getName();
        $this->path = $file->getPath();

The property $path was declared of type integer, but $file->getPath() is of type string. Maybe add a type cast?

    }

    /**
     * @param \Nip\Records\AbstractModels\Record $model
     */
    public function populateFromModel(Record $model)
    {
        $this->model = $model->getManager()->getMorphName();

It seems like getMorphName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like $model->getManager()->getMorphName() of type Nip\Records\AbstractModels\RecordManager or Nip\Records\Collections\Collection or Nip\Records\Traits\Relations\HasRelationsRecordsTrait or true is incompatible with the declared type string of property $model.

        $this->model_id = $model->getPrimaryKey();
    }

    /**
     * @param $collection
     */
    public function populateFromCollection($collection)
    {
        $name = is_object($collection) ? $collection->getName() : $collection;
        $this->collection_name = $name;
    }
}