ByTIC\MediaLibrary\Media\Traits\UrlMethodsTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getFullUrl()	0	3	1
A	getUrl()	0	5	3

<?php

namespace ByTIC\MediaLibrary\Media\Traits;

use ByTIC\MediaLibrary\UrlGenerator\UrlGeneratorFactory;
use function Nip\url;

/**
 * Trait UrlMethodsTrait
 * @package ByTIC\MediaLibrary\Media\Traits
 */
trait UrlMethodsTrait
{


    /**
     * Get the full url to a original media file.
     *
     * @param string $conversionName
     *
     * @return string
     */
    public function getFullUrl(string $conversionName = ''): string
    {
        return url()->to($this->getUrl($conversionName));
    }

    /**
     * Get the url to a original media file.
     *
     * @param string $conversionName
     *
     * @return string
     */
    public function getUrl(string $conversionName = ''): string
    {
        $conversionName = $conversionName ? $conversionName : ($this->hasConversion('default') ? 'default' : null);

It seems like hasConversion() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $urlGenerator = UrlGeneratorFactory::createForMedia($this, $conversionName);

It seems like $conversionName can also be of type null; however, parameter $conversionName of ByTIC\MediaLibrary\UrlGenerator\UrlGeneratorFactory::createForMedia() does only seem to accept string, maybe add an additional type check?

        return $urlGenerator->getUrl();
    }
}