ByTIC\MediaLibrary\Collections\UploadStrategy\Traits\HasStrategyTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Test Coverage

Coverage

95.24%

Importance

Changes	2
Bugs	1	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	newStrategy()	0	5	1
A	getStrategy()	0	7	2
A	getStrategyClassName()	0	10	2
A	initStrategy()	0	3	1
A	setStrategy()	0	3	1
A	generateStrategy()	0	5	1

<?php

namespace ByTIC\MediaLibrary\Collections\UploadStrategy\Traits;

use ByTIC\MediaLibrary\Collections\UploadStrategy\AbstractStrategy;
use ByTIC\MediaLibrary\Collections\UploadStrategy\GenericStrategy;
use ByTIC\MediaLibrary\Collections\UploadStrategy\OriginalNameStrategy;

/**
 * Trait HasStrategyTrait.
 */
trait HasStrategyTrait
{
    /**
     * @var null|AbstractStrategy
     */
    protected $strategy = null;

    /**
     * @return AbstractStrategy|null
     */
    public function getStrategy()
    {
        if ($this->strategy === null) {
            $this->initStrategy();
        }

        return $this->strategy;
    }

    /**
     * @param AbstractStrategy|null $strategy
     */
    public function setStrategy($strategy)
    {
        $this->strategy = $strategy;
    }

    protected function initStrategy()
    {
        $this->setStrategy($this->generateStrategy());
    }

    /**
     * @return AbstractStrategy
     */
    protected function generateStrategy()
    {
        $strategy = $this->newStrategy();

        return $strategy;
    }

    /**
     * @return AbstractStrategy
     */
    protected function newStrategy()
    {
        $class = $this->getStrategyClassName();

        return new $class();
    }

    /**
     * @return string
     */
    protected function getStrategyClassName()
    {
        $mediaType = $this->getMediaType();

It seems like getMediaType() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        switch ($mediaType) {
            case 'images':
                return GenericStrategy::class;

        }

        return OriginalNameStrategy::class;
    }
}