Nip\Collections\Traits\OperationsTrait::groupBy()

Complexity

Conditions	7
Paths	11

Size

Total Lines	28
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

0

<?php
    public function groupBy($groupBy, $preserveKeys = false): AbstractCollection
    {
        $results = [];

        $groupBy = $this->valueRetriever($groupBy);

It seems like valueRetriever() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($this->items as $key => $value) {
            $groupKeys = $groupBy($value, $key);


            if (!is_array($groupKeys)) {
                $groupKeys = [$groupKeys];
            }

            foreach ($groupKeys as $groupKey) {
                $groupKey = is_bool($groupKey) ? (int)$groupKey : $groupKey;

                if (!array_key_exists($groupKey, $results)) {
                    $results[$groupKey] = new static;
                }

                $results[$groupKey]->offsetSet($preserveKeys ? $key : null, $value);
            }
        }

        $result = new static($results);

The call to Nip\Collections\Traits\OperationsTrait::__construct() has too many arguments starting with $results.

        return $result;

The expression return $result returns the type Nip\Collections\Traits\OperationsTrait which includes types incompatible with the type-hinted return Nip\Collections\AbstractCollection.

    }