bytesfield / simple-kyc

src/pipes/Smile.php

<?php

namespace Bytesfield\SimpleKyc\Pipes;

use Closure;
use Noodlehaus\Config;
use Bytesfield\SimpleKyc\HttpProcessor;
use Bytesfield\SimpleKyc\Classes\IdFilter;

class Smile
{
    public function __construct()
    {
        $config = new Config(__DIR__ . '/../config');

        $this->handler = $config->get('smile.handler');

The property handler does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiKey = $config->get('smile.api_key');

The property apiKey does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->baseUrl = $config->get('smile.api_url');

The property baseUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->partnerId = $config->get('smile.partner_id');

The property partnerId does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Process http calls
     * 
     * @param string $method The call method get|post|put|delete|patch
     * @param string $url The url to call
     * @param array payload The payload data to send with the call

The type Bytesfield\SimpleKyc\Pipes\payload was not found. Maybe you did not declare it correctly or list all dependencies?

     * 
     * @return \Bytesfield\SimpleKyc\HttpProcessor
     */
    private function process($method, $url, $payload): HttpProcessor
    {
        //HttpProcessor class to handle http request
        $processor = new HttpProcessor($this->baseUrl, $this->apiKey, $this->handler);

It seems like $this->baseUrl can also be of type null; however, parameter $baseUrl of Bytesfield\SimpleKyc\HttpProcessor::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $this->handler can also be of type null; however, parameter $handler of Bytesfield\SimpleKyc\HttpProcessor::__construct() does only seem to accept string, maybe add an additional type check?

        return $processor->process($method, $url, $payload);
    }

    /**
     * Handles the ID request
     * 
     * @param \Bytesfield\SimpleKyc\Classes\IdFilter
     * @param Closure $next
     * 
     * @return array
     */
    public function handle(IdFilter $IdFilter, Closure $next)
    {
        if (!$IdFilter->isSuccessful()) {

            $secKey = $this->generateKey($this->partnerId, $this->apiKey);

It seems like $this->partnerId can also be of type null; however, parameter $partnerId of Bytesfield\SimpleKyc\Pipes\Smile::generateKey() does only seem to accept string, maybe add an additional type check?

It seems like $this->apiKey can also be of type null; however, parameter $apiKey of Bytesfield\SimpleKyc\Pipes\Smile::generateKey() does only seem to accept string, maybe add an additional type check?

            $jobId = md5(time() . rand());

            $body = [
                'partner_id' => $this->partnerId,
                'sec_key' => $secKey[0],
                'timestamp' => $secKey[1],
                'country' => strtoupper($IdFilter->getCountry()),

It seems like $IdFilter->getCountry() can also be of type null; however, parameter $string of strtoupper() does only seem to accept string, maybe add an additional type check?

                'id_type' => $IdFilter->getIdType(),
                'id_number' => $IdFilter->getIdNumber(),
                'first_name' => $IdFilter->getFirstName(),
                'last_name' => $IdFilter->getLastName(),
                'dob' => $IdFilter->getDOB(),
                'phone_number' => $IdFilter->getPhoneNumber(),
                'company' => $IdFilter->getCompany(),
                'partner_params' => [
                    'job_type' => 5,
                    'job_id' => $jobId,
                    'user_id' => $IdFilter->getUserId()
                ]
            ];

            try {
                $response = $this->process('POST', '/v1/id_verification', array_filter($body));

                $result = $response->getResponse();

                if ($result['IsFinalResult']) {
                    $IdFilter->confirmSuccess();
                    $IdFilter->setHandler($this->handler);

                    $IdFilter->setData([
                        'handler' => $IdFilter->getHandler(),
                        'country' => $IdFilter->getCountry(),
                        'message' => $IdFilter->getIDType() . ' Verified' . ' Successfully',
                        'data' => $result
                    ]);

                    return $IdFilter->getData();
                }
            } catch (\Exception $e) {
                $IdFilter->setError(['error' => $e->getMessage()]);

                return $next($IdFilter);
            }
        }
        return $next($IdFilter);
    }

    /**
     * Generate Secret Key
     *
     * @param string $partnerId
     * @param string $apiKey
     * @return array
     */
    private function generateKey(string $partnerId, string $apiKey): array
    {
        $timestamp = time();
        $plaintext = intval($partnerId) . ":" . $timestamp;
        $hashSignature = hash('sha256', $plaintext);

        openssl_public_encrypt($hashSignature, $secKey, base64_decode($apiKey), OPENSSL_PKCS1_PADDING);

        $secKey = base64_encode($secKey);
        $secKey = $secKey . "|" . $hashSignature;

        return array($secKey, $timestamp);
    }
}