Modulo10::calculateSum() - Code Metrics - Inspection of "Reuse common code" - byrokrat/checkdigit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

unknown

created 2018-09-29 12:05 UTC

Modulo10::calculateSum() A

↳ Parent: Modulo10

Complexity

Conditions	4
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	4
cts	4
cp	1
rs	9.8333
c	0
b	0
f	0
cc	4
nc	5
nop	1
crap	4

<?php

declare(strict_types = 1);

namespace byrokrat\checkdigit;

/**
 * Modulo10 calculator
 */
class Modulo10 extends Base implements Calculator
{
    /**
     * Check if the last digit of number is a valid modulo 10 check digit
     */
    public function isValid(string $number): bool
    {
        return substr($number, -1) === $this->calculateCheckDigit(substr($number, 0, -1) ?: '');
    }

    /**
     * Calculate the modulo 10 check digit for number
     *
     * @throws InvalidStructureException If $number is not numerical
     */
    public function calculateCheckDigit(string $number): string
    {
        $this->validateNumber($number);

        $sum = $this->calculateSum($number);

        $ceil = $sum;

        while ($ceil % 10 != 0) {
            $ceil++;
        }

        return (string)($ceil-$sum);
    }

    protected function calculateSum(string $number): int
    {
        $weight = 2;
        $sum = 0;

        for ($pos=strlen($number)-1; $pos>=0; $pos--) {
            $tmp = $number[$pos] * $weight;
            $sum += ($tmp > 9) ? (1 + ($tmp % 10)) : $tmp;
            $weight = ($weight == 2) ? 1 : 2;
        }

        return $sum;
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace byrokrat\checkdigit;
6
7		/**
8		* Modulo10 calculator
9		*/
10		class Modulo10 extends Base implements Calculator
11		{
12		/**
13		* Check if the last digit of number is a valid modulo 10 check digit
14		*/
15	5	public function isValid(string $number): bool
16		{
17	5	return substr($number, -1) === $this->calculateCheckDigit(substr($number, 0, -1) ?: '');
18		}
19
20		/**
21		* Calculate the modulo 10 check digit for number
22		*
23		* @throws InvalidStructureException If $number is not numerical
24		*/
25	10	public function calculateCheckDigit(string $number): string
26		{
27	10	$this->validateNumber($number);
28	6
29	6	$sum = $this->calculateSum($number);
30
31		$ceil = $sum;
32
33	4	while ($ceil % 10 != 0) {
34	4	$ceil++;
35		}
36	4
37	4	return (string)($ceil-$sum);
38	4	}
39	4
40		protected function calculateSum(string $number): int
41		{
42	4	$weight = 2;
43		$sum = 0;
44	4
45	4	for ($pos=strlen($number)-1; $pos>=0; $pos--) {
46		$tmp = $number[$pos] * $weight;
47		$sum += ($tmp > 9) ? (1 + ($tmp % 10)) : $tmp;
48	4	$weight = ($weight == 2) ? 1 : 2;
49		}
50
51		return $sum;
52		}
53		}
54

byrokrat / checkdigit

Pull Request — master (#5)

Modulo10::calculateSum() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like