Modulo10::calculateSum() - Code Metrics - Inspection of "Merge pull request #5 from AJenbo/patch-1" - byrokrat/checkdigit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c29bcc...91a13a )

by Hannes

created 2018-09-29 16:11 UTC

Modulo10::calculateSum() A

↳ Parent: Modulo10

Complexity

Conditions	4
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	8
cts	8
cp	1
rs	9.8333
c	0
b	0
f	0
cc	4
nc	5
nop	1
crap	4

<?php

declare(strict_types = 1);

namespace byrokrat\checkdigit;

/**
 * Modulo10 calculator
 */
class Modulo10 implements Calculator
{
    use AssertionsTrait;

    /**
     * Check if the last digit of number is a valid modulo 10 check digit
     */
    public function isValid(string $number): bool
    {
        return substr($number, -1) === $this->calculateCheckDigit(substr($number, 0, -1) ?: '');
    }

    /**
     * Calculate the modulo 10 check digit for number
     *
     * @throws InvalidStructureException If $number is not numerical
     */
    public function calculateCheckDigit(string $number): string
    {
        $this->assertNumber($number);

        $sum = $this->calculateSum($number);

        $ceil = $sum;

        while ($ceil % 10 != 0) {
            $ceil++;
        }

        return (string)($ceil-$sum);
    }

    protected function calculateSum(string $number): int
    {
        $weight = 2;
        $sum = 0;

        for ($pos=strlen($number)-1; $pos>=0; $pos--) {
            $tmp = $number[$pos] * $weight;
            $sum += ($tmp > 9) ? (1 + ($tmp % 10)) : $tmp;
            $weight = ($weight == 2) ? 1 : 2;
        }

        return $sum;
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace byrokrat\checkdigit;
6
7		/**
8		* Modulo10 calculator
9		*/
10		class Modulo10 implements Calculator
11		{
12		use AssertionsTrait;
13
14		/**
15		* Check if the last digit of number is a valid modulo 10 check digit
16		*/
17	9	public function isValid(string $number): bool
18		{
19	9	return substr($number, -1) === $this->calculateCheckDigit(substr($number, 0, -1) ?: '');
20		}
21
22		/**
23		* Calculate the modulo 10 check digit for number
24		*
25		* @throws InvalidStructureException If $number is not numerical
26		*/
27	18	public function calculateCheckDigit(string $number): string
28		{
29	18	$this->assertNumber($number);
30
31	6	$sum = $this->calculateSum($number);
32
33	6	$ceil = $sum;
34
35	6	while ($ceil % 10 != 0) {
36	6	$ceil++;
37		}
38
39	6	return (string)($ceil-$sum);
40		}
41
42	4	protected function calculateSum(string $number): int
43		{
44	4	$weight = 2;
45	4	$sum = 0;
46
47	4	for ($pos=strlen($number)-1; $pos>=0; $pos--) {
48	4	$tmp = $number[$pos] * $weight;
49	4	$sum += ($tmp > 9) ? (1 + ($tmp % 10)) : $tmp;
50	4	$weight = ($weight == 2) ? 1 : 2;
51		}
52
53	4	return $sum;
54		}
55		}
56

byrokrat / checkdigit

Push — master ( c29bcc...91a13a )

Modulo10::calculateSum() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like