Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class Modulo10Gtin implements Calculator |
||
11 | { |
||
12 | /** |
||
13 | * Check if the last digit of number is a valid modulo 10 check digit |
||
14 | */ |
||
15 | 4 | public function isValid(string $number): bool |
|
19 | |||
20 | /** |
||
21 | * Calculate the modulo 10 check digit for number |
||
22 | * |
||
23 | * @throws InvalidStructureException If $number is not numerical |
||
24 | */ |
||
25 | 8 | public function calculateCheckDigit(string $number): string |
|
48 | } |
||
49 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.