ClearingValidator::validate() - Code Metrics - Inspection of "Don't report as unknown if cleringnummer matches" - byrokrat/banking - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

unknown

created 2017-11-08 16:04 UTC

ClearingValidator::validate() A

↳ Parent: ClearingValidator

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	10
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	3
nop	1
crap	20

<?php

namespace byrokrat\banking\Validator;

use byrokrat\banking\Validator;
use byrokrat\banking\AccountNumber;
use byrokrat\banking\Exception\InvalidClearingNumberException;

/**
 * Validate clearing numbers
 */
class ClearingValidator implements Validator
{
    /**
     * @var array List of clearing number max and min values
     */
    private $clearingRanges;

    /**
     * Load ranges of valid clearing numbers
     *
     * @param array $clearingRanges
     */
    public function __construct(array $clearingRanges)
    {
        $this->clearingRanges = $clearingRanges;
    }

    /**
     * Validate clearing number
     *
     * Clearing must be in one of the specified ranges to be considered valid.
     *
     * @param  AccountNumber $number
     * @return null
     * @throws InvalidClearingNumberException If clearing number is not valid
     */
    public function validate(AccountNumber $number)
    {
        $clearing = intval($number->getClearingNumber());

        foreach ($this->clearingRanges as $clearingRange) {
            if ($clearing >= $clearingRange[0] && $clearing <= $clearingRange[1]) {
                return;
            }
        }

        throw new InvalidClearingNumberException("Invalid clearing number $clearing in $number");
    }
}


1			<?php
2
3			namespace byrokrat\banking\Validator;
4
5			use byrokrat\banking\Validator;
6			use byrokrat\banking\AccountNumber;
7			use byrokrat\banking\Exception\InvalidClearingNumberException;
8
9			/**
10			* Validate clearing numbers
11			*/
12			class ClearingValidator implements Validator
13			{
14			/**
15			* @var array List of clearing number max and min values
16			*/
17			private $clearingRanges;
18
19			/**
20			* Load ranges of valid clearing numbers
21			*
22			* @param array $clearingRanges
23			*/
24			public function __construct(array $clearingRanges)
25			{
26			$this->clearingRanges = $clearingRanges;
27			}
28
29			/**
30			* Validate clearing number
31			*
32			* Clearing must be in one of the specified ranges to be considered valid.
33			*
34			* @param AccountNumber $number
35			* @return null
36			* @throws InvalidClearingNumberException If clearing number is not valid
37			*/
38			public function validate(AccountNumber $number)
39			{
40			$clearing = intval($number->getClearingNumber());
41
42			foreach ($this->clearingRanges as $clearingRange) {
43			if ($clearing >= $clearingRange[0] && $clearing <= $clearingRange[1]) {
44			return;
45			}
46			}
47
48			throw new InvalidClearingNumberException("Invalid clearing number $clearing in $number");
49			}
50			}
51

byrokrat / banking

Pull Request — master (#13)

ClearingValidator::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like