Completed
Push — master ( 7e81c7...bd5f3a )
by Hannes
01:39
created

IncomingPaymentRequest::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 22
Code Lines 20

Duplication

Lines 22
Ratio 100 %

Importance

Changes 0
Metric Value
dl 22
loc 22
c 0
b 0
f 0
rs 9.2
cc 1
eloc 20
nc 1
nop 10

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
/**
3
 * This file is part of byrokrat\autogiro.
4
 *
5
 * byrokrat\autogiro is free software: you can redistribute it and/or
6
 * modify it under the terms of the GNU General Public License as published
7
 * by the Free Software Foundation, either version 3 of the License, or
8
 * (at your option) any later version.
9
 *
10
 * byrokrat\autogiro is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
 * GNU General Public License for more details.
14
 *
15
 * You should have received a copy of the GNU General Public License
16
 * along with byrokrat\autogiro. If not, see <http://www.gnu.org/licenses/>.
17
 *
18
 * Copyright 2016-18 Hannes Forsgård
19
 */
20
21
declare(strict_types = 1);
22
23
namespace byrokrat\autogiro\Tree\Request;
24
25
use byrokrat\autogiro\Tree\RecordNode;
26
use byrokrat\autogiro\Tree\DateNode;
27
use byrokrat\autogiro\Tree\IntervalNode;
28
use byrokrat\autogiro\Tree\RepetitionsNode;
29
use byrokrat\autogiro\Tree\TextNode;
30
use byrokrat\autogiro\Tree\PayerNumberNode;
31
use byrokrat\autogiro\Tree\AmountNode;
32
use byrokrat\autogiro\Tree\BankgiroNode;
33
34
/**
35
 * Node representing a request of an incoming payment
36
 */
37 View Code Duplication
class IncomingPaymentRequest extends RecordNode
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
38
{
39
    public function __construct(
40
        int $lineNr,
41
        DateNode $date,
42
        IntervalNode $ival,
43
        RepetitionsNode $reps,
44
        TextNode $space,
45
        PayerNumberNode $payerNr,
46
        AmountNode $amount,
47
        BankgiroNode $payeeBg,
48
        TextNode $ref,
49
        array $void = []
50
    ) {
51
        $this->setChild('date', $date);
52
        $this->setChild('interval', $ival);
53
        $this->setChild('repetitions', $reps);
54
        $this->setChild('space_1', $space);
55
        $this->setChild('payer_number', $payerNr);
56
        $this->setChild('amount', $amount);
57
        $this->setChild('payee_bankgiro', $payeeBg);
58
        $this->setChild('reference', $ref);
59
        parent::__construct($lineNr, $void);
60
    }
61
}
62