View GitHub Repository autogiro

Schedule Inspection
Subscribe
Completed
Push — master ( 7009cf...36f2c1 )
by Hannes
03:05
created

MandateResponse::__construct()   A

↳ Parent: Project

Complexity

Conditions 1
Paths 1

Size

Total Lines 20
Code Lines 18

Duplication

Lines 20
Ratio 100 %

Importance

Changes 0
Metric Value
dl 20
loc 20
c 0
b 0
f 0
rs 9.4285
cc 1
eloc 18
nc 1
nop 9

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1 
<?php
2 
/**
3 
 * This file is part of byrokrat\autogiro.
4 
 *
5 
 * byrokrat\autogiro is free software: you can redistribute it and/or
6 
 * modify it under the terms of the GNU General Public License as published
7 
 * by the Free Software Foundation, either version 3 of the License, or
8 
 * (at your option) any later version.
9 
 *
10 
 * byrokrat\autogiro is distributed in the hope that it will be useful,
11 
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 
 * GNU General Public License for more details.
14 
 *
15 
 * You should have received a copy of the GNU General Public License
16 
 * along with byrokrat\autogiro. If not, see <http://www.gnu.org/licenses/>.
17 
 *
18 
 * Copyright 2016-18 Hannes Forsgård
19 
 */
20 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
declare(strict_types = 1);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
namespace byrokrat\autogiro\Tree\Response;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
use byrokrat\autogiro\Tree\RecordNode;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
/**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
 * Feedback on the request to add, delete or update a mandate

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
 */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
class MandateResponse extends RecordNode

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
}

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    33