byrokrat\autogiro\Parser\Parser

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	parse()	0	36	5

<?php

declare(strict_types=1);

namespace byrokrat\autogiro\Parser;

use byrokrat\autogiro\Line;
use byrokrat\autogiro\Exception;

/**
 * Prase raw autogiro files
 */
class Parser
{
    /**
     * @var Strategy\Strategy
     */
    private $strategy;

    public function __construct(Strategy\Strategy $strategy)
    {
        $this->strategy = $strategy;
    }

    // TODO vilken typ av objekt ska parse returnera??
    public function parse(\SplFileObject $file)
    {
        $lineNumber = 'undefined';

        try {
            $states = $this->strategy->createStates();
            $this->strategy->begin();

            foreach ($file as $lineNumber => $line) {
                $line = new Line($line);

It seems like $line defined by new \byrokrat\autogiro\Line($line) on line 35 can also be of type array; however, byrokrat\autogiro\Line::__construct() does only seem to accept string, maybe add an additional type check?

                if ($line->isEmpty()) {
                    continue;
                }

                $states->transitionTo($line->getTransactionCode());
                $handler = [$this->strategy, "on{$states->getState()}"];

                if (!is_callable($handler)) {
                    throw new Exception\LogicException("Missing handler for state {$states->getState()}");
                }

                $handler($line);
            }

            $states->transitionTo(StateMachine::STATE_DONE);
            return $this->strategy->done();

        } catch (\Exception $e) {
            throw new Exception\InvalidFileException(
                "{$e->getMessage()} on line $lineNumber in '{$file->getBasename()}'",
                0,
                $e
            );
        }
    }
}