Obj::__construct() - Code Metrics - Inspection of "Create state id as an multilayerd node structure,..." - byrokrat/autogiro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ceb8bd...beeb59 )

by Hannes

created 2018-08-27 13:50 UTC

Obj::__construct() A

↳ Parent: Obj

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	3
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php
/**
 * This file is part of byrokrat\autogiro.
 *
 * byrokrat\autogiro is free software: you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * byrokrat\autogiro is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with byrokrat\autogiro. If not, see <http://www.gnu.org/licenses/>.
 *
 * Copyright 2016-18 Hannes Forsgård
 */

declare(strict_types = 1);

namespace byrokrat\autogiro\Tree;

/**
 * Node wrapping an object
 */
class Obj extends Node
{
    public function __construct(int $lineNr = 0, object $value = null, string $name = 'Object')
    {
        parent::__construct($lineNr, $value);

        $this->setName($name);
    }

    public function getType(): string
    {
        return 'Object';
    }
}


1			<?php
2			/**
3			* This file is part of byrokrat\autogiro.
4			*
5			* byrokrat\autogiro is free software: you can redistribute it and/or
6			* modify it under the terms of the GNU General Public License as published
7			* by the Free Software Foundation, either version 3 of the License, or
8			* (at your option) any later version.
9			*
10			* byrokrat\autogiro is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License
16			* along with byrokrat\autogiro. If not, see <http://www.gnu.org/licenses/>.
17			*
18			* Copyright 2016-18 Hannes Forsgård
19			*/
20
21			declare(strict_types = 1);
22
23			namespace byrokrat\autogiro\Tree;
24
25			/**
26			* Node wrapping an object
27			*/
28			class Obj extends Node
29			{
30			public function __construct(int $lineNr = 0, object $value = null, string $name = 'Object')
31			{
32			parent::__construct($lineNr, $value);
			0 ignored issues – show Bug introduced 2018-08-27 13:53 UTC by Report Bug Copy Issue Report It seems like `$value` defined by parameter `$value` on line 30 can also be of type `null`; however, `byrokrat\autogiro\Tree\Node::__construct()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
33			$this->setName($name);
34			}
35
36			public function getType(): string
37			{
38			return 'Object';
39			}
40			}
41

byrokrat / autogiro

Push — master ( ceb8bd...beeb59 )

Obj::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like