Issues in ServiceHandler.php - Fixed Issues - Inspection of "Major changes. Removed byjg/anydataset and added b..." - byjg/restserver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9f0cc8...e7ce71 )

by Joao

created 2016-05-11 05:17 UTC

src/ServiceHandler.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace ByJG\RestServer;

use ByJG\AnyDataset\Model\ObjectHandler;
use ByJG\Util\XmlUtil;

class ServiceHandler implements HandlerInterface
{

    protected $output = Output::JSON;

    public function getOutput()
    {
        return $this->output;
    }

    public function setOutput($output)
    {
        // Check if output is set
        if ($output != Output::JSON && $output != Output::XML && $output != Output::CSV && $output != Output::RDF) {
            throw new \Exception('Invalid output format. Valid are XML, JSON or CSV');
        }

        $this->output = $output;
    }

    public function setHeader()
    {
        switch ($this->getOutput()) {
            case Output::JSON:
                header('Content-Type: application/json');
                break;

            case Output::RDF:
                header('Content-Type: application/rdf+xml');
                break;

            case Output::XML:
                header('Content-Type: text/xml');
                break;

            default:
                header('Content-Type: text/plain');
                break;
        }
    }

    /**
     * CORS - Better do that in your http server, but you can enable calling this
     */
    public function setHeaderCors()
    {
        header('Access-Control-Allow-Origin: *');
        header("Access-Control-Allow-Headers: X-API-KEY, Origin, X-Requested-With, Content-Type, Accept, Access-Control-Request-Method");
        header("Access-Control-Allow-Methods: GET, POST, OPTIONS, PUT, DELETE");
        $method = $_SERVER['REQUEST_METHOD'];
        if ($method == "OPTIONS") {
            return false;
        }
        return true;
    }

    public function execute(ServiceAbstract $instance)
    {
        $root = null;
        $annotationPrefix = 'object';
        if ($this->getOutput() == Output::RDF) {
            $xmlDoc = XmlUtil::createXmlDocument();
            $root = XmlUtil::createChild($xmlDoc, "rdf:RDF", "", "http://www.w3.org/1999/02/22-rdf-syntax-ns#");
            XmlUtil::addNamespaceToDocument($root, "rdfs", "http://www.w3.org/2000/01/rdf-schema#");
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $annotationPrefix = 'rdf';
        }

        $dom = $instance->getResponse()->getResponseBag()->process($root, $annotationPrefix);

        switch ($this->getOutput()) {
            case Output::JSON:
                return ObjectHandler::xml2json($dom);

            case Output::XML:
            case Output::RDF:
                return $dom->saveXML();

            case Output::CSV:
                $array = XmlUtil::xml2Array($dom);

                $return = "";
                foreach ((array)$array as $line) {
                    foreach ((array)$line as $field) {
                        $return .= "\"" . str_replace('"', '\\"', (is_array($field) ? json_encode($field) : $field)) . "\";";
                    }
                    $return .= "\n";
                }
                return $return;
        }

        return null;
    }
}


1			<?php
2
3			namespace ByJG\RestServer;
4
5			use ByJG\AnyDataset\Model\ObjectHandler;
6			use ByJG\Util\XmlUtil;
7
8			class ServiceHandler implements HandlerInterface
9			{
10
11			protected $output = Output::JSON;
12
13			public function getOutput()
14			{
15			return $this->output;
16			}
17
18			public function setOutput($output)
19			{
20			// Check if output is set
21			if ($output != Output::JSON && $output != Output::XML && $output != Output::CSV && $output != Output::RDF) {
22			throw new \Exception('Invalid output format. Valid are XML, JSON or CSV');
23			}
24
25			$this->output = $output;
26			}
27
28			public function setHeader()
29			{
30			switch ($this->getOutput()) {
31			case Output::JSON:
32			header('Content-Type: application/json');
33			break;
34
35			case Output::RDF:
36			header('Content-Type: application/rdf+xml');
37			break;
38
39			case Output::XML:
40			header('Content-Type: text/xml');
41			break;
42
43			default:
44			header('Content-Type: text/plain');
45			break;
46			}
47			}
48
49			/**
50			* CORS - Better do that in your http server, but you can enable calling this
51			*/
52			public function setHeaderCors()
53			{
54			header('Access-Control-Allow-Origin: *');
55			header("Access-Control-Allow-Headers: X-API-KEY, Origin, X-Requested-With, Content-Type, Accept, Access-Control-Request-Method");
56			header("Access-Control-Allow-Methods: GET, POST, OPTIONS, PUT, DELETE");
57			$method = $_SERVER['REQUEST_METHOD'];
58			if ($method == "OPTIONS") {
59			return false;
60			}
61			return true;
62			}
63
64			public function execute(ServiceAbstract $instance)
65			{
66			$root = null;
67			$annotationPrefix = 'object';
68			if ($this->getOutput() == Output::RDF) {
69			$xmlDoc = XmlUtil::createXmlDocument();
70			$root = XmlUtil::createChild($xmlDoc, "rdf:RDF", "", "http://www.w3.org/1999/02/22-rdf-syntax-ns#");
71			XmlUtil::addNamespaceToDocument($root, "rdfs", "http://www.w3.org/2000/01/rdf-schema#");
			0 ignored issues – show Documentation introduced 2016-01-19 16:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$root` is of type `object<DOMElement>`, but the function expects a `object<ByJG\Util\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72			$annotationPrefix = 'rdf';
73			}
74
75			$dom = $instance->getResponse()->getResponseBag()->process($root, $annotationPrefix);
76
77			switch ($this->getOutput()) {
78			case Output::JSON:
79			return ObjectHandler::xml2json($dom);
80
81			case Output::XML:
82			case Output::RDF:
83			return $dom->saveXML();
84
85			case Output::CSV:
86			$array = XmlUtil::xml2Array($dom);
87
88			$return = "";
89			foreach ((array)$array as $line) {
90			foreach ((array)$line as $field) {
91			$return .= "\"" . str_replace('"', '\\"', (is_array($field) ? json_encode($field) : $field)) . "\";";
92			}
93			$return .= "\n";
94			}
95			return $return;
96			}
97
98			return null;
99			}
100			}
101

byjg / restserver

Push — master ( 9f0cc8...e7ce71 )

src/ServiceHandler.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like