Issues in UploadedFiles.php - New Issues - Inspection of "2.0.3" - byjg/restserver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Joao

created 2017-02-09 14:48 UTC

src/UploadedFiles.php (3 issues)

Showing only issues like (Show All)

super-globals are not used.

Coding Style Minor

Joao Gilberto Magalhaes 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * User: jg
 * Date: 09/02/17
 * Time: 12:01
 */

namespace ByJG\RestServer;


class UploadedFiles
{
    public function count()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return count($_FILES);
    }

    public function getKeys()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return array_keys($_FILES);
    }

    public function isOk($key)
    {
        return $this->getFileByKey($key, 'error');
    }

    public function getUploadedFile($key)
    {
        return file_get_contents($this->getFileByKey($key, 'tmp_name'));
    }

    public function getFileName($key)
    {
        return $this->getFileByKey($key, 'name');
    }

    public function getFileType($key)
    {
        return $this->getFileByKey($key, 'type');
    }

    public function saveTo($key, $destinationPath, $newName = "")
    {
        if (empty($newName)) {
            $newName = $this->getFileName($key);
        }

        move_uploaded_file($this->getFileByKey($key, 'tmp_name'), $destinationPath . '/' . $newName);
    }

    public function clearTemp($key)
    {
        unlink($this->getFileByKey($key, 'tmp_name'));
    }

    private function getFileByKey($key, $property)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($_FILES[$key])) {
            throw new \InvalidArgumentException("The upload '$key' does not exists");
        }

        return $_FILES[$key][$property];
    }
}

1			<?php
2			/**
3			* User: jg
4			* Date: 09/02/17
5			* Time: 12:01
6			*/
7
8			namespace ByJG\RestServer;
9
10
11			class UploadedFiles
12			{
13			public function count()
			0 ignored issues – show Coding Style introduced 2017-02-09 14:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `count` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
14			{
15			return count($_FILES);
16			}
17
18			public function getKeys()
			0 ignored issues – show Coding Style introduced 2017-02-09 14:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getKeys` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
19			{
20			return array_keys($_FILES);
21			}
22
23			public function isOk($key)
24			{
25			return $this->getFileByKey($key, 'error');
26			}
27
28			public function getUploadedFile($key)
29			{
30			return file_get_contents($this->getFileByKey($key, 'tmp_name'));
31			}
32
33			public function getFileName($key)
34			{
35			return $this->getFileByKey($key, 'name');
36			}
37
38			public function getFileType($key)
39			{
40			return $this->getFileByKey($key, 'type');
41			}
42
43			public function saveTo($key, $destinationPath, $newName = "")
44			{
45			if (empty($newName)) {
46			$newName = $this->getFileName($key);
47			}
48
49			move_uploaded_file($this->getFileByKey($key, 'tmp_name'), $destinationPath . '/' . $newName);
50			}
51
52			public function clearTemp($key)
53			{
54			unlink($this->getFileByKey($key, 'tmp_name'));
55			}
56
57			private function getFileByKey($key, $property)
			0 ignored issues – show Coding Style introduced 2017-02-09 14:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getFileByKey` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
58			{
59			if (!isset($_FILES[$key])) {
60			throw new \InvalidArgumentException("The upload '$key' does not exists");
61			}
62
63			return $_FILES[$key][$property];
64			}
65			}

byjg / restserver

Pull Request — master (#1)

src/UploadedFiles.php (3 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like