JsonResponseHandler::handle() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/2.0.2'" - byjg/restserver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a4a865...ee8a3d )

by Joao

created 2016-09-14 18:11 UTC

JsonResponseHandler::handle() A

↳ Parent: JsonResponseHandler

Complexity

Conditions	3
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	18
rs	9.4285
c	1
b	0
f	0
cc	3
eloc	10
nc	2
nop	0

<?php
/**
 * Whoops - php errors for cool kids
 * @author Filipe Dobreira <http://github.com/filp>
 */

namespace ByJG\RestServer\Whoops;

use Whoops\Exception\Formatter;
use Whoops\Handler\Handler;
use Whoops\Handler\JsonResponseHandler as OriginalJsonHandler;
use Whoops\Util\Misc;

/**
 * Catches an exception and converts it to a JSON
 * response. Additionally can also return exception
 * frames for consumption by an API.
 */
class JsonResponseHandler extends OriginalJsonHandler
{

    use WhoopsDebugTrait;
    use WhoopsHeaderTrait;

    /**
     * @return int
     */
    public function handle()
    {
        $response = array(
            'error' => Formatter::formatExceptionAsDataArray(
                $this->getInspector(),
                $this->addTraceToOutput()

            ),
        );

        $debug = $this->getDataTable();
        if (count($debug) > 0) {
            $response["debug"] = $debug;
        }

        echo json_encode($response, defined('JSON_PARTIAL_OUTPUT_ON_ERROR') ? JSON_PARTIAL_OUTPUT_ON_ERROR : 0);

        return Handler::QUIT;
    }

}


1			<?php
2			/**
3			* Whoops - php errors for cool kids
4			* @author Filipe Dobreira <http://github.com/filp>
5			*/
6
7			namespace ByJG\RestServer\Whoops;
8
9			use Whoops\Exception\Formatter;
10			use Whoops\Handler\Handler;
11			use Whoops\Handler\JsonResponseHandler as OriginalJsonHandler;
12			use Whoops\Util\Misc;
13
14			/**
15			* Catches an exception and converts it to a JSON
16			* response. Additionally can also return exception
17			* frames for consumption by an API.
18			*/
19			class JsonResponseHandler extends OriginalJsonHandler
20			{
21
22			use WhoopsDebugTrait;
23			use WhoopsHeaderTrait;
24
25			/**
26			* @return int
27			*/
28			public function handle()
29			{
30			$response = array(
31			'error' => Formatter::formatExceptionAsDataArray(
32			$this->getInspector(),
33			$this->addTraceToOutput()
			0 ignored issues – show Bug introduced 2016-01-19 16:27 UTC by Report Bug Copy Issue Report It seems like `$this->addTraceToOutput()` targeting `Whoops\Handler\JsonRespo...ler::addTraceToOutput()` can also be of type `this<ByJG\RestServer\Whoops\JsonResponseHandler>`; however, `Whoops\Exception\Formatt...tExceptionAsDataArray()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
34			),
35			);
36
37			$debug = $this->getDataTable();
38			if (count($debug) > 0) {
39			$response["debug"] = $debug;
40			}
41
42			echo json_encode($response, defined('JSON_PARTIAL_OUTPUT_ON_ERROR') ? JSON_PARTIAL_OUTPUT_ON_ERROR : 0);
43
44			return Handler::QUIT;
45			}
46
47			}
48

byjg / restserver

Push — master ( a4a865...ee8a3d )

JsonResponseHandler::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like