ResponseBag::process() - Code Metrics - Inspection of "Added new way to get a response bag." - byjg/restserver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Joao

created 2017-10-15 02:40 UTC

ResponseBag::process() A

↳ Parent: ResponseBag

Complexity

Conditions	4
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	10
rs	9.2
cc	4
eloc	6
nc	2
nop	0

<?php

namespace ByJG\RestServer;

use ByJG\RestServer\Exception\HttpResponseException;
use ByJG\Serializer\SerializerObject;

class ResponseBag
{

    const AUTOMATIC = 0;
    const SINGLE_OBJECT = 1;
    const ARRAY = 2;

    protected $collection = [];
    protected $serializationRule = ResponseBag::AUTOMATIC;

    public function add($object)
    {
        if (is_string($object)) {
            $object = [ $object ];
        }
        if (!is_object($object) && !is_array($object)) {
            throw new HttpResponseException('You can add only object');
        }

        if ($this->serializationRule !== ResponseBag::SINGLE_OBJECT) {
            $this->collection[] = $object;
            return;
        }

        if (is_object($object)) {
            $object = [$object];
        }
        $this->collection = array_merge($this->collection, $object);
    }

    /**
     * @return array
     */
    public function process()
    {
        $collection = (array)$this->collection;
        if (count($collection) === 1 && $this->serializationRule !== ResponseBag::ARRAY && isset($collection[0])) {
            $collection = $collection[0];
        }
        
        $object = new SerializerObject($collection);
        return $object->build();
    }

    public function getCollection()
    {
        return $this->collection;
    }

    public function serializationRule($value)
    {
        $this->serializationRule = $value;
    }
}


1			<?php
2
3			namespace ByJG\RestServer;
4
5			use ByJG\RestServer\Exception\HttpResponseException;
6			use ByJG\Serializer\SerializerObject;
7
8			class ResponseBag
9			{
10
11			const AUTOMATIC = 0;
12			const SINGLE_OBJECT = 1;
13			const ARRAY = 2;
14
15			protected $collection = [];
16			protected $serializationRule = ResponseBag::AUTOMATIC;
17
18			public function add($object)
19			{
20			if (is_string($object)) {
21			$object = [ $object ];
22			}
23			if (!is_object($object) && !is_array($object)) {
24			throw new HttpResponseException('You can add only object');
25			}
26
27			if ($this->serializationRule !== ResponseBag::SINGLE_OBJECT) {
28			$this->collection[] = $object;
29			return;
30			}
31
32			if (is_object($object)) {
33			$object = [$object];
34			}
35			$this->collection = array_merge($this->collection, $object);
36			}
37
38			/**
39			* @return array
40			*/
41			public function process()
42			{
43			$collection = (array)$this->collection;
44			if (count($collection) === 1 && $this->serializationRule !== ResponseBag::ARRAY && isset($collection[0])) {
45			$collection = $collection[0];
46			}
47
48			$object = new SerializerObject($collection);
49			return $object->build();
50			}
51
52			public function getCollection()
53			{
54			return $this->collection;
55			}
56
57			public function serializationRule($value)
58			{
59			$this->serializationRule = $value;
60			}
61			}
62

byjg / restserver

Pull Request — master (#3)

ResponseBag::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like