WhoopsWrapper - Code Metrics - Inspection of "Bump major changes of most of components" - byjg/restserver - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#11)

by Joao

created 2022-10-19 15:45 UTC

WhoopsWrapper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Test Coverage

Coverage

31.25%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	14
dl	0
loc	71
ccs	5
cts	16
cp	0.3125
rs	10
c	1
b	0
f	0
wmc	7

6 Methods

Rating	Name	Size	Complexity
A	setException()	3	1
A	setOutputProcessor()	4	1
A	setInspector()	3	1
A	setRun()	3	1
A	handle()	7	2
A	setHandler()	3	1

<?php

namespace ByJG\RestServer\Whoops;

use ByJG\RestServer\HttpResponse;
use ByJG\RestServer\OutputProcessor\BaseOutputProcessor;
use ByJG\Util\Psr7\Response;
use Whoops\Exception\Inspector;
use Whoops\Handler\Handler;
use Whoops\RunInterface;

class WhoopsWrapper extends Handler
{
    /** @var Handler */
    protected $effectiveHandler = null;

    /** @var BaseOutputProcessor */
    protected $outputProcessor;

    /** @var HttpResponse */
    protected $response;

    /**
     * Set the effective handler
     *
     * @param Handler $handler
     * @return void
     */
    public function setHandler(Handler $handler)
    {
        $this->effectiveHandler = $handler;
    }

    public function setOutputProcessor(BaseOutputProcessor $processor, HttpResponse $response)
    {
        $this->outputProcessor = $processor;
        $this->response = $response;
    }

    /* *******************************************************
     *
     * HandlerInterface
     *
     ********************************************************* */

     /**
     * @return int|null A handler may return nothing, or a Handler::HANDLE_* constant
     */
    public function handle()
    {
        if (!empty($this->outputProcessor)) {
            $this->response->emptyResponse();
            $this->outputProcessor->writeHeader($this->response);
        }
        return $this->effectiveHandler->handle();
    }

    /**
     * @param  RunInterface  $run
     * @return void
     */
    public function setRun(RunInterface $run)
    {
        return $this->effectiveHandler->setRun($run);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @param  \Throwable $exception
     * @return void
     */
    public function setException($exception)
    {
        return $this->effectiveHandler->setException($exception);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @param  Inspector $inspector
     * @return void
     */
    public function setInspector(Inspector $inspector)
    {
        return $this->effectiveHandler->setInspector($inspector);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1		<?php
2
3		namespace ByJG\RestServer\Whoops;
4
5		use ByJG\RestServer\HttpResponse;
6		use ByJG\RestServer\OutputProcessor\BaseOutputProcessor;
7		use ByJG\Util\Psr7\Response;
8		use Whoops\Exception\Inspector;
9		use Whoops\Handler\Handler;
10		use Whoops\RunInterface;
11
12		class WhoopsWrapper extends Handler
13		{
14		/** @var Handler */
15		protected $effectiveHandler = null;
16
17		/** @var BaseOutputProcessor */
18		protected $outputProcessor;
19
20		/** @var HttpResponse */
21		protected $response;
22
23		/**
24		* Set the effective handler
25		*
26		* @param Handler $handler
27		* @return void
28		*/
29	7	public function setHandler(Handler $handler)
30		{
31	7	$this->effectiveHandler = $handler;
32		}
33
34	7	public function setOutputProcessor(BaseOutputProcessor $processor, HttpResponse $response)
35		{
36	7	$this->outputProcessor = $processor;
37	7	$this->response = $response;
38		}
39
40		/* *******************************************************
41		*
42		* HandlerInterface
43		*
44		********************************************************* */
45
46		/**
47		* @return int\|null A handler may return nothing, or a Handler::HANDLE_* constant
48		*/
49		public function handle()
50		{
51		if (!empty($this->outputProcessor)) {
52		$this->response->emptyResponse();
53		$this->outputProcessor->writeHeader($this->response);
54		}
55		return $this->effectiveHandler->handle();
56		}
57
58		/**
59		* @param RunInterface $run
60		* @return void
61		*/
62		public function setRun(RunInterface $run)
63		{
64		return $this->effectiveHandler->setRun($run);
		0 ignored issues – show Bug introduced 2022-10-19 15:47 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->effectiveHandler->setRun($run)` targeting `Whoops\Handler\Handler::setRun()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
65		}
66
67		/**
68		* @param \Throwable $exception
69		* @return void
70		*/
71		public function setException($exception)
72		{
73		return $this->effectiveHandler->setException($exception);
		0 ignored issues – show Bug introduced 2022-10-19 15:47 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->effectiveHandler->setException($exception)` targeting `Whoops\Handler\Handler::setException()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
74		}
75
76		/**
77		* @param Inspector $inspector
78		* @return void
79		*/
80		public function setInspector(Inspector $inspector)
81		{
82		return $this->effectiveHandler->setInspector($inspector);
		0 ignored issues – show Bug introduced 2022-10-19 15:47 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->effectiveHandler->setInspector($inspector)` targeting `Whoops\Handler\Handler::setInspector()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
83		}
84		}
85

byjg / restserver

Pull Request — master (#11)

WhoopsWrapper A

Complexity

Size/Duplication

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like