Builder\_Lib::liveExecuteCommand()

Complexity

Conditions	5
Paths	6

Size

Total Lines	43
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function liveExecuteCommand($cmd)
    {
        // while (@ ob_end_flush()); // end all output buffers if any

        if (is_array($cmd)) {
            foreach ($cmd as $item) {
                $this->liveExecuteCommand($item);
            }
            return null;
        }

        $cmd = $this->replaceVariables($cmd);
        echo "\n>> $cmd\n";

        $complement = " 2>&1 ; echo Exit status : $?";
        if ($this->getSystemOs() === "Windows") {
            $complement = ' & echo Exit status : %errorlevel%';
        }
        $proc = popen("$cmd $complement", 'r');

        $completeOutput = "";

        while (!feof($proc)) {

It seems like $proc can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

            $liveOutput     = fread($proc, 4096);

It seems like $proc can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

            $completeOutput = $completeOutput . $liveOutput;
            echo "$liveOutput";
            @ flush();

It seems like you do not handle an error condition for flush(). This can introduce security issues, and is generally not recommended.

Are you sure the usage of flush() is correct as it seems to always return null.

        }

        pclose($proc);

It seems like $proc can also be of type false; however, parameter $handle of pclose() does only seem to accept resource, maybe add an additional type check?

        // get exit status
        preg_match('/[0-9]+$/', $completeOutput, $matches);

        $exitStatus = intval($matches[0]);
        // if ($exitStatus !== 0) {
        //     exit($exitStatus);
        // }

        // return exit status and intended output
        return array (
            'exit_status'  => $exitStatus,
            'output'       => str_replace("Exit status : " . $matches[0], '', $completeOutput)
        );