SqliteDatabaseTest::prepareDatabase() - Code Metrics - Inspection of "Merge pull request #24 from byjg/issue-23" - byjg/migration - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 67b49c...8d83b9 )

by Joao

created 2020-02-01 18:48 UTC

SqliteDatabaseTest::prepareDatabase() A

↳ Parent: SqliteDatabaseTest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

require_once 'BaseDatabase.php';

/**
 * @requires extension pdo_sqlite
 */
class SqliteDatabaseTest extends BaseDatabase
{
    protected $path = ':memory:';

    /**
     * @var \ByJG\DbMigration\Migration
     */
    protected $migrate = null;

    public function setUp()

    {
        # Dump SQLite database.
        $this->prepareDatabase();

        $uri = new \ByJG\Util\Uri("sqlite://{$this->path}");
        $this->migrate = new \ByJG\DbMigration\Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
        $this->migrate->registerDatabase("sqlite", \ByJG\DbMigration\Database\SqliteDatabase::class);
        parent::setUp();
    }

    public function testUsingCustomTable()

    {
        $this->migrationTable = 'migration_table';

        $this->prepareDatabase();

        $uri = new \ByJG\Util\Uri("sqlite://{$this->path}");
        $this->migrate = new \ByJG\DbMigration\Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
        $this->migrate->registerDatabase("sqlite", \ByJG\DbMigration\Database\SqliteDatabase::class);

        parent::testUpVersion1();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    protected function prepareDatabase() {
        if ($this->path != ":memory:") {
            file_put_contents($this->path, '');
        }
    }
}


1		<?php
2
3		require_once 'BaseDatabase.php';
4
5		/**
6		* @requires extension pdo_sqlite
7		*/
8		class SqliteDatabaseTest extends BaseDatabase
9		{
10		protected $path = ':memory:';
11
12		/**
13		* @var \ByJG\DbMigration\Migration
14		*/
15		protected $migrate = null;
16
17	View Code Duplication	public function setUp()
		0 ignored issues – show Duplication introduced 2018-08-27 05:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		# Dump SQLite database.
20		$this->prepareDatabase();
21
22		$uri = new \ByJG\Util\Uri("sqlite://{$this->path}");
23		$this->migrate = new \ByJG\DbMigration\Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
24		$this->migrate->registerDatabase("sqlite", \ByJG\DbMigration\Database\SqliteDatabase::class);
25		parent::setUp();
26		}
27
28	View Code Duplication	public function testUsingCustomTable()
		0 ignored issues – show Duplication introduced 2018-08-27 05:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$this->migrationTable = 'migration_table';
31
32		$this->prepareDatabase();
33
34		$uri = new \ByJG\Util\Uri("sqlite://{$this->path}");
35		$this->migrate = new \ByJG\DbMigration\Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
36		$this->migrate->registerDatabase("sqlite", \ByJG\DbMigration\Database\SqliteDatabase::class);
37
38		parent::testUpVersion1();
		0 ignored issues – show Comprehensibility Bug introduced 2018-08-13 08:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`testUpVersion1()` instead of `testUsingCustomTable()`). Are you sure this is correct? If so, you might want to change this to `$this->testUpVersion1()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
39		}
40
41		protected function prepareDatabase() {
42		if ($this->path != ":memory:") {
43		file_put_contents($this->path, '');
44		}
45		}
46		}
47

byjg / migration

Push — master ( 67b49c...8d83b9 )

SqliteDatabaseTest::prepareDatabase() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like