SqlServerDatabaseTest::testUsingCustomTable() - Code Metrics - Inspection of "[WIP] Allow users to choose migration table" - byjg/migration - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Julien

created 2018-08-13 08:59 UTC

SqlServerDatabaseTest::testUsingCustomTable() A

↳ Parent: SqlServerDatabaseTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php


require_once 'BaseDatabase.php';

/**
 * @requires extension pdo_dblib
 */
class SqlServerDatabaseTest extends BaseDatabase
namespace YourVendor;

class YourClass { }
{
    protected $uri = 'dblib://sa:Pa$$word!@mssql-container/migratedatabase';

    /**
     * @var \ByJG\DbMigration\Migration
     */
    protected $migrate = null;

    public function getExpectedUsersVersion1()
    {
        return [
            ["id" => 1, "name" => 'John Doe', 'createdate' => 'Jan 10 2016 12:00:00:AM'],
            ["id" => 2, "name" => 'Jane Doe', 'createdate' => 'Dec 30 2015 12:00:00:AM']
        ];
    }

    public function setUp()
    {
        $this->migrate = new \ByJG\DbMigration\Migration(new \ByJG\Util\Uri($this->uri), __DIR__ . '/../example/sql_server');
        $this->migrate->registerDatabase("dblib", \ByJG\DbMigration\Database\DblibDatabase::class);
        parent::setUp();
    }

    public function testUsingCustomTable()
    {
        $this->migrationTable = 'migration_table';

        $this->migrate = new \ByJG\DbMigration\Migration(new \ByJG\Util\Uri($this->uri), __DIR__ . '/../example/sql_server', true, $this->migrationTable);
        $this->migrate->registerDatabase("dblib", \ByJG\DbMigration\Database\DblibDatabase::class);

        parent::testUpVersion1();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-02 21:36 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 8 and the first side effect is on line 3. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			require_once 'BaseDatabase.php';
4
5			/**
6			* @requires extension pdo_dblib
7			*/
8			class SqlServerDatabaseTest extends BaseDatabase
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-27 20:54 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			protected $uri = 'dblib://sa:Pa$$word!@mssql-container/migratedatabase';
11
12			/**
13			* @var \ByJG\DbMigration\Migration
14			*/
15			protected $migrate = null;
16
17			public function getExpectedUsersVersion1()
18			{
19			return [
20			["id" => 1, "name" => 'John Doe', 'createdate' => 'Jan 10 2016 12:00:00:AM'],
21			["id" => 2, "name" => 'Jane Doe', 'createdate' => 'Dec 30 2015 12:00:00:AM']
22			];
23			}
24
25			public function setUp()
26			{
27			$this->migrate = new \ByJG\DbMigration\Migration(new \ByJG\Util\Uri($this->uri), __DIR__ . '/../example/sql_server');
28			$this->migrate->registerDatabase("dblib", \ByJG\DbMigration\Database\DblibDatabase::class);
29			parent::setUp();
30			}
31
32			public function testUsingCustomTable()
33			{
34			$this->migrationTable = 'migration_table';
35
36			$this->migrate = new \ByJG\DbMigration\Migration(new \ByJG\Util\Uri($this->uri), __DIR__ . '/../example/sql_server', true, $this->migrationTable);
37			$this->migrate->registerDatabase("dblib", \ByJG\DbMigration\Database\DblibDatabase::class);
38
39			parent::testUpVersion1();
			0 ignored issues – show Comprehensibility Bug introduced 2018-08-13 08:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`testUpVersion1()` instead of `testUsingCustomTable()`). Are you sure this is correct? If so, you might want to change this to `$this->testUpVersion1()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
40			}
41			}
42

byjg / migration

Pull Request — master (#11)

SqlServerDatabaseTest::testUsingCustomTable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like