These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
0 ignored issues
–
show
|
|||
2 | |||
3 | require_once 'BaseDatabase.php'; |
||
4 | |||
5 | /** |
||
6 | * @requires extension pdo_mysql |
||
7 | */ |
||
8 | View Code Duplication | class MysqlDatabaseTest extends BaseDatabase |
|
0 ignored issues
–
show
This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.
You can fix this by adding a namespace to your class: namespace YourVendor;
class YourClass { }
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.
Loading history...
|
|||
9 | { |
||
10 | protected $uri = 'mysql://root:password@mysql-container/migratedatabase'; |
||
11 | |||
12 | /** |
||
13 | * @var \ByJG\DbMigration\Migration |
||
14 | */ |
||
15 | protected $migrate = null; |
||
16 | |||
17 | public function setUp() |
||
18 | { |
||
19 | $this->migrate = new \ByJG\DbMigration\Migration(new \ByJG\Util\Uri($this->uri), __DIR__ . '/../example/mysql'); |
||
20 | $this->migrate->registerDatabase("mysql", \ByJG\DbMigration\Database\MySqlDatabase::class); |
||
21 | parent::setUp(); |
||
22 | } |
||
23 | } |
||
24 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.