SqliteDatabaseTest::setUp() - Code Metrics - Inspection of "Fix reset sqlite database" - byjg/migration - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#40)

by Joao

created 2021-11-04 23:16 UTC

SqliteDatabaseTest::setUp() A

↳ Parent: SqliteDatabaseTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	8
c	2
b	0
f	0
dl	0
loc	15
rs	10
cc	2
nc	2
nop	0

<?php

use ByJG\DbMigration\Database\SqliteDatabase;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use ByJG\DbMigration\Migration;
use ByJG\Util\Uri;

require_once 'BaseDatabase.php';

/**
 * @requires extension pdo_sqlite
 */
class SqliteDatabaseTest extends BaseDatabase
{
    protected $path = '';

    /**
     * @var Migration
     */
    protected $migrate = null;

    public function setUp()
    {
        $this->path = getenv('SQLITE_TEST_HOST');
        if (empty($this->path)) {
            $this->path = ':memory:';
        }

        # Dump SQLite database.
        $this->prepareDatabase();

        $uri = new Uri("sqlite://{$this->path}");

        $this->migrate = new Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
        $this->migrate->registerDatabase("sqlite", SqliteDatabase::class);
        parent::setUp();
    }

    public function testUsingCustomTable()
    {
        $this->migrationTable = 'migration_table';

        $this->prepareDatabase();

        $uri = new Uri("sqlite://{$this->path}");
        $this->migrate = new Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
        $this->migrate->registerDatabase("sqlite", SqliteDatabase::class);

        parent::testUpVersion1();
    }

    protected function prepareDatabase() {
        if ($this->path != ":memory:") {
            file_put_contents($this->path, '');
        }
    }
}


1			<?php
2
3			use ByJG\DbMigration\Database\SqliteDatabase;
			0 ignored issues – show Bug introduced 2021-11-04 23:23 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `SqliteDatabase`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
4			use ByJG\DbMigration\Migration;
5			use ByJG\Util\Uri;
6
7			require_once 'BaseDatabase.php';
8
9			/**
10			* @requires extension pdo_sqlite
11			*/
12			class SqliteDatabaseTest extends BaseDatabase
13			{
14			protected $path = '';
15
16			/**
17			* @var Migration
18			*/
19			protected $migrate = null;
20
21			public function setUp()
22			{
23			$this->path = getenv('SQLITE_TEST_HOST');
24			if (empty($this->path)) {
25			$this->path = ':memory:';
26			}
27
28			# Dump SQLite database.
29			$this->prepareDatabase();
30
31			$uri = new Uri("sqlite://{$this->path}");
32
33			$this->migrate = new Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
34			$this->migrate->registerDatabase("sqlite", SqliteDatabase::class);
35			parent::setUp();
36			}
37
38			public function testUsingCustomTable()
39			{
40			$this->migrationTable = 'migration_table';
41
42			$this->prepareDatabase();
43
44			$uri = new Uri("sqlite://{$this->path}");
45			$this->migrate = new Migration($uri, __DIR__ . '/../example/sqlite', true, $this->migrationTable);
46			$this->migrate->registerDatabase("sqlite", SqliteDatabase::class);
47
48			parent::testUpVersion1();
49			}
50
51			protected function prepareDatabase() {
52			if ($this->path != ":memory:") {
53			file_put_contents($this->path, '');
54			}
55			}
56			}
57

byjg / migration

Pull Request — master (#40)

SqliteDatabaseTest::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like