Issues in JwtWrapperHashTest.php - New Issues - Inspection of "Merge pull request #2 from byjg/2.0.0" - byjg/jwt-wrapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6969ed...0fcf39 )

by Joao

created 2019-01-09 02:37 UTC

tests/JwtWrapperHashTest.php (6 issues)

Labels

Duplication 6

Severity

Informational 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use ByJG\Util\JwtWrapper;
use PHPUnit\Framework\TestCase;

class JwtWrapperHashTest extends TestCase
{

    /**
     * @var JwtWrapper
     */
    protected $object;

    protected $dataToToken = ["name" => "John", "id"=>"1"];
    protected $server = "example.com";

    /**
     * @var \ByJG\Util\JwtKeyInterface
     */
    protected $jwtKey;

    protected function setUp()
    {
        $this->jwtKey = \ByJG\Util\JwtKeySecret::getInstance("secrect_key_for_test", false);

        unset($_SERVER["HTTP_AUTHORIZATION"]);
        $this->object = new JwtWrapper($this->server, $this->jwtKey);
    }

    protected function tearDown()
    {
        $this->object = null;
        unset($_SERVER["HTTP_AUTHORIZATION"]);
    }


    public function testSuccessfulFlow1()

    {
        $jwt = $this->object->createJwtData($this->dataToToken);

        $this->assertEquals([
            'iat'  => $jwt["iat"],  // Not deterministic for the test
            'jti'  => $jwt["jti"],  // Not deterministic for the test
            'iss'  => "example.com",
            'nbf'  => $jwt["iat"],
            'exp'  => $jwt["iat"] + 60,
            'data' => $this->dataToToken
        ], $jwt);

        $token = $this->object->generateToken($jwt);

        $data = $this->object->extractData($token);

        $expectedData = new stdClass();
        $expectedData->iat = $jwt["iat"];  // Not deterministic for the test
        $expectedData->jti = $jwt["jti"];  // Not deterministic for the test
        $expectedData->iss = "example.com";
        $expectedData->nbf = $jwt["iat"];
        $expectedData->exp = $jwt["iat"] + 60;
        $expectedData->data = (object)$this->dataToToken;

        $this->assertEquals(
            $expectedData,
            $data
        );

    }

    public function testSuccessfulFlow2()

    {
        $jwt = $this->object->createJwtData($this->dataToToken);

        $this->assertEquals([
            'iat'  => $jwt["iat"],  // Not deterministic for the test
            'jti'  => $jwt["jti"],  // Not deterministic for the test
            'iss'  => "example.com",
            'nbf'  => $jwt["iat"],
            'exp'  => $jwt["iat"] + 60,
            'data' => $this->dataToToken
        ], $jwt);

        $token = $this->object->generateToken($jwt);

        $_SERVER["HTTP_AUTHORIZATION"] = "Bearer $token";

        $data = $this->object->extractData();

        $expectedData = new stdClass();
        $expectedData->iat = $jwt["iat"];  // Not deterministic for the test
        $expectedData->jti = $jwt["jti"];  // Not deterministic for the test
        $expectedData->iss = "example.com";
        $expectedData->nbf = $jwt["iat"];
        $expectedData->exp = $jwt["iat"] + 60;
        $expectedData->data = (object)$this->dataToToken;

        $this->assertEquals(
            $expectedData,
            $data
        );

    }

    /**
     * @throws \ByJG\Util\JwtWrapperException
     * @expectedException \ByJG\Util\JwtWrapperException
     */
    public function testTokenWrongServerSameSecret()

    {
        $jwt = $this->object->createJwtData($this->dataToToken);
        $token = $this->object->generateToken($jwt);

        $jwtWrapper = new JwtWrapper("otherserver.com", $this->jwtKey);

        $jwtWrapper->extractData($token);
    }

    /**
     * @throws \ByJG\Util\JwtWrapperException
     * @expectedException \Firebase\JWT\SignatureInvalidException
     */
    public function testTokenWrongSecret()

    {
        $jwt = $this->object->createJwtData($this->dataToToken);
        $token = $this->object->generateToken($jwt);

        $jwtWrapper = new JwtWrapper($this->server, new \ByJG\Util\JwtKeySecret("some_creepy_secret", true));

        $jwtWrapper->extractData($token);
    }

    /**
     * @throws \ByJG\Util\JwtWrapperException
     * @expectedException \Firebase\JWT\ExpiredException
     */
    public function testExpiredToken()

    {
        $jwt = $this->object->createJwtData($this->dataToToken,1);
        $token = $this->object->generateToken($jwt);

        sleep(2);

        $this->object->extractData($token);
    }

    /**
     * @throws \ByJG\Util\JwtWrapperException
     * @expectedException \Firebase\JWT\BeforeValidException
     */
    public function testNotBeforeToken()

    {
        $jwt = $this->object->createJwtData($this->dataToToken,60, 60);
        $token = $this->object->generateToken($jwt);

        $this->object->extractData($token);
    }

    /**
     * @throws \ByJG\Util\JwtWrapperException
     * @expectedException \ByJG\Util\JwtWrapperException
     */
    public function testGetEmptyAuthorizationBearer()
    {
        $this->object->extractData();
    }

    /**
     * @throws \ByJG\Util\JwtWrapperException
     * @expectedException UnexpectedValueException
     */
    public function testGetInvalidTokenSequence()
    {
        $this->object->extractData("invalidtoken");
    }

    /**
     * @throws \ByJG\Util\JwtWrapperException
     * @expectedException DomainException
     */
    public function testGetInvalidToken()
    {
        $this->object->extractData("invalidtoken.hasthree.parts");
    }
}


1		<?php
2
3		use ByJG\Util\JwtWrapper;
4		use PHPUnit\Framework\TestCase;
5
6		class JwtWrapperHashTest extends TestCase
7		{
8
9		/**
10		* @var JwtWrapper
11		*/
12		protected $object;
13
14		protected $dataToToken = ["name" => "John", "id"=>"1"];
15		protected $server = "example.com";
16
17		/**
18		* @var \ByJG\Util\JwtKeyInterface
19		*/
20		protected $jwtKey;
21
22		protected function setUp()
23		{
24		$this->jwtKey = \ByJG\Util\JwtKeySecret::getInstance("secrect_key_for_test", false);
25
26		unset($_SERVER["HTTP_AUTHORIZATION"]);
27		$this->object = new JwtWrapper($this->server, $this->jwtKey);
28		}
29
30		protected function tearDown()
31		{
32		$this->object = null;
33		unset($_SERVER["HTTP_AUTHORIZATION"]);
34		}
35
36
37	View Code Duplication	public function testSuccessfulFlow1()
		0 ignored issues – show Duplication introduced 2019-01-03 03:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$jwt = $this->object->createJwtData($this->dataToToken);
40
41		$this->assertEquals([
42		'iat' => $jwt["iat"], // Not deterministic for the test
43		'jti' => $jwt["jti"], // Not deterministic for the test
44		'iss' => "example.com",
45		'nbf' => $jwt["iat"],
46		'exp' => $jwt["iat"] + 60,
47		'data' => $this->dataToToken
48		], $jwt);
49
50		$token = $this->object->generateToken($jwt);
51
52		$data = $this->object->extractData($token);
53
54		$expectedData = new stdClass();
55		$expectedData->iat = $jwt["iat"]; // Not deterministic for the test
56		$expectedData->jti = $jwt["jti"]; // Not deterministic for the test
57		$expectedData->iss = "example.com";
58		$expectedData->nbf = $jwt["iat"];
59		$expectedData->exp = $jwt["iat"] + 60;
60		$expectedData->data = (object)$this->dataToToken;
61
62		$this->assertEquals(
63		$expectedData,
64		$data
65		);
66
67		}
68
69	View Code Duplication	public function testSuccessfulFlow2()
		0 ignored issues – show Duplication introduced 2019-01-03 03:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		$jwt = $this->object->createJwtData($this->dataToToken);
72
73		$this->assertEquals([
74		'iat' => $jwt["iat"], // Not deterministic for the test
75		'jti' => $jwt["jti"], // Not deterministic for the test
76		'iss' => "example.com",
77		'nbf' => $jwt["iat"],
78		'exp' => $jwt["iat"] + 60,
79		'data' => $this->dataToToken
80		], $jwt);
81
82		$token = $this->object->generateToken($jwt);
83
84		$_SERVER["HTTP_AUTHORIZATION"] = "Bearer $token";
85
86		$data = $this->object->extractData();
87
88		$expectedData = new stdClass();
89		$expectedData->iat = $jwt["iat"]; // Not deterministic for the test
90		$expectedData->jti = $jwt["jti"]; // Not deterministic for the test
91		$expectedData->iss = "example.com";
92		$expectedData->nbf = $jwt["iat"];
93		$expectedData->exp = $jwt["iat"] + 60;
94		$expectedData->data = (object)$this->dataToToken;
95
96		$this->assertEquals(
97		$expectedData,
98		$data
99		);
100
101		}
102
103		/**
104		* @throws \ByJG\Util\JwtWrapperException
105		* @expectedException \ByJG\Util\JwtWrapperException
106		*/
107	View Code Duplication	public function testTokenWrongServerSameSecret()
		0 ignored issues – show Duplication introduced 2019-01-03 03:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
108		{
109		$jwt = $this->object->createJwtData($this->dataToToken);
110		$token = $this->object->generateToken($jwt);
111
112		$jwtWrapper = new JwtWrapper("otherserver.com", $this->jwtKey);
113
114		$jwtWrapper->extractData($token);
115		}
116
117		/**
118		* @throws \ByJG\Util\JwtWrapperException
119		* @expectedException \Firebase\JWT\SignatureInvalidException
120		*/
121	View Code Duplication	public function testTokenWrongSecret()
		0 ignored issues – show Duplication introduced 2019-01-03 03:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
122		{
123		$jwt = $this->object->createJwtData($this->dataToToken);
124		$token = $this->object->generateToken($jwt);
125
126		$jwtWrapper = new JwtWrapper($this->server, new \ByJG\Util\JwtKeySecret("some_creepy_secret", true));
127
128		$jwtWrapper->extractData($token);
129		}
130
131		/**
132		* @throws \ByJG\Util\JwtWrapperException
133		* @expectedException \Firebase\JWT\ExpiredException
134		*/
135	View Code Duplication	public function testExpiredToken()
		0 ignored issues – show Duplication introduced 2019-01-03 03:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
136		{
137		$jwt = $this->object->createJwtData($this->dataToToken,1);
138		$token = $this->object->generateToken($jwt);
139
140		sleep(2);
141
142		$this->object->extractData($token);
143		}
144
145		/**
146		* @throws \ByJG\Util\JwtWrapperException
147		* @expectedException \Firebase\JWT\BeforeValidException
148		*/
149	View Code Duplication	public function testNotBeforeToken()
		0 ignored issues – show Duplication introduced 2019-01-03 03:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
150		{
151		$jwt = $this->object->createJwtData($this->dataToToken,60, 60);
152		$token = $this->object->generateToken($jwt);
153
154		$this->object->extractData($token);
155		}
156
157		/**
158		* @throws \ByJG\Util\JwtWrapperException
159		* @expectedException \ByJG\Util\JwtWrapperException
160		*/
161		public function testGetEmptyAuthorizationBearer()
162		{
163		$this->object->extractData();
164		}
165
166		/**
167		* @throws \ByJG\Util\JwtWrapperException
168		* @expectedException UnexpectedValueException
169		*/
170		public function testGetInvalidTokenSequence()
171		{
172		$this->object->extractData("invalidtoken");
173		}
174
175		/**
176		* @throws \ByJG\Util\JwtWrapperException
177		* @expectedException DomainException
178		*/
179		public function testGetInvalidToken()
180		{
181		$this->object->extractData("invalidtoken.hasthree.parts");
182		}
183		}
184

byjg / jwt-wrapper

Push — master ( 6969ed...0fcf39 )

tests/JwtWrapperHashTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like