CacheItem::get() - Code Metrics - Inspection of "4.0" - byjg/cache-engine-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#2)

by Joao

created 2017-05-27 19:07 UTC

CacheItem::get() A

↳ Parent: CacheItem

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	2
eloc	2
nc	2
nop	0

<?php

namespace ByJG\Cache\Psr6;

use Psr\Cache\CacheItemInterface;

class CacheItem implements CacheItemInterface
{
    /**
     * @var string
     */
    protected $key;
    
    /**
     * @var mixed
     */
    protected $value;
    
    /**
     * @var boolean
     */
    protected $hit;
    
    /**
     * @var \DateTime
     */
    protected $expiration;

    /**
     * CacheItem constructor.
     * @param string $key
     * @param mixed $value
     * @param bool $hit
     */
    public function __construct($key, $value, $hit = true)
    {
        $this->key = $key;
        $this->value = $value;
        $this->hit = $hit;
        $this->expiresAt(null);
    }

    /**
     * {@inheritdoc}
     */
    public function getKey()
    {
        return $this->key;
    }
    
    /**
     * {@inheritdoc}
     */
    public function get()
    {
        return $this->isHit() ? $this->value : null;
    }
    /**
     * {@inheritdoc}
     */
    public function set($value = null)
    {
        $this->value = $value;
        $this->hit = !is_null($value);
        return $this;
    }
    /**
     * {@inheritdoc}
     */
    public function isHit()
    {
        return $this->hit;
    }
    /**
     * {@inheritdoc}
     */
    public function expiresAt($expiration)
    {
        if (is_null($expiration)) {
            $this->expiration = new \DateTime('now +1 year');
        } else {
            assert('$expiration instanceof \DateTimeInterface');
            $this->expiration = $expiration;

        }
        return $this;
    }
    /**
     * {@inheritdoc}
     */
    public function expiresAfter($time)
    {
        if (is_null($time)) {
            $this->expiration = new \DateTime('now +1 year');
        } elseif (is_numeric($time)) {
            $this->expiration = new \DateTime('now +' . $time . ' seconds');
        } else {
            assert('$time instanceof DateInterval');
            $expiration = new \DateTime();
            $expiration->add($time);
            $this->expiration = $expiration;
        }
        return $this;
    }

    /**
     * @return \DateTime
     */
    public function getExpiresAt()
    {
        return $this->expiration;
    }
    
    public function getExpiresInSecs()
    {
        return $this->getExpiresAt()->getTimestamp() - (new \DateTime('now'))->getTimestamp();
    }
}


1			<?php
2
3			namespace ByJG\Cache\Psr6;
4
5			use Psr\Cache\CacheItemInterface;
6
7			class CacheItem implements CacheItemInterface
8			{
9			/**
10			* @var string
11			*/
12			protected $key;
13
14			/**
15			* @var mixed
16			*/
17			protected $value;
18
19			/**
20			* @var boolean
21			*/
22			protected $hit;
23
24			/**
25			* @var \DateTime
26			*/
27			protected $expiration;
28
29			/**
30			* CacheItem constructor.
31			* @param string $key
32			* @param mixed $value
33			* @param bool $hit
34			*/
35			public function __construct($key, $value, $hit = true)
36			{
37			$this->key = $key;
38			$this->value = $value;
39			$this->hit = $hit;
40			$this->expiresAt(null);
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function getKey()
47			{
48			return $this->key;
49			}
50
51			/**
52			* {@inheritdoc}
53			*/
54			public function get()
55			{
56			return $this->isHit() ? $this->value : null;
57			}
58			/**
59			* {@inheritdoc}
60			*/
61			public function set($value = null)
62			{
63			$this->value = $value;
64			$this->hit = !is_null($value);
65			return $this;
66			}
67			/**
68			* {@inheritdoc}
69			*/
70			public function isHit()
71			{
72			return $this->hit;
73			}
74			/**
75			* {@inheritdoc}
76			*/
77			public function expiresAt($expiration)
78			{
79			if (is_null($expiration)) {
80			$this->expiration = new \DateTime('now +1 year');
81			} else {
82			assert('$expiration instanceof \DateTimeInterface');
83			$this->expiration = $expiration;
			0 ignored issues – show Documentation Bug introduced 2017-02-04 21:34 UTC by Report Bug Copy Issue Report It seems like `$expiration` of type `object<DateTimeInterface>` is incompatible with the declared type `object<DateTime>` of property `$expiration`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
84			}
85			return $this;
86			}
87			/**
88			* {@inheritdoc}
89			*/
90			public function expiresAfter($time)
91			{
92			if (is_null($time)) {
93			$this->expiration = new \DateTime('now +1 year');
94			} elseif (is_numeric($time)) {
95			$this->expiration = new \DateTime('now +' . $time . ' seconds');
96			} else {
97			assert('$time instanceof DateInterval');
98			$expiration = new \DateTime();
99			$expiration->add($time);
100			$this->expiration = $expiration;
101			}
102			return $this;
103			}
104
105			/**
106			* @return \DateTime
107			*/
108			public function getExpiresAt()
109			{
110			return $this->expiration;
111			}
112
113			public function getExpiresInSecs()
114			{
115			return $this->getExpiresAt()->getTimestamp() - (new \DateTime('now'))->getTimestamp();
116			}
117			}
118

byjg / cache-engine-php

Pull Request — master (#2)

CacheItem::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like