Inspection of "2.1.1" - byjg/anydataset - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Joao

created 2017-02-04 17:12 UTC

Status

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -160,6 +160,9 @@
 block discarded – undo
         $this->fieldDeliRight = $right;
     }
 
+    /**
+     * @param string $sql
+     */
     public static function createSafeSQL($sql, $list)
     {
         return str_replace(array_keys($list), array_values($list), $sql);

Please login to merge, or discard this patch.

src/Repository/AnyDataset.php 1 patch

Doc Comments +5 added lines, -1 removed lines patch added patch discarded remove patch

@@ -310,6 +310,10 @@  discard block
 block discarded – undo
         return;
     }
 
+    /**
+     * @param SingleRow[] $seq
+     * @param string $field
+     */
     protected function quickSortExec($seq, $field)
     {
         if (!count($seq)) {
@@ -337,7 +341,7 @@  discard block
 block discarded – undo
 
     /**
      * @param $document
-     * @return array|string
+     * @return string
      */
     public static function fixUTF8($document)
     {

Please login to merge, or discard this patch.

src/Repository/DBDataset.php 1 patch

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -131,6 +131,9 @@
 block discarded – undo
         return $arrayDS->getIterator();
     }
 
+    /**
+     * @param string $sql
+     */
     protected function getQueryKey($sql, $array)
     {
         $key1 = md5($sql);

Please login to merge, or discard this patch.

src/Repository/IteratorFilter.php 2 patches

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@  discard block
 block discarded – undo
 
     /**
      *
-     * @param $array
+     * @param SingleRow[] $array
      * @return SingleRow[]
      */
     public function match($array)
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
     /**
      *
      * @param SingleRow $singleRow
-     * @return string
+     * @return boolean
      */
     private function evalString(SingleRow $singleRow)
     {

Please login to merge, or discard this patch.

Switch Indentation +90 added lines, -90 removed lines patch added patch discarded remove patch

@@ -142,37 +142,37 @@  discard block
 block discarded – undo
 
         $result = "";
         switch ($relation) {
-            case Relation::EQUAL:
-                $result = $field . "=" . $value;
-                break;
+        case Relation::EQUAL:
+            $result = $field . "=" . $value;
+            break;
 
-            case Relation::GREATER_THAN:
-                $result = $field . ">" . $value;
-                break;
+        case Relation::GREATER_THAN:
+            $result = $field . ">" . $value;
+            break;
 
-            case Relation::LESS_THAN:
-                $result = $field . "<" . $value;
-                break;
+        case Relation::LESS_THAN:
+            $result = $field . "<" . $value;
+            break;
 
-            case Relation::GREATER_OR_EQUAL_THAN:
-                $result = $field . ">=" . $value;
-                break;
+        case Relation::GREATER_OR_EQUAL_THAN:
+            $result = $field . ">=" . $value;
+            break;
 
-            case Relation::LESS_OR_EQUAL_THAN:
-                $result = $field . "<=" . $value;
-                break;
+        case Relation::LESS_OR_EQUAL_THAN:
+            $result = $field . "<=" . $value;
+            break;
 
-            case Relation::NOT_EQUAL:
-                $result = $field . "!=" . $value;
-                break;
+        case Relation::NOT_EQUAL:
+            $result = $field . "!=" . $value;
+            break;
 
-            case Relation::STARTS_WITH:
-                $result = " starts-with($field, $value) ";
-                break;
+        case Relation::STARTS_WITH:
+            $result = " starts-with($field, $value) ";
+            break;
 
-            case Relation::CONTAINS:
-                $result = " contains($field, $value) ";
-                break;
+        case Relation::CONTAINS:
+            $result = " contains($field, $value) ";
+            break;
 
         }
         return $result;
@@ -201,40 +201,40 @@  discard block
 block discarded – undo
         $field = " $name ";
         $valueparam = " [[" . $paramName . "]] ";
         switch ($relation) {
-            case Relation::EQUAL: {
-                    $result = $field . "=" . $valueparam;
-                    break;
-                }
-            case Relation::GREATER_THAN: {
-                    $result = $field . ">" . $valueparam;
-                    break;
-                }
-            case Relation::LESS_THAN: {
-                    $result = $field . "<" . $valueparam;
-                    break;
-                }
-            case Relation::GREATER_OR_EQUAL_THAN: {
-                    $result = $field . ">=" . $valueparam;
-                    break;
-                }
-            case Relation::LESS_OR_EQUAL_THAN: {
-                    $result = $field . "<=" . $valueparam;
-                    break;
-                }
-            case Relation::NOT_EQUAL: {
-                    $result = $field . "!=" . $valueparam;
-                    break;
-                }
-            case Relation::STARTS_WITH: {
-                    $param[$paramName] = $value . "%";
-                    $result = $field . " like " . $valueparam;
-                    break;
-                }
-            case Relation::CONTAINS: {
-                    $param[$paramName] = "%" . $value . "%";
-                    $result = $field . " like " . $valueparam;
-                    break;
-                }
+        case Relation::EQUAL: {
+                $result = $field . "=" . $valueparam;
+                break;
+            }
+        case Relation::GREATER_THAN: {
+                $result = $field . ">" . $valueparam;
+                break;
+            }
+        case Relation::LESS_THAN: {
+                $result = $field . "<" . $valueparam;
+                break;
+            }
+        case Relation::GREATER_OR_EQUAL_THAN: {
+                $result = $field . ">=" . $valueparam;
+                break;
+            }
+        case Relation::LESS_OR_EQUAL_THAN: {
+                $result = $field . "<=" . $valueparam;
+                break;
+            }
+        case Relation::NOT_EQUAL: {
+                $result = $field . "!=" . $valueparam;
+                break;
+            }
+        case Relation::STARTS_WITH: {
+                $param[$paramName] = $value . "%";
+                $result = $field . " like " . $valueparam;
+                break;
+            }
+        case Relation::CONTAINS: {
+                $param[$paramName] = "%" . $value . "%";
+                $result = $field . " like " . $valueparam;
+                break;
+            }
         }
 
         return $result;
@@ -269,38 +269,38 @@  discard block
 block discarded – undo
 
             foreach ($field as $valueparam) {
                 switch ($relation) {
-                    case Relation::EQUAL: {
-                            $result[$pos] &= ($valueparam == $value);
-                            break;
-                        }
-                    case Relation::GREATER_THAN: {
-                            $result[$pos] &= ($valueparam > $value);
-                            break;
-                        }
-                    case Relation::LESS_THAN: {
-                            $result[$pos] &= ($valueparam < $value);
-                            break;
-                        }
-                    case Relation::GREATER_OR_EQUAL_THAN: {
-                            $result[$pos] &= ($valueparam >= $value);
-                            break;
-                        }
-                    case Relation::LESS_OR_EQUAL_THAN: {
-                            $result[$pos] &= ($valueparam <= $value);
-                            break;
-                        }
-                    case Relation::NOT_EQUAL: {
-                            $result[$pos] &= ($valueparam != $value);
-                            break;
-                        }
-                    case Relation::STARTS_WITH: {
-                            $result[$pos] &= (strpos($valueparam, $value) === 0);
-                            break;
-                        }
-                    case Relation::CONTAINS: {
-                            $result[$pos] &= (strpos($valueparam, $value) !== false);
-                            break;
-                        }
+                case Relation::EQUAL: {
+                        $result[$pos] &= ($valueparam == $value);
+                        break;
+                    }
+                case Relation::GREATER_THAN: {
+                        $result[$pos] &= ($valueparam > $value);
+                        break;
+                    }
+                case Relation::LESS_THAN: {
+                        $result[$pos] &= ($valueparam < $value);
+                        break;
+                    }
+                case Relation::GREATER_OR_EQUAL_THAN: {
+                        $result[$pos] &= ($valueparam >= $value);
+                        break;
+                    }
+                case Relation::LESS_OR_EQUAL_THAN: {
+                        $result[$pos] &= ($valueparam <= $value);
+                        break;
+                    }
+                case Relation::NOT_EQUAL: {
+                        $result[$pos] &= ($valueparam != $value);
+                        break;
+                    }
+                case Relation::STARTS_WITH: {
+                        $result[$pos] &= (strpos($valueparam, $value) === 0);
+                        break;
+                    }
+                case Relation::CONTAINS: {
+                        $result[$pos] &= (strpos($valueparam, $value) !== false);
+                        break;
+                    }
                 }
             }
         }

Please login to merge, or discard this patch.

		@@ -160,6 +160,9 @@
		block discarded – undo
160	160	$this->fieldDeliRight = $right;
161	161	}
162	162
	163	+ /**
	164	+ * @param string $sql
	165	+ */
163	166	public static function createSafeSQL($sql, $list)
164	167	{
165	168	return str_replace(array_keys($list), array_values($list), $sql);

		@@ -310,6 +310,10 @@ discard block
		block discarded – undo
310	310	return;
311	311	}
312	312
	313	+ /**
	314	+ * @param SingleRow[] $seq
	315	+ * @param string $field
	316	+ */
313	317	protected function quickSortExec($seq, $field)
314	318	{
315	319	if (!count($seq)) {
		@@ -337,7 +341,7 @@ discard block
		block discarded – undo
337	341
338	342	/**
339	343	* @param $document
340		- * @return array\|string
	344	+ * @return string
341	345	*/
342	346	public static function fixUTF8($document)
343	347	{

		@@ -131,6 +131,9 @@
		block discarded – undo
131	131	return $arrayDS->getIterator();
132	132	}
133	133
	134	+ /**
	135	+ * @param string $sql
	136	+ */
134	137	protected function getQueryKey($sql, $array)
135	138	{
136	139	$key1 = md5($sql);

		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73
74	74	/**
75	75	*
76		- * @param $array
	76	+ * @param SingleRow[] $array
77	77	* @return SingleRow[]
78	78	*/
79	79	public function match($array)
		@@ -243,7 +243,7 @@ discard block
		block discarded – undo
243	243	/**
244	244	*
245	245	* @param SingleRow $singleRow
246		- * @return string
	246	+ * @return boolean
247	247	*/
248	248	private function evalString(SingleRow $singleRow)
249	249	{

		@@ -142,37 +142,37 @@ discard block
		block discarded – undo
142	142
143	143	$result = "";
144	144	switch ($relation) {
145		- case Relation::EQUAL:
146		- $result = $field . "=" . $value;
147		- break;
	145	+ case Relation::EQUAL:
	146	+ $result = $field . "=" . $value;
	147	+ break;
148	148
149		- case Relation::GREATER_THAN:
150		- $result = $field . ">" . $value;
151		- break;
	149	+ case Relation::GREATER_THAN:
	150	+ $result = $field . ">" . $value;
	151	+ break;
152	152
153		- case Relation::LESS_THAN:
154		- $result = $field . "<" . $value;
155		- break;
	153	+ case Relation::LESS_THAN:
	154	+ $result = $field . "<" . $value;
	155	+ break;
156	156
157		- case Relation::GREATER_OR_EQUAL_THAN:
158		- $result = $field . ">=" . $value;
159		- break;
	157	+ case Relation::GREATER_OR_EQUAL_THAN:
	158	+ $result = $field . ">=" . $value;
	159	+ break;
160	160
161		- case Relation::LESS_OR_EQUAL_THAN:
162		- $result = $field . "<=" . $value;
163		- break;
	161	+ case Relation::LESS_OR_EQUAL_THAN:
	162	+ $result = $field . "<=" . $value;
	163	+ break;
164	164
165		- case Relation::NOT_EQUAL:
166		- $result = $field . "!=" . $value;
167		- break;
	165	+ case Relation::NOT_EQUAL:
	166	+ $result = $field . "!=" . $value;
	167	+ break;
168	168
169		- case Relation::STARTS_WITH:
170		- $result = " starts-with($field, $value) ";
171		- break;
	169	+ case Relation::STARTS_WITH:
	170	+ $result = " starts-with($field, $value) ";
	171	+ break;
172	172
173		- case Relation::CONTAINS:
174		- $result = " contains($field, $value) ";
175		- break;
	173	+ case Relation::CONTAINS:
	174	+ $result = " contains($field, $value) ";
	175	+ break;
176	176
177	177	}
178	178	return $result;
		@@ -201,40 +201,40 @@ discard block
		block discarded – undo
201	201	$field = " $name ";
202	202	$valueparam = " [[" . $paramName . "]] ";
203	203	switch ($relation) {
204		- case Relation::EQUAL: {
205		- $result = $field . "=" . $valueparam;
206		- break;
207		- }
208		- case Relation::GREATER_THAN: {
209		- $result = $field . ">" . $valueparam;
210		- break;
211		- }
212		- case Relation::LESS_THAN: {
213		- $result = $field . "<" . $valueparam;
214		- break;
215		- }
216		- case Relation::GREATER_OR_EQUAL_THAN: {
217		- $result = $field . ">=" . $valueparam;
218		- break;
219		- }
220		- case Relation::LESS_OR_EQUAL_THAN: {
221		- $result = $field . "<=" . $valueparam;
222		- break;
223		- }
224		- case Relation::NOT_EQUAL: {
225		- $result = $field . "!=" . $valueparam;
226		- break;
227		- }
228		- case Relation::STARTS_WITH: {
229		- $param[$paramName] = $value . "%";
230		- $result = $field . " like " . $valueparam;
231		- break;
232		- }
233		- case Relation::CONTAINS: {
234		- $param[$paramName] = "%" . $value . "%";
235		- $result = $field . " like " . $valueparam;
236		- break;
237		- }
	204	+ case Relation::EQUAL: {
	205	+ $result = $field . "=" . $valueparam;
	206	+ break;
	207	+ }
	208	+ case Relation::GREATER_THAN: {
	209	+ $result = $field . ">" . $valueparam;
	210	+ break;
	211	+ }
	212	+ case Relation::LESS_THAN: {
	213	+ $result = $field . "<" . $valueparam;
	214	+ break;
	215	+ }
	216	+ case Relation::GREATER_OR_EQUAL_THAN: {
	217	+ $result = $field . ">=" . $valueparam;
	218	+ break;
	219	+ }
	220	+ case Relation::LESS_OR_EQUAL_THAN: {
	221	+ $result = $field . "<=" . $valueparam;
	222	+ break;
	223	+ }
	224	+ case Relation::NOT_EQUAL: {
	225	+ $result = $field . "!=" . $valueparam;
	226	+ break;
	227	+ }
	228	+ case Relation::STARTS_WITH: {
	229	+ $param[$paramName] = $value . "%";
	230	+ $result = $field . " like " . $valueparam;
	231	+ break;
	232	+ }
	233	+ case Relation::CONTAINS: {
	234	+ $param[$paramName] = "%" . $value . "%";
	235	+ $result = $field . " like " . $valueparam;
	236	+ break;
	237	+ }
238	238	}
239	239
240	240	return $result;
		@@ -269,38 +269,38 @@ discard block
		block discarded – undo
269	269
270	270	foreach ($field as $valueparam) {
271	271	switch ($relation) {
272		- case Relation::EQUAL: {
273		- $result[$pos] &= ($valueparam == $value);
274		- break;
275		- }
276		- case Relation::GREATER_THAN: {
277		- $result[$pos] &= ($valueparam > $value);
278		- break;
279		- }
280		- case Relation::LESS_THAN: {
281		- $result[$pos] &= ($valueparam < $value);
282		- break;
283		- }
284		- case Relation::GREATER_OR_EQUAL_THAN: {
285		- $result[$pos] &= ($valueparam >= $value);
286		- break;
287		- }
288		- case Relation::LESS_OR_EQUAL_THAN: {
289		- $result[$pos] &= ($valueparam <= $value);
290		- break;
291		- }
292		- case Relation::NOT_EQUAL: {
293		- $result[$pos] &= ($valueparam != $value);
294		- break;
295		- }
296		- case Relation::STARTS_WITH: {
297		- $result[$pos] &= (strpos($valueparam, $value) === 0);
298		- break;
299		- }
300		- case Relation::CONTAINS: {
301		- $result[$pos] &= (strpos($valueparam, $value) !== false);
302		- break;
303		- }
	272	+ case Relation::EQUAL: {
	273	+ $result[$pos] &= ($valueparam == $value);
	274	+ break;
	275	+ }
	276	+ case Relation::GREATER_THAN: {
	277	+ $result[$pos] &= ($valueparam > $value);
	278	+ break;
	279	+ }
	280	+ case Relation::LESS_THAN: {
	281	+ $result[$pos] &= ($valueparam < $value);
	282	+ break;
	283	+ }
	284	+ case Relation::GREATER_OR_EQUAL_THAN: {
	285	+ $result[$pos] &= ($valueparam >= $value);
	286	+ break;
	287	+ }
	288	+ case Relation::LESS_OR_EQUAL_THAN: {
	289	+ $result[$pos] &= ($valueparam <= $value);
	290	+ break;
	291	+ }
	292	+ case Relation::NOT_EQUAL: {
	293	+ $result[$pos] &= ($valueparam != $value);
	294	+ break;
	295	+ }
	296	+ case Relation::STARTS_WITH: {
	297	+ $result[$pos] &= (strpos($valueparam, $value) === 0);
	298	+ break;
	299	+ }
	300	+ case Relation::CONTAINS: {
	301	+ $result[$pos] &= (strpos($valueparam, $value) !== false);
	302	+ break;
	303	+ }
304	304	}
305	305	}
306	306	}

byjg / anydataset

Pull Request — master (#1)

Status

Category

Doc Comments +3 added lines patch added patch discarded remove patch

Doc Comments +5 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Switch Indentation +90 added lines, -90 removed lines patch added patch discarded remove patch