Issues in Annotations.php - New Issues - Inspection of "Merge branch 'improve-objecthandler'" - byjg/anydataset - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1857e6...d96bec )

by Joao

created 2016-05-11 02:28 UTC

src/Model/Annotations.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace ByJG\AnyDataset\Model;

use ReflectionClass;
use SparQL\Exception;

abstract class Annotations
{
    protected $config = "object";
    protected $annotations;
    

    public function getAnnotations($key = null, $default = null)
    {
        if ($key == null) {
            return $this->annotations;
        }

        if (!isset($this->annotations["$this->config:$key"])) {
            return $default;
        }

        if (is_bool($default)) {
            return array_key_exists($key, $this->annotations);
        }

        return $this->annotations["$this->config:$key"];
    }

    protected function replaceVars($name, $text)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        # Host
        $port = isset($_SERVER["SERVER_PORT"]) ? $_SERVER["SERVER_PORT"] : 80;
        $httpHost = isset($_SERVER["HTTP_HOST"]) ? $_SERVER["HTTP_HOST"] : 'localhost';
        $host = ($port == 443 ? "https://" : "http://").$httpHost;
        # Replace Part One
        $text = preg_replace(array("/\{[hH][oO][sS][tT]\}/", "/\{[cC][lL][aA][sS][sS]\}/"), array($host, $name), $text);
        if (preg_match('/(\{(\S+)\})/', $text, $matches)) {
            $class = new ReflectionClass(get_class($this->_model));
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $method = str_replace("()", "", $matches[2]);
            $value = spl_object_hash($this->_model);
            if ($class->hasMethod($method)) {
                try {
                    $value = $this->_model->$method();
                } catch (Exception $ex) {
                    $value = "***$value***";
                }
            }
            $text = preg_replace('/(\{(\S+)\})/', $value, $text);
        }
        return $text;
    }

    protected function adjustParams($arr)
    {
        $count = count($arr[0]);
        $result = array();

        for ($i = 0; $i < $count; $i++) {
            $key = strtolower($arr["param"][$i]);
            $value = $arr["value"][$i];

            if (!array_key_exists($key, $result)) {
                $result[$key] = $value;
            } elseif (is_array($result[$key])) {
                $result[$key][] = $value;
            } else {
                $result[$key] = array($result[$key], $value);
            }
        }

        return $result;
    }

}


1			<?php
2
3			namespace ByJG\AnyDataset\Model;
4
5			use ReflectionClass;
6			use SparQL\Exception;
7
8			abstract class Annotations
9			{
10			protected $config = "object";
11			protected $annotations;
12
13
14			public function getAnnotations($key = null, $default = null)
15			{
16			if ($key == null) {
17			return $this->annotations;
18			}
19
20			if (!isset($this->annotations["$this->config:$key"])) {
21			return $default;
22			}
23
24			if (is_bool($default)) {
25			return array_key_exists($key, $this->annotations);
26			}
27
28			return $this->annotations["$this->config:$key"];
29			}
30
31			protected function replaceVars($name, $text)
			0 ignored issues – show Coding Style introduced 2016-05-11 02:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `replaceVars` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
32			{
33			# Host
34			$port = isset($_SERVER["SERVER_PORT"]) ? $_SERVER["SERVER_PORT"] : 80;
35			$httpHost = isset($_SERVER["HTTP_HOST"]) ? $_SERVER["HTTP_HOST"] : 'localhost';
36			$host = ($port == 443 ? "https://" : "http://").$httpHost;
37			# Replace Part One
38			$text = preg_replace(array("/\{[hH][oO][sS][tT]\}/", "/\{[cC][lL][aA][sS][sS]\}/"), array($host, $name), $text);
39			if (preg_match('/(\{(\S+)\})/', $text, $matches)) {
40			$class = new ReflectionClass(get_class($this->_model));
			0 ignored issues – show Bug introduced 2016-05-11 02:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `_model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41			$method = str_replace("()", "", $matches[2]);
42			$value = spl_object_hash($this->_model);
43			if ($class->hasMethod($method)) {
44			try {
45			$value = $this->_model->$method();
46			} catch (Exception $ex) {
47			$value = "*$value*";
48			}
49			}
50			$text = preg_replace('/(\{(\S+)\})/', $value, $text);
51			}
52			return $text;
53			}
54
55			protected function adjustParams($arr)
56			{
57			$count = count($arr[0]);
58			$result = array();
59
60			for ($i = 0; $i < $count; $i++) {
61			$key = strtolower($arr["param"][$i]);
62			$value = $arr["value"][$i];
63
64			if (!array_key_exists($key, $result)) {
65			$result[$key] = $value;
66			} elseif (is_array($result[$key])) {
67			$result[$key][] = $value;
68			} else {
69			$result[$key] = array($result[$key], $value);
70			}
71			}
72
73			return $result;
74			}
75
76			}
77

byjg / anydataset

Push — master ( 1857e6...d96bec )

src/Model/Annotations.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like