ByJG\AnyDataset\Repository\XmlDataset

Complexity

Total Complexity

6

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	3
Bugs	2	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	24	5
A	getIterator()	0	6	1

<?php

namespace ByJG\AnyDataset\Repository;

use ByJG\AnyDataset\Exception\DatasetException;
use ByJG\Util\XmlUtil;
use DOMDocument;
use InvalidArgumentException;

class XmlDataset
{

    /**
     * String
     *
     * @var string
     */
    private $_rowNode = null;

    /**
     * Enter description here...
     *
     * @var string[]
     */
    private $_colNodes = null;

    /**
     * @var DOMDocument
     */
    private $_domDocument;

    /**
     *
     * @var string
     */
    protected $_registerNS;

    /**
     *
     * @param DOMDocument $xml
     * @param string $rowNode
     * @param string[] $colNode
     * @param array $registerNS
     * @throws DatasetException
     * @throws InvalidArgumentException
     */
    public function __construct($xml, $rowNode, $colNode, $registerNS = null)
    {
        if (!is_array($colNode)) {
            throw new DatasetException("XmlDataset constructor: Column nodes must be an array.");
        }

        if ($xml instanceof DOMDocument) {
            $this->_domDocument = $xml;
        } else {
            $this->_domDocument = XmlUtil::createXmlDocumentFromStr($xml);
        }

        if (is_null($registerNS)) {
            $registerNS = array();
        }

        if (!is_array($registerNS)) {
            throw new InvalidArgumentException('The parameter $registerNS must be an associative array');
        }

        $this->_registerNS = $registerNS;

It seems like $registerNS of type array is incompatible with the declared type string of property $_registerNS.

        $this->_rowNode = $rowNode;
        $this->_colNodes = $colNode;
    }

    /**
     * @access public
     * @return DBIterator
     */
    public function getIterator()
    {
        $it = new XmlIterator(XmlUtil::selectNodes($this->_domDocument->documentElement, $this->_rowNode,
                $this->_registerNS), $this->_colNodes, $this->_registerNS);

$this->_registerNS is of type string, but the function expects a array|null.

        return $it;
    }
}