ByJG\AnyDataset\Repository\SQLRelayIterator

Complexity

Total Complexity

15

Size/Duplication

Total Lines	105
Duplicated Lines	9.52 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	7
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	count()	0	4	1
C	hasNext()	0	41	8
A	__destruct()	0	7	2
A	moveNext()	10	10	2
A	key()	0	4	1

<?php

namespace ByJG\AnyDataset\Repository;

use ByJG\AnyDataset\Exception\IteratorException;

class SQLRelayIterator extends GenericIterator
{

    const RECORD_BUFFER = 50;

    private $_rowBuffer;
    protected $_currentRow = 0;
    protected $_moveNextRow = 0;

    /**
     * @var resource 
     */
    private $_cursor;

    /**
     *
     * @param resource $cursor
     */
    public function __construct($cursor)
    {
        $this->_cursor = $cursor;
        $this->_rowBuffer = array();
    }

    /**
     * @return int
     */
    public function count()
    {
        return sqlrcur_rowCount($this->_cursor);
    }

    /**
     * @return bool
     */
    public function hasNext()
    {
        if (count($this->_rowBuffer) >= SQLRelayIterator::RECORD_BUFFER) {
            return true;
        } else if (is_null($this->_cursor)) {
            return (count($this->_rowBuffer) > 0);
        } else if ($this->_currentRow < $this->count()) {
            $sr = new SingleRow();

            $colCount = sqlrcur_colCount($this->_cursor);
            for ($col = 0; $col < $colCount; $col++) {
                $fieldName = strtolower(sqlrcur_getColumnName($this->_cursor, $col));
                $value = sqlrcur_getField($this->_cursor, $this->_currentRow, $col);

                if (is_null($value)) {
                    $sr->addField($fieldName, "");
                } elseif (is_object($value)) {
                    $sr->addField($fieldName, "[OBJECT]");
                } else {
                    $value = AnyDataset::fixUTF8($value);
                    $sr->addField($fieldName, $value);

It seems like $value defined by \ByJG\AnyDataset\Repository\AnyDataset::fixUTF8($value) on line 61 can also be of type array; however, ByJG\AnyDataset\Repository\SingleRow::addField() does only seem to accept string, maybe add an additional type check?

                }
            }

            $this->_currentRow++;

            // Enfileira o registo
            array_push($this->_rowBuffer, $sr);
            // Traz novos até encher o Buffer
            if (count($this->_rowBuffer) < DBIterator::RECORD_BUFFER) {
                $this->hasNext();
            }

            return true;
        } else {
            sqlrcur_free($this->_cursor);
            $this->_cursor = null;

            return (count($this->_rowBuffer) > 0);
        }
    }

    public function __destruct()
    {
        if (!is_null($this->_cursor)) {
            @sqlrcur_free($this->_cursor);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $this->_cursor = null;
        }
    }

    /**
     * @return SingleRow
     * @throws IteratorException
     */
    public function moveNext()

This method seems to be duplicated in your project.

    {
        if (!$this->hasNext()) {
            throw new IteratorException("No more records. Did you used hasNext() before moveNext()?");
        } else {
            $sr = array_shift($this->_rowBuffer);
            $this->_moveNextRow++;
            return $sr;
        }
    }

    function key()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->_moveNextRow;
    }
}