Inspection of "3.0.0" - byjg/anydataset - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Joao

created 2017-05-27 20:14 UTC

Status

Switch Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -44,39 +44,39 @@
 block discarded – undo
         $field = " $name ";
         $valueparam = " [[" . $paramName . "]] ";
         switch ($relation) {
-            case Relation::EQUAL:
-                $result = $field . "=" . $valueparam;
-                break;
-
-            case Relation::GREATER_THAN:
-                $result = $field . ">" . $valueparam;
-                break;
-
-            case Relation::LESS_THAN:
-                $result = $field . "<" . $valueparam;
-                break;
-
-            case Relation::GREATER_OR_EQUAL_THAN:
-                $result = $field . ">=" . $valueparam;
-                break;
-
-            case Relation::LESS_OR_EQUAL_THAN:
-                $result = $field . "<=" . $valueparam;
-                break;
-
-            case Relation::NOT_EQUAL:
-                $result = $field . "!=" . $valueparam;
-                break;
-
-            case Relation::STARTS_WITH:
-                $param[$paramName] = $value . "%";
-                $result = $field . " like " . $valueparam;
-                break;
-
-            case Relation::CONTAINS:
-                $param[$paramName] = "%" . $value . "%";
-                $result = $field . " like " . $valueparam;
-                break;
+        case Relation::EQUAL:
+            $result = $field . "=" . $valueparam;
+            break;
+
+        case Relation::GREATER_THAN:
+            $result = $field . ">" . $valueparam;
+            break;
+
+        case Relation::LESS_THAN:
+            $result = $field . "<" . $valueparam;
+            break;
+
+        case Relation::GREATER_OR_EQUAL_THAN:
+            $result = $field . ">=" . $valueparam;
+            break;
+
+        case Relation::LESS_OR_EQUAL_THAN:
+            $result = $field . "<=" . $valueparam;
+            break;
+
+        case Relation::NOT_EQUAL:
+            $result = $field . "!=" . $valueparam;
+            break;
+
+        case Relation::STARTS_WITH:
+            $param[$paramName] = $value . "%";
+            $result = $field . " like " . $valueparam;
+            break;
+
+        case Relation::CONTAINS:
+            $param[$paramName] = "%" . $value . "%";
+            $result = $field . " like " . $valueparam;
+            break;
 
         }
 

Please login to merge, or discard this patch.

src/Dataset/IteratorFilter.php 1 patch

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -73,37 +73,37 @@
 block discarded – undo
 
             foreach ($field as $valueparam) {
                 switch ($relation) {
-                    case Relation::EQUAL:
-                        $result[$pos] &= ($valueparam == $value);
-                        break;
+                case Relation::EQUAL:
+                    $result[$pos] &= ($valueparam == $value);
+                    break;
 
-                    case Relation::GREATER_THAN:
-                        $result[$pos] &= ($valueparam > $value);
-                        break;
+                case Relation::GREATER_THAN:
+                    $result[$pos] &= ($valueparam > $value);
+                    break;
 
-                    case Relation::LESS_THAN:
-                        $result[$pos] &= ($valueparam < $value);
-                        break;
+                case Relation::LESS_THAN:
+                    $result[$pos] &= ($valueparam < $value);
+                    break;
 
-                    case Relation::GREATER_OR_EQUAL_THAN:
-                        $result[$pos] &= ($valueparam >= $value);
-                        break;
+                case Relation::GREATER_OR_EQUAL_THAN:
+                    $result[$pos] &= ($valueparam >= $value);
+                    break;
 
-                    case Relation::LESS_OR_EQUAL_THAN:
-                        $result[$pos] &= ($valueparam <= $value);
-                        break;
+                case Relation::LESS_OR_EQUAL_THAN:
+                    $result[$pos] &= ($valueparam <= $value);
+                    break;
 
-                    case Relation::NOT_EQUAL:
-                        $result[$pos] &= ($valueparam != $value);
-                        break;
+                case Relation::NOT_EQUAL:
+                    $result[$pos] &= ($valueparam != $value);
+                    break;
 
-                    case Relation::STARTS_WITH:
-                        $result[$pos] &= (strpos($valueparam, $value) === 0);
-                        break;
+                case Relation::STARTS_WITH:
+                    $result[$pos] &= (strpos($valueparam, $value) === 0);
+                    break;
 
-                    case Relation::CONTAINS:
-                        $result[$pos] &= (strpos($valueparam, $value) !== false);
-                        break;
+                case Relation::CONTAINS:
+                    $result[$pos] &= (strpos($valueparam, $value) !== false);
+                    break;
 
                 }
             }

Please login to merge, or discard this patch.

src/Dataset/IteratorFilterXPathFormatter.php 1 patch

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -26,37 +26,37 @@
 block discarded – undo
 
         $result = "";
         switch ($relation) {
-            case Relation::EQUAL:
-                $result = $field . "=" . $value;
-                break;
+        case Relation::EQUAL:
+            $result = $field . "=" . $value;
+            break;
 
-            case Relation::GREATER_THAN:
-                $result = $field . ">" . $value;
-                break;
+        case Relation::GREATER_THAN:
+            $result = $field . ">" . $value;
+            break;
 
-            case Relation::LESS_THAN:
-                $result = $field . "<" . $value;
-                break;
+        case Relation::LESS_THAN:
+            $result = $field . "<" . $value;
+            break;
 
-            case Relation::GREATER_OR_EQUAL_THAN:
-                $result = $field . ">=" . $value;
-                break;
+        case Relation::GREATER_OR_EQUAL_THAN:
+            $result = $field . ">=" . $value;
+            break;
 
-            case Relation::LESS_OR_EQUAL_THAN:
-                $result = $field . "<=" . $value;
-                break;
+        case Relation::LESS_OR_EQUAL_THAN:
+            $result = $field . "<=" . $value;
+            break;
 
-            case Relation::NOT_EQUAL:
-                $result = $field . "!=" . $value;
-                break;
+        case Relation::NOT_EQUAL:
+            $result = $field . "!=" . $value;
+            break;
 
-            case Relation::STARTS_WITH:
-                $result = " starts-with($field, $value) ";
-                break;
+        case Relation::STARTS_WITH:
+            $result = " starts-with($field, $value) ";
+            break;
 
-            case Relation::CONTAINS:
-                $result = " contains($field, $value) ";
-                break;
+        case Relation::CONTAINS:
+            $result = " contains($field, $value) ";
+            break;
 
         }
         return $result;

Please login to merge, or discard this patch.

src/Dataset/JsonDataset.php 1 patch

Switch Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -23,27 +23,27 @@
 block discarded – undo
 
         $lastError = json_last_error();
         switch ($lastError) {
-            case JSON_ERROR_NONE:
-                $lastErrorDesc = 'No errors';
-                break;
-            case JSON_ERROR_DEPTH:
-                $lastErrorDesc = 'Maximum stack depth exceeded';
-                break;
-            case JSON_ERROR_STATE_MISMATCH:
-                $lastErrorDesc = 'Underflow or the modes mismatch';
-                break;
-            case JSON_ERROR_CTRL_CHAR:
-                $lastErrorDesc = 'Unexpected control character found';
-                break;
-            case JSON_ERROR_SYNTAX:
-                $lastErrorDesc = 'Syntax error, malformed JSON';
-                break;
-            case JSON_ERROR_UTF8:
-                $lastErrorDesc = 'Malformed UTF-8 characters, possibly incorrectly encoded';
-                break;
-            default:
-                $lastErrorDesc = 'Unknown error';
-                break;
+        case JSON_ERROR_NONE:
+            $lastErrorDesc = 'No errors';
+            break;
+        case JSON_ERROR_DEPTH:
+            $lastErrorDesc = 'Maximum stack depth exceeded';
+            break;
+        case JSON_ERROR_STATE_MISMATCH:
+            $lastErrorDesc = 'Underflow or the modes mismatch';
+            break;
+        case JSON_ERROR_CTRL_CHAR:
+            $lastErrorDesc = 'Unexpected control character found';
+            break;
+        case JSON_ERROR_SYNTAX:
+            $lastErrorDesc = 'Syntax error, malformed JSON';
+            break;
+        case JSON_ERROR_UTF8:
+            $lastErrorDesc = 'Malformed UTF-8 characters, possibly incorrectly encoded';
+            break;
+        default:
+            $lastErrorDesc = 'Unknown error';
+            break;
         }
 
         if ($lastError != JSON_ERROR_NONE) {

Please login to merge, or discard this patch.

src/Store/MongoDbDriver.php 1 patch

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -162,37 +162,37 @@
 block discarded – undo
             }
 
             switch ($relation) {
-                case Relation::EQUAL:
-                    $result[$name] = $value;
-                    break;
+            case Relation::EQUAL:
+                $result[$name] = $value;
+                break;
 
-                case Relation::GREATER_THAN:
-                    $result[$name] = [ '$gt' => $value ];
-                    break;
+            case Relation::GREATER_THAN:
+                $result[$name] = [ '$gt' => $value ];
+                break;
 
-                case Relation::LESS_THAN:
-                    $result[$name] = [ '$lt' => $value ];
-                    break;
+            case Relation::LESS_THAN:
+                $result[$name] = [ '$lt' => $value ];
+                break;
 
-                case Relation::GREATER_OR_EQUAL_THAN:
-                    $result[$name] = [ '$gte' => $value ];
-                    break;
+            case Relation::GREATER_OR_EQUAL_THAN:
+                $result[$name] = [ '$gte' => $value ];
+                break;
 
-                case Relation::LESS_OR_EQUAL_THAN:
-                    $result[$name] = [ '$lte' => $value ];
-                    break;
+            case Relation::LESS_OR_EQUAL_THAN:
+                $result[$name] = [ '$lte' => $value ];
+                break;
 
-                case Relation::NOT_EQUAL:
-                    $result[$name] = [ '$ne' => $value ];
-                    break;
+            case Relation::NOT_EQUAL:
+                $result[$name] = [ '$ne' => $value ];
+                break;
 
-                case Relation::STARTS_WITH:
-                    $result[$name] = [ '$regex' => "^$value" ];
-                    break;
+            case Relation::STARTS_WITH:
+                $result[$name] = [ '$regex' => "^$value" ];
+                break;
 
-                case Relation::CONTAINS:
-                    $result[$name] = [ '$regex' => "$value" ];
-                    break;
+            case Relation::CONTAINS:
+                $result[$name] = [ '$regex' => "$value" ];
+                break;
 
             }
         }

Please login to merge, or discard this patch.

		@@ -44,39 +44,39 @@
		block discarded – undo
44	44	$field = " $name ";
45	45	$valueparam = " [[" . $paramName . "]] ";
46	46	switch ($relation) {
47		- case Relation::EQUAL:
48		- $result = $field . "=" . $valueparam;
49		- break;
50		-
51		- case Relation::GREATER_THAN:
52		- $result = $field . ">" . $valueparam;
53		- break;
54		-
55		- case Relation::LESS_THAN:
56		- $result = $field . "<" . $valueparam;
57		- break;
58		-
59		- case Relation::GREATER_OR_EQUAL_THAN:
60		- $result = $field . ">=" . $valueparam;
61		- break;
62		-
63		- case Relation::LESS_OR_EQUAL_THAN:
64		- $result = $field . "<=" . $valueparam;
65		- break;
66		-
67		- case Relation::NOT_EQUAL:
68		- $result = $field . "!=" . $valueparam;
69		- break;
70		-
71		- case Relation::STARTS_WITH:
72		- $param[$paramName] = $value . "%";
73		- $result = $field . " like " . $valueparam;
74		- break;
75		-
76		- case Relation::CONTAINS:
77		- $param[$paramName] = "%" . $value . "%";
78		- $result = $field . " like " . $valueparam;
79		- break;
	47	+ case Relation::EQUAL:
	48	+ $result = $field . "=" . $valueparam;
	49	+ break;
	50	+
	51	+ case Relation::GREATER_THAN:
	52	+ $result = $field . ">" . $valueparam;
	53	+ break;
	54	+
	55	+ case Relation::LESS_THAN:
	56	+ $result = $field . "<" . $valueparam;
	57	+ break;
	58	+
	59	+ case Relation::GREATER_OR_EQUAL_THAN:
	60	+ $result = $field . ">=" . $valueparam;
	61	+ break;
	62	+
	63	+ case Relation::LESS_OR_EQUAL_THAN:
	64	+ $result = $field . "<=" . $valueparam;
	65	+ break;
	66	+
	67	+ case Relation::NOT_EQUAL:
	68	+ $result = $field . "!=" . $valueparam;
	69	+ break;
	70	+
	71	+ case Relation::STARTS_WITH:
	72	+ $param[$paramName] = $value . "%";
	73	+ $result = $field . " like " . $valueparam;
	74	+ break;
	75	+
	76	+ case Relation::CONTAINS:
	77	+ $param[$paramName] = "%" . $value . "%";
	78	+ $result = $field . " like " . $valueparam;
	79	+ break;
80	80
81	81	}
82	82

		@@ -73,37 +73,37 @@
		block discarded – undo
73	73
74	74	foreach ($field as $valueparam) {
75	75	switch ($relation) {
76		- case Relation::EQUAL:
77		- $result[$pos] &= ($valueparam == $value);
78		- break;
	76	+ case Relation::EQUAL:
	77	+ $result[$pos] &= ($valueparam == $value);
	78	+ break;
79	79
80		- case Relation::GREATER_THAN:
81		- $result[$pos] &= ($valueparam > $value);
82		- break;
	80	+ case Relation::GREATER_THAN:
	81	+ $result[$pos] &= ($valueparam > $value);
	82	+ break;
83	83
84		- case Relation::LESS_THAN:
85		- $result[$pos] &= ($valueparam < $value);
86		- break;
	84	+ case Relation::LESS_THAN:
	85	+ $result[$pos] &= ($valueparam < $value);
	86	+ break;
87	87
88		- case Relation::GREATER_OR_EQUAL_THAN:
89		- $result[$pos] &= ($valueparam >= $value);
90		- break;
	88	+ case Relation::GREATER_OR_EQUAL_THAN:
	89	+ $result[$pos] &= ($valueparam >= $value);
	90	+ break;
91	91
92		- case Relation::LESS_OR_EQUAL_THAN:
93		- $result[$pos] &= ($valueparam <= $value);
94		- break;
	92	+ case Relation::LESS_OR_EQUAL_THAN:
	93	+ $result[$pos] &= ($valueparam <= $value);
	94	+ break;
95	95
96		- case Relation::NOT_EQUAL:
97		- $result[$pos] &= ($valueparam != $value);
98		- break;
	96	+ case Relation::NOT_EQUAL:
	97	+ $result[$pos] &= ($valueparam != $value);
	98	+ break;
99	99
100		- case Relation::STARTS_WITH:
101		- $result[$pos] &= (strpos($valueparam, $value) === 0);
102		- break;
	100	+ case Relation::STARTS_WITH:
	101	+ $result[$pos] &= (strpos($valueparam, $value) === 0);
	102	+ break;
103	103
104		- case Relation::CONTAINS:
105		- $result[$pos] &= (strpos($valueparam, $value) !== false);
106		- break;
	104	+ case Relation::CONTAINS:
	105	+ $result[$pos] &= (strpos($valueparam, $value) !== false);
	106	+ break;
107	107
108	108	}
109	109	}

		@@ -162,37 +162,37 @@
		block discarded – undo
162	162	}
163	163
164	164	switch ($relation) {
165		- case Relation::EQUAL:
166		- $result[$name] = $value;
167		- break;
	165	+ case Relation::EQUAL:
	166	+ $result[$name] = $value;
	167	+ break;
168	168
169		- case Relation::GREATER_THAN:
170		- $result[$name] = [ '$gt' => $value ];
171		- break;
	169	+ case Relation::GREATER_THAN:
	170	+ $result[$name] = [ '$gt' => $value ];
	171	+ break;
172	172
173		- case Relation::LESS_THAN:
174		- $result[$name] = [ '$lt' => $value ];
175		- break;
	173	+ case Relation::LESS_THAN:
	174	+ $result[$name] = [ '$lt' => $value ];
	175	+ break;
176	176
177		- case Relation::GREATER_OR_EQUAL_THAN:
178		- $result[$name] = [ '$gte' => $value ];
179		- break;
	177	+ case Relation::GREATER_OR_EQUAL_THAN:
	178	+ $result[$name] = [ '$gte' => $value ];
	179	+ break;
180	180
181		- case Relation::LESS_OR_EQUAL_THAN:
182		- $result[$name] = [ '$lte' => $value ];
183		- break;
	181	+ case Relation::LESS_OR_EQUAL_THAN:
	182	+ $result[$name] = [ '$lte' => $value ];
	183	+ break;
184	184
185		- case Relation::NOT_EQUAL:
186		- $result[$name] = [ '$ne' => $value ];
187		- break;
	185	+ case Relation::NOT_EQUAL:
	186	+ $result[$name] = [ '$ne' => $value ];
	187	+ break;
188	188
189		- case Relation::STARTS_WITH:
190		- $result[$name] = [ '$regex' => "^$value" ];
191		- break;
	189	+ case Relation::STARTS_WITH:
	190	+ $result[$name] = [ '$regex' => "^$value" ];
	191	+ break;
192	192
193		- case Relation::CONTAINS:
194		- $result[$name] = [ '$regex' => "$value" ];
195		- break;
	193	+ case Relation::CONTAINS:
	194	+ $result[$name] = [ '$regex' => "$value" ];
	195	+ break;
196	196
197	197	}
198	198	}

		@@ -26,37 +26,37 @@
		block discarded – undo
26	26
27	27	$result = "";
28	28	switch ($relation) {
29		- case Relation::EQUAL:
30		- $result = $field . "=" . $value;
31		- break;
	29	+ case Relation::EQUAL:
	30	+ $result = $field . "=" . $value;
	31	+ break;
32	32
33		- case Relation::GREATER_THAN:
34		- $result = $field . ">" . $value;
35		- break;
	33	+ case Relation::GREATER_THAN:
	34	+ $result = $field . ">" . $value;
	35	+ break;
36	36
37		- case Relation::LESS_THAN:
38		- $result = $field . "<" . $value;
39		- break;
	37	+ case Relation::LESS_THAN:
	38	+ $result = $field . "<" . $value;
	39	+ break;
40	40
41		- case Relation::GREATER_OR_EQUAL_THAN:
42		- $result = $field . ">=" . $value;
43		- break;
	41	+ case Relation::GREATER_OR_EQUAL_THAN:
	42	+ $result = $field . ">=" . $value;
	43	+ break;
44	44
45		- case Relation::LESS_OR_EQUAL_THAN:
46		- $result = $field . "<=" . $value;
47		- break;
	45	+ case Relation::LESS_OR_EQUAL_THAN:
	46	+ $result = $field . "<=" . $value;
	47	+ break;
48	48
49		- case Relation::NOT_EQUAL:
50		- $result = $field . "!=" . $value;
51		- break;
	49	+ case Relation::NOT_EQUAL:
	50	+ $result = $field . "!=" . $value;
	51	+ break;
52	52
53		- case Relation::STARTS_WITH:
54		- $result = " starts-with($field, $value) ";
55		- break;
	53	+ case Relation::STARTS_WITH:
	54	+ $result = " starts-with($field, $value) ";
	55	+ break;
56	56
57		- case Relation::CONTAINS:
58		- $result = " contains($field, $value) ";
59		- break;
	57	+ case Relation::CONTAINS:
	58	+ $result = " contains($field, $value) ";
	59	+ break;
60	60
61	61	}
62	62	return $result;

		@@ -23,27 +23,27 @@
		block discarded – undo
23	23
24	24	$lastError = json_last_error();
25	25	switch ($lastError) {
26		- case JSON_ERROR_NONE:
27		- $lastErrorDesc = 'No errors';
28		- break;
29		- case JSON_ERROR_DEPTH:
30		- $lastErrorDesc = 'Maximum stack depth exceeded';
31		- break;
32		- case JSON_ERROR_STATE_MISMATCH:
33		- $lastErrorDesc = 'Underflow or the modes mismatch';
34		- break;
35		- case JSON_ERROR_CTRL_CHAR:
36		- $lastErrorDesc = 'Unexpected control character found';
37		- break;
38		- case JSON_ERROR_SYNTAX:
39		- $lastErrorDesc = 'Syntax error, malformed JSON';
40		- break;
41		- case JSON_ERROR_UTF8:
42		- $lastErrorDesc = 'Malformed UTF-8 characters, possibly incorrectly encoded';
43		- break;
44		- default:
45		- $lastErrorDesc = 'Unknown error';
46		- break;
	26	+ case JSON_ERROR_NONE:
	27	+ $lastErrorDesc = 'No errors';
	28	+ break;
	29	+ case JSON_ERROR_DEPTH:
	30	+ $lastErrorDesc = 'Maximum stack depth exceeded';
	31	+ break;
	32	+ case JSON_ERROR_STATE_MISMATCH:
	33	+ $lastErrorDesc = 'Underflow or the modes mismatch';
	34	+ break;
	35	+ case JSON_ERROR_CTRL_CHAR:
	36	+ $lastErrorDesc = 'Unexpected control character found';
	37	+ break;
	38	+ case JSON_ERROR_SYNTAX:
	39	+ $lastErrorDesc = 'Syntax error, malformed JSON';
	40	+ break;
	41	+ case JSON_ERROR_UTF8:
	42	+ $lastErrorDesc = 'Malformed UTF-8 characters, possibly incorrectly encoded';
	43	+ break;
	44	+ default:
	45	+ $lastErrorDesc = 'Unknown error';
	46	+ break;
47	47	}
48	48
49	49	if ($lastError != JSON_ERROR_NONE) {

byjg / anydataset

Pull Request — master (#2)

Status

Category

Switch Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

Switch Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch