ByJG\AnyDataset\Dataset\SqlRelayIterator

Complexity

Total Complexity

15

Size/Duplication

Total Lines	109
Duplicated Lines	9.17 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	count()	0	4	1
C	hasNext()	0	45	8
A	__destruct()	0	7	2
A	moveNext()	10	10	2
A	key()	0	4	1

<?php

namespace ByJG\AnyDataset\Dataset;

use ByJG\AnyDataset\Exception\IteratorException;

class SqlRelayIterator extends GenericIterator
{

    const RECORD_BUFFER = 50;

    private $rowBuffer;
    protected $currentRow = 0;
    protected $moveNextRow = 0;

    /**
     * @var resource
     */
    private $cursor;

    /**
     *
     * @param resource $cursor
     */
    public function __construct($cursor)
    {
        $this->cursor = $cursor;
        $this->rowBuffer = array();
    }

    /**
     * @return int
     */
    public function count()
    {
        return sqlrcur_rowCount($this->cursor);
    }

    /**
     * @return bool
     */
    public function hasNext()
    {
        if (count($this->rowBuffer) >= SqlRelayIterator::RECORD_BUFFER) {
            return true;
        }

        if (is_null($this->cursor)) {
            return (count($this->rowBuffer) > 0);
        }

        if ($this->currentRow < $this->count()) {
            $sr = new Row();

            $colCount = sqlrcur_colCount($this->cursor);
            for ($col = 0; $col < $colCount; $col++) {
                $fieldName = strtolower(sqlrcur_getColumnName($this->cursor, $col));
                $value = sqlrcur_getField($this->cursor, $this->currentRow, $col);

                if (is_null($value)) {
                    $sr->addField($fieldName, "");
                } elseif (is_object($value)) {
                    $sr->addField($fieldName, "[OBJECT]");
                } else {
                    $value = AnyDataset::fixUTF8($value);
                    $sr->addField($fieldName, $value);

It seems like $value defined by \ByJG\AnyDataset\Dataset\AnyDataset::fixUTF8($value) on line 65 can also be of type array; however, ByJG\AnyDataset\Dataset\Row::addField() does only seem to accept string, maybe add an additional type check?

                }
            }

            $this->currentRow++;

            // Enfileira o registo
            array_push($this->rowBuffer, $sr);
            // Traz novos até encher o Buffer
            if (count($this->rowBuffer) < DbIterator::RECORD_BUFFER) {
                $this->hasNext();
            }

            return true;
        }

        sqlrcur_free($this->cursor);
        $this->cursor = null;

        return (count($this->rowBuffer) > 0);
    }

    public function __destruct()
    {
        if (!is_null($this->cursor)) {
            @sqlrcur_free($this->cursor);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $this->cursor = null;
        }
    }

    /**
     * @return Row
     * @throws IteratorException
     */
    public function moveNext()

This method seems to be duplicated in your project.

    {
        if (!$this->hasNext()) {
            throw new IteratorException("No more records. Did you used hasNext() before moveNext()?");
        }

        $sr = array_shift($this->rowBuffer);
        $this->moveNextRow++;
        return $sr;
    }

    public function key()
    {
        return $this->moveNextRow;
    }
}