byjg / anydataset

src/Repository/ArrayDataset.php

<?php

namespace ByJG\AnyDataset\Repository;

use UnexpectedValueException;

class ArrayDataset
{

    /**
     * @var array
     */
    protected $_array;

    /**
     * Constructor Method
     *
     * @param array $array
     * @param string $fieldName
     */
    public function __construct($array, $fieldName = "value")
    {

        $this->_array = array();

        if (!$array) return;

The expression $array of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

        if (is_array($array)) {
            foreach ($array as $key => $value) {
                if (is_array($value)) {
                    $this->_array[$key] = $value;
                } elseif (!is_object($value)) {
                    $this->_array[$key] = array($fieldName => $value);
                } else {
                    $result = array("__class" => get_class($value));
                    $methods = get_class_methods($value);
                    foreach ($methods as $method) {
                        if (strpos($method, "get") === 0) {
                            $result[substr($method, 3)] = $value->{$method}();
                        }
                    }
                    $this->_array[$key] = $result;
                    $props = get_object_vars($value);
                    $this->_array[$key] += $props;
                }
            }
        } else {
            throw new UnexpectedValueException("You need to pass an array");
        }
    }

    /**
     * Return a IteratorInterface
     *
     * @return IteratorInterface
     */
    public function getIterator()
    {
        return new ArrayDatasetIterator($this->_array);
    }
}