Passed
Branch master (d51fdb)
by Joao
05:45 queued 02:33
created

IteratorFilterSqlFormatter   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 81
Duplicated Lines 9.88 %

Coupling/Cohesion

Components 0
Dependencies 2

Test Coverage

Coverage 90.38%

Importance

Changes 0
Metric Value
wmc 5
lcom 0
cbo 2
dl 8
loc 81
ccs 47
cts 52
cp 0.9038
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A format() 0 21 2
A getRelation() 8 56 3

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace ByJG\AnyDataset\Dataset;
4
5
use ByJG\AnyDataset\Enum\Relation;
6
use ByJG\AnyDataset\Store\Helpers\SqlHelper;
7
8
class IteratorFilterSqlFormatter extends IteratorFilterFormatter
9
{
10 4
    public function format($filters, $tableName = null, &$params = [], $returnFields = "*")
11
    {
12 4
        $params = array();
13
14 4
        $sql = "select @@returnFields from @@tableName ";
15 4
        $sqlFilter = $this->getFilter($filters, $params);
16 4
        if ($sqlFilter != "") {
17 4
            $sql .= " where @@sqlFilter ";
18
        }
19
20 4
        $sql = SqlHelper::createSafeSQL(
21 4
            $sql,
22
            [
23 4
                "@@returnFields" => $returnFields,
24 4
                "@@tableName" => $tableName,
25 4
                "@@sqlFilter" => $sqlFilter
26
            ]
27
        );
28
29 4
        return $sql;
30
    }
31
32 4
    public function getRelation($name, $relation, $value, &$param)
33
    {
34 4
        $paramName = $name;
35 4
        $counter = 0;
36 4
        while (array_key_exists($paramName, $param)) {
37
            $paramName = $name . ($counter++);
38
        }
39
40 4
        $paramStr = function (&$param, $paramName, $value) {
41 4
            $param[$paramName] = trim($value);
42 4
            $result = "[[$paramName]]";
43 4
            if (is_object($value)) {
44 1
                unset($param[$paramName]);
45 1
                $result = $value->__toString();
46
            }
47 4
            return $result;
48 4
        };
49
50
        $data = [
51 4
            Relation::EQUAL => function (&$param, $name, $paramName, $value) use ($paramStr) {
52 3
                return " $name = " . $paramStr($param, $paramName, $value) . ' ';
53 4
            },
54
55 4
            Relation::GREATER_THAN => function (&$param, $name, $paramName, $value) use ($paramStr) {
56 1
                return " $name > " . $paramStr($param, $paramName, $value) . ' ';
57 4
            },
58
59 4
            Relation::LESS_THAN => function (&$param, $name, $paramName, $value) use ($paramStr) {
60 1
                return " $name < " . $paramStr($param, $paramName, $value) . ' ';
61 4
            },
62
63 4
            Relation::GREATER_OR_EQUAL_THAN => function (&$param, $name, $paramName, $value) use ($paramStr) {
64 1
                return " $name >= " . $paramStr($param, $paramName, $value) . ' ';
65 4
            },
66
67 4
            Relation::LESS_OR_EQUAL_THAN => function (&$param, $name, $paramName, $value) use ($paramStr) {
68
                return " $name <= " . $paramStr($param, $paramName, $value) . ' ';
69 4
            },
70
71 4
            Relation::NOT_EQUAL => function (&$param, $name, $paramName, $value) use ($paramStr) {
72
                return " $name <> " . $paramStr($param, $paramName, $value) . ' ';
73 4
            },
74
75 4 View Code Duplication
            Relation::STARTS_WITH => function (&$param, $name, $paramName, $value) use ($paramStr) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
76
                $value .= "%";
77
                return " $name  like  " . $paramStr($param, $paramName, $value) . ' ';
78 4
            },
79
80 4 View Code Duplication
            Relation::CONTAINS => function (&$param, $name, $paramName, $value) use ($paramStr) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
81 1
                $value = "%" . $value . "%";
82 1
                return " $name  like  " . $paramStr($param, $paramName, $value) . ' ';
83 4
            }
84
        ];
85
86 4
        return $data[$relation]($param, $name, $paramName, $value);
87
    }
88
}
89