ExchangeRate::createFromXML() - Code Metrics - Inspection of "Fix CachedExchangeRateProvider, cahcnge and add st..." - by25/NbrbExchangeRatesBundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( ac8464...9588f8 )

by Andrey

created 2016-07-01 12:48 UTC

ExchangeRate::createFromXML() A

↳ Parent: ExchangeRate

Complexity

Conditions	2
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	1

Metric	Value
c	1
b	1
f	1
dl	0
loc	12
rs	9.4285
cc	2
eloc	9
nc	1
nop	2

<?php
/**
 * (c) itmedia.by <[email protected]>
 */

namespace Submarine\NbrbExchangeRatesBundle;

/**
 * Курс обмена
 * Class ExchangeRate
 * @package Submarine\NbrbParserBundle
 */
class ExchangeRate
{

    /**
     * Внутренний код валюты
     * @var int
     */
    private $id;

    /**
     * цифровой код
     * @var int
     */
    private $numCode;

    /**
     * буквенный код
     * @var string
     */
    private $charCode;

    /**
     * номинал
     * @var int
     */
    private $scale;

    /**
     * наименование валюты
     * @var string
     */
    private $name;

    /**
     * курс
     * @var float
     */
    private $rate;

    /**
     * @var \DateTime
     */
    private $date;

    /**
     * ExchangeRate constructor.
     * @param int $id
     * @param int $numCode
     * @param string $charCode
     * @param int $scale
     * @param string $name
     * @param float $rate
     * @param \DateTime $date
     */
    public function __construct($id, $numCode, $charCode, $scale, $name, $rate, \DateTime $date)
    {
        $this->id = $id;
        $this->numCode = $numCode;
        $this->charCode = $charCode;
        $this->scale = $scale;
        $this->name = $name;
        $this->rate = $rate;
        $this->date = $date;
    }


    static public function createFromXML(\SimpleXMLElement $xmlElement = null, \DateTime $date)

    {
        return new ExchangeRate(
            (int)$xmlElement->attributes()[0],
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
            (int)$xmlElement->NumCode,
            (string)$xmlElement->CharCode,
            (int)$xmlElement->Scale,
            (string)($xmlElement->Name ?: $xmlElement->QuotName),
            (float)$xmlElement->Rate,
            $date
        );
    }


    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return int
     */
    public function getNumCode()
    {
        return $this->numCode;
    }


    /**
     * @return string
     */
    public function getCharCode()
    {
        return $this->charCode;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return float
     */
    public function getRate()
    {
        return $this->rate;
    }

    /**
     * @return int
     */
    public function getScale()
    {
        return $this->scale;
    }

    /**
     * @return \DateTime
     */
    public function getDate()
    {
        return $this->date;
    }


}

1			<?php
2			/**
3			* (c) itmedia.by <[email protected]>
4			*/
5
6			namespace Submarine\NbrbExchangeRatesBundle;
7
8			/**
9			* Курс обмена
10			* Class ExchangeRate
11			* @package Submarine\NbrbParserBundle
12			*/
13			class ExchangeRate
14			{
15
16			/**
17			* Внутренний код валюты
18			* @var int
19			*/
20			private $id;
21
22			/**
23			* цифровой код
24			* @var int
25			*/
26			private $numCode;
27
28			/**
29			* буквенный код
30			* @var string
31			*/
32			private $charCode;
33
34			/**
35			* номинал
36			* @var int
37			*/
38			private $scale;
39
40			/**
41			* наименование валюты
42			* @var string
43			*/
44			private $name;
45
46			/**
47			* курс
48			* @var float
49			*/
50			private $rate;
51
52			/**
53			* @var \DateTime
54			*/
55			private $date;
56
57			/**
58			* ExchangeRate constructor.
59			* @param int $id
60			* @param int $numCode
61			* @param string $charCode
62			* @param int $scale
63			* @param string $name
64			* @param float $rate
65			* @param \DateTime $date
66			*/
67			public function __construct($id, $numCode, $charCode, $scale, $name, $rate, \DateTime $date)
68			{
69			$this->id = $id;
70			$this->numCode = $numCode;
71			$this->charCode = $charCode;
72			$this->scale = $scale;
73			$this->name = $name;
74			$this->rate = $rate;
75			$this->date = $date;
76			}
77
78
79			static public function createFromXML(\SimpleXMLElement $xmlElement = null, \DateTime $date)
			0 ignored issues – show Coding Style introduced 2016-07-01 12:52 UTC by Report Bug Copy Issue Report As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
80			{
81			return new ExchangeRate(
82			(int)$xmlElement->attributes()[0],
			0 ignored issues – show Bug introduced 2016-07-01 12:52 UTC by Report Bug Copy Issue Report It seems like `$xmlElement` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
83			(int)$xmlElement->NumCode,
84			(string)$xmlElement->CharCode,
85			(int)$xmlElement->Scale,
86			(string)($xmlElement->Name ?: $xmlElement->QuotName),
87			(float)$xmlElement->Rate,
88			$date
89			);
90			}
91
92
93			/**
94			* @return int
95			*/
96			public function getId()
97			{
98			return $this->id;
99			}
100
101			/**
102			* @return int
103			*/
104			public function getNumCode()
105			{
106			return $this->numCode;
107			}
108
109
110			/**
111			* @return string
112			*/
113			public function getCharCode()
114			{
115			return $this->charCode;
116			}
117
118			/**
119			* @return string
120			*/
121			public function getName()
122			{
123			return $this->name;
124			}
125
126			/**
127			* @return float
128			*/
129			public function getRate()
130			{
131			return $this->rate;
132			}
133
134			/**
135			* @return int
136			*/
137			public function getScale()
138			{
139			return $this->scale;
140			}
141
142			/**
143			* @return \DateTime
144			*/
145			public function getDate()
146			{
147			return $this->date;
148			}
149
150
151			}

by25 / NbrbExchangeRatesBundle

Push — master ( ac8464...9588f8 )

ExchangeRate::createFromXML() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like