PackageItemFactory::create() - Code Metrics - Inspection of "Refactor how we connect to concrete5" - buttress/c5console - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7381e1...0d723c )

by Korvin

created 2017-04-12 17:42 UTC

PackageItemFactory::create() A

↳ Parent: PackageItemFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	3

<?php

namespace Buttress\Concrete\Service\Package;

use Package as LegacyPackage;

class PackageItemFactory
{

    /**
     * Get a package item from a modern package object
     *
     * @param \Concrete\Core\Package\Package $package
     * @return \Buttress\Concrete\Service\Package\PackageItem
     */
    public function fromModern($package)
    {
        if ($package instanceof \Concrete\Core\Entity\Package) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $installed = true;
        } else {
            $installed = false;
            if (is_array($errors = $package->testForInstall(true))) {
                $installed = in_array($package::E_PACKAGE_INSTALLED, $errors, true);
            }
        }

        return (new PackageItem())
            ->setHandle($package->getPackageHandle())
            ->setVersion($package->getPackageVersion())
            ->setInstalled($errors ? false : $installed)
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            ->setInstalledVersion($package->getPackageVersion());
    }

    /**
     * Get a package item from a legacy package object
     * @param \Package $package
     * @return \Buttress\Concrete\Service\Package\PackageItem
     */
    public function fromLegacy(LegacyPackage $package)
    {
        return (new PackageItem())
            ->setHandle($package->getPackageHandle())
            ->setVersion($package->getPackageVersion())
            ->setInstalled($package->isPackageInstalled())
            ->setInstalledVersion($package->getPackageCurrentlyInstalledVersion());
    }

    /**
     * Create from raw values
     *
     * @param string $handle
     * @param string $version
     * @param bool $installed
     * @return \Buttress\Concrete\Service\Package\PackageItem
     */
    public function create($handle, $version, $installed)
    {
        return (new PackageItem())->setHandle($handle)->setVersion($version)->setInstalled($installed);
    }

}


Push — master ( 7381e1...0d723c )

PackageItemFactory::create() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Available Fixes

1			<?php
2
3			namespace Buttress\Concrete\Service\Package;
4
5			use Package as LegacyPackage;
6
7			class PackageItemFactory
8			{
9
10			/**
11			* Get a package item from a modern package object
12			*
13			* @param \Concrete\Core\Package\Package $package
14			* @return \Buttress\Concrete\Service\Package\PackageItem
15			*/
16			public function fromModern($package)
17			{
18			if ($package instanceof \Concrete\Core\Entity\Package) {
			0 ignored issues – show Bug introduced 2017-04-12 17:44 UTC by Report Bug Copy Issue Report The class `Concrete\Core\Entity\Package` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
19			$installed = true;
20			} else {
21			$installed = false;
22			if (is_array($errors = $package->testForInstall(true))) {
23			$installed = in_array($package::E_PACKAGE_INSTALLED, $errors, true);
24			}
25			}
26
27			return (new PackageItem())
28			->setHandle($package->getPackageHandle())
29			->setVersion($package->getPackageVersion())
30			->setInstalled($errors ? false : $installed)
			0 ignored issues – show Bug introduced 2017-04-12 17:44 UTC by Report Bug Copy Issue Report The variable `$errors` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
31			->setInstalledVersion($package->getPackageVersion());
32			}
33
34			/**
35			* Get a package item from a legacy package object
36			* @param \Package $package
37			* @return \Buttress\Concrete\Service\Package\PackageItem
38			*/
39			public function fromLegacy(LegacyPackage $package)
40			{
41			return (new PackageItem())
42			->setHandle($package->getPackageHandle())
43			->setVersion($package->getPackageVersion())
44			->setInstalled($package->isPackageInstalled())
45			->setInstalledVersion($package->getPackageCurrentlyInstalledVersion());
46			}
47
48			/**
49			* Create from raw values
50			*
51			* @param string $handle
52			* @param string $version
53			* @param bool $installed
54			* @return \Buttress\Concrete\Service\Package\PackageItem
55			*/
56			public function create($handle, $version, $installed)
57			{
58			return (new PackageItem())->setHandle($handle)->setVersion($version)->setInstalled($installed);
59			}
60
61			}
62

buttress / c5console

Push — master ( 7381e1...0d723c )

PackageItemFactory::create() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Available Fixes

Duplication Side-by-Side

Filter issues like