Buttress\Concrete\CommandBus\Handler\PackageHandler

Complexity

Total Complexity

10

Size/Duplication

Total Lines	58
Duplicated Lines	27.59 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handleInstall()	8	8	2
A	handleUninstall()	8	8	2
A	handleListPackages()	0	13	3
A	listPackage()	0	14	2

<?php

namespace Buttress\Concrete\CommandBus\Handler;

use Buttress\Concrete\Service\Package\Package;
use Buttress\Concrete\Service\Package\PackageItem;
use Buttress\Concrete\CommandBus\Command\Package\Install;
use Buttress\Concrete\CommandBus\Command\Package\ListPackages;
use Buttress\Concrete\CommandBus\Command\Package\Uninstall;
use Buttress\Concrete\Exception\RuntimeException;

class PackageHandler
{

    /** @var \Buttress\Concrete\Service\Package\Package */
    private $package;

    public function __construct(Package $package)
    {
        $this->package = $package;
    }

    public function handleInstall(Install $command)

This method seems to be duplicated in your project.

    {
        $result = $this->package->install((new PackageItem())->setHandle($command->getHandle()));
        if (!$result->success()) {
            $errors = $result->getErrors();
            throw new RuntimeException(reset($errors));
        }
    }

    public function handleUninstall(Uninstall $command)

This method seems to be duplicated in your project.

    {
        $result = $this->package->uninstall((new PackageItem())->setHandle($command->getHandle()));
        if (!$result->success()) {
            $errors = $result->getErrors();
            throw new RuntimeException(reset($errors));
        }
    }

    public function handleListPackages(ListPackages $command)
    {
        $packages = iterator_to_array($this->package->all());
        usort($packages, function(PackageItem $a, PackageItem $b) {

The parameter $b is not used and could be removed.

            return $a->isInstalled() ? 1 : -1;
        });

        if ($table = array_map([$this, 'listPackage'], $packages)) {
            $command->getCli()->table($table);
        } else {
            $command->getCli()->out('No packages found.');
        }
    }

    private function listPackage(PackageItem $item)
    {
        if ($item->isInstalled()) {
            $installed = sprintf('<green>%s</green>', $item->getInstalledVersion());
        } else {
            $installed = '<yellow>No</yellow>';
        }

        return [
            'Package Handle' => $item->getHandle(),
            'Version' => $item->getVersion(),
            'Installed' => $installed,
        ];
    }
}