AdminController::countLinks() - Code Metrics - Inspection of "Added File Links Admin" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev5 ( 16c2ad...90e844 )

by Ron

created 2019-03-29 04:32 UTC

AdminController::countLinks() A

↳ Parent: AdminController

Complexity

Conditions	3
Paths	2

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	13
nc	2
nop	0
dl	0
loc	24
rs	9.8333
c	0
b	0
f	0

<?php

namespace App\Http\Controllers\Admin;

use App\User;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;

class AdminController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }
    
    //  Admin landing page
    public function index()
    {
        return view('admin.index');
    }
    
    //  Display all file links
    public function userLinks()
    {
        return view('admin.userLinks');
    }
    
    //  Get the number of links for each user
    public function countLinks()
    {
        $userLinks = User::with('FileLinks')->get();
        $linkCount = [];
        
        foreach($userLinks as $user)
        {
            $expired = $user->FileLinks->filter(function($lnk)

                       {
                           if($lnk->expire < date('Y-m-d'))
                           {
                               return $lnk;
                           }
                       })->count();

            $linkCount[] = [
                'user_id' => $user->user_id,
                'name'    => $user->first_name.' '.$user->last_name,
                'total'   => $user->FileLinks->count(),
                'expired' => $expired
            ];
        }
        
        return response()->json($linkCount);
    }
    
    //  Show the links for the selected user
    public function showLinks($id)
    {
        $user     = User::find($id);
        $userName = $user->first_name.' '.$user->last_name;
        
        return view('admin.linkDetails', [
            'userID' => $id,
            'name'   => $userName
        ]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Admin;
4
5			use App\User;
6			use Illuminate\Http\Request;
7			use App\Http\Controllers\Controller;
8
9			class AdminController extends Controller
10			{
11			public function __construct()
12			{
13			$this->middleware('auth');
14			}
15
16			// Admin landing page
17			public function index()
18			{
19			return view('admin.index');
20			}
21
22			// Display all file links
23			public function userLinks()
24			{
25			return view('admin.userLinks');
26			}
27
28			// Get the number of links for each user
29			public function countLinks()
30			{
31			$userLinks = User::with('FileLinks')->get();
32			$linkCount = [];
33
34			foreach($userLinks as $user)
35			{
36			$expired = $user->FileLinks->filter(function($lnk)
			0 ignored issues – show Bug introduced 2019-03-28 04:20 UTC by Report Bug Copy Issue Report The property `FileLinks` does not exist on `App\User`. Did you mean `fileLinks`? Loading history...
37			{
38			if($lnk->expire < date('Y-m-d'))
39			{
40			return $lnk;
41			}
42			})->count();
43
44			$linkCount[] = [
45			'user_id' => $user->user_id,
46			'name' => $user->first_name.' '.$user->last_name,
47			'total' => $user->FileLinks->count(),
48			'expired' => $expired
49			];
50			}
51
52			return response()->json($linkCount);
53			}
54
55			// Show the links for the selected user
56			public function showLinks($id)
57			{
58			$user = User::find($id);
59			$userName = $user->first_name.' '.$user->last_name;
60
61			return view('admin.linkDetails', [
62			'userID' => $id,
63			'name' => $userName
64			]);
65			}
66			}
67

butcherman / Tech_Bench

Push — dev5 ( 16c2ad...90e844 )

AdminController::countLinks() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like