SystemFilesController::store() - Code Metrics - Inspection of "Dev4" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#67)

by Ron
created 2019-04-16 04:46 UTC
SystemFilesController::store() A

↳ Parent: SystemFilesController
Complexity

Conditions	3
Paths	3
Size

Total Lines	55
Code Lines	29
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	3
eloc	29
nc	3
nop	1
dl	0
loc	55
rs	9.456
c	0
b	0
f	0
How to fix Long Method

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Log;
use App\Files;
use App\SystemTypes;
use App\SystemFiles;
use App\SystemFileTypes;

use Pion\Laravel\ChunkUpload\Exceptions\UploadMissingFileException;
use Pion\Laravel\ChunkUpload\Handler\AbstractHandler;
use Pion\Laravel\ChunkUpload\Handler\HandlerFactory;
use Pion\Laravel\ChunkUpload\Receiver\FileReceiver;
use Illuminate\Http\UploadedFile;

class SystemFilesController extends Controller
{
    //  Only authorized users have access
    public function __construct()
    {
        $this->middleware('auth');
    }
    
    public function index()
    {
        return view('system.form.newFile');
    }
    
    //  Ajax load to load the file for the system
    public function loadFiles($sysName, $fileType)
    {
        $fileList = SystemFiles::whereHas('SystemTypes', function($q) use($sysName)
        {
            $q->where('name', urldecode($sysName));
        })->whereHas('SystemFileTypes', function($q) use($fileType)
        {
            $q->where('description', urldecode($fileType));          
        })->with('user')->with('files')->get();
        
        return view('system.fileList', [
            'fileList' => $fileList
        ]);
    }

    //  Form to create a new system file
    public function create()
    {
        return view('system.form.newFile');
    }

    //  Store the new system file
    public function store(Request $request)
    {
        //  Validate incoming data
        $request->validate([
            'name'     => 'required',
            'file'     => 'required', 
            'fileType' => 'required', 
            'system'   => 'required'
        ]);
        
        $receiver = new FileReceiver("file", $request, HandlerFactory::classFromRequest($request));

        // check if the upload is success, throw exception or return response you need
        if ($receiver->isUploaded() === false) {
            throw new UploadMissingFileException();
        }

        // receive the file
        $save = $receiver->receive();
        // check if the upload has finished (in chunk mode it will send smaller files)
        if ($save->isFinished()) 
        {
            //  Get the folder location for the system
            $folder = SystemTypes::where('name', $request['system'])->first()->folder_location;

            //  Set file location and clean filename for duplicates
            $filePath = config('filesystems.paths.systems')
                .DIRECTORY_SEPARATOR.strtolower($request['category'])
                .DIRECTORY_SEPARATOR.$folder;

            $fileID = $this->saveFile($save->getFile(), $filePath);
            
            $typeID = SystemFileTypes::where('description', $request['fileType'])->first()->type_id;
            $sysID  = SystemTypes::where('name', $request['system'])->first()->sys_id;

            //  Attach file to system type
            SystemFiles::create(
            [
                'sys_id'      => $sysID,
                'type_id'     => $typeID,
                'file_id'     => $fileID,
                'name'        => $request['name'],
                'description' => $request['description'],
                'user_id'     => \Auth::user()->user_id
            ]);

            Log::info('File ID-'.$fileID.' Added For System ID-'.$sysID.' By User ID-'.Auth::user()->user_id);

        }
        
        $handler = $save->handler();

        return response()->json([
            "done" => $handler->getPercentageDone(),
            'status' => true
        ]);
    }
    
    public function saveFile(UploadedFile $file, $filePath)
    {
        $fileName = Files::cleanFileName($filePath, $file->getClientOriginalName());

        //  Store the file
        $file->storeAs($filePath, $fileName);

        //  Put the file in the database
        $file = Files::create(
        [
            'file_name' => $fileName,
            'file_link' => $filePath.DIRECTORY_SEPARATOR
        ]);
        
        return $file->file_id;
    }

    //  Form to show a file to edit
    public function edit($id)
    {
        $data = SystemFiles::find($id);

        return view('system.form.editFile', [
            'data' => $data
        ]);
    }

    //  Submit the edited file
    public function update(Request $request, $id)
    {
        SystemFiles::find($id)->update([
            'name'        => $request['name'],
            'description' => $request['description']
        ]);
        
        Log::info('File Information on System File ID-'.$id.' Updated by User ID-'.Auth::user()->user_id);
    }
    
    //  Load the replace file form
    public function replaceForm($id)
    {
        return view('system.form.replaceFile', [
            'fileID' => $id
        ]);
    }
    
    //  Submit the replace file form
    public function replace($id, Request $request)
    {
        $request->validate(['file' => 'required']);
        
        //  Get the original file information
        $origData = SystemFiles::find($id)->with('files')->first();
        $filePath = $origData->files->file_link;

        //  Clean the filename
        $fileName = Files::cleanFileName($filePath, $request->file->getClientOriginalName());
        
        //  Store the file
        $request->file->storeAs($filePath, $fileName);
        
        //  Put the file in the database
        $file = Files::create(
        [
            'file_name' => $fileName,
            'file_link' => $filePath.DIRECTORY_SEPARATOR
            'file_link' => /** @scrutinizer ignore-type */ $filePath.DIRECTORY_SEPARATOR
        ]);
        
        //  Get information for system files table
        $fileID = $file->file_id;
        
        SystemFiles::find($id)->update([
            'file_id' => $fileID
        ]);   
        
        Log::info('System File ID-'.$fileID.' Replaced by User ID-'.Auth::user()->user_id);
    }

    //  Remove a file from the system files table
    public function destroy($id)
    {
        //  Remove the file from SystemFiles table
        $data = SystemFiles::find($id);
        $fileID = $data->file_id;
        
        Log::info('System File ID-'.$fileID.' Deleted For System ID-'.$data->sys_id.' by User ID-'.Auth::user()->user_id);
        
        $data->delete();
        
        //  Delete from system if no longer in use
        Files::deleteFile($fileID);
    }
}

butcherman / Tech_Bench

Pull Request — master (#67)

SystemFilesController::store() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
