Passed
Pull Request — dev5 (#82)
by
unknown
08:35
created
app/Http/Controllers/Customers/CustomerContactsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
 
131 131
         //  Update the primary contact information
132 132
         $details = Customers::find($request->cust_id);
133
-        if ($details->parent_id && $request->shared == 'true')
133
+        if($details->parent_id && $request->shared == 'true')
134 134
         {
135 135
             $request->cust_id = $details->parent_id;
136 136
         }
Please login to merge, or discard this patch.
app/Http/Controllers/Customers/CustomerNotesController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
         //  Determine if the note should go to the customer, or its parent
33 33
         $details = Customers::find($request->cust_id);
34
-        if ($details->parent_id && $request->shared == 'true')
34
+        if($details->parent_id && $request->shared == 'true')
35 35
         {
36 36
             $request->cust_id = $details->parent_id;
37 37
         }
@@ -56,21 +56,21 @@  discard block
 block discarded – undo
56 56
 
57 57
         //  Determine if there is a parent site with shared notes
58 58
         $parent = Customers::find($id)->parent_id;
59
-        if ($parent)
59
+        if($parent)
60 60
         {
61 61
             $parentList = CustomerNotes::where('cust_id', $parent)->where('shared', 1)->orderBy('urgent', 'desc')->get();
62 62
 
63 63
             $notes = $notes->merge($parentList);
64 64
         }
65 65
 
66
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by ' . Auth::user()->full_name);
66
+        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
67 67
         return $notes;
68 68
     }
69 69
 
70 70
     //  Update a customer note
71 71
     public function update(Request $request, $id)
72 72
     {
73
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by ' . Auth::user()->full_name.'. Submitted Data - ', $request->toArray());
73
+        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name.'. Submitted Data - ', $request->toArray());
74 74
 
75 75
         $request->validate([
76 76
             'cust_id' => 'required',
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         ]);
80 80
 
81 81
         $details = Customers::find($request->cust_id);
82
-        if ($details->parent_id && $request->shared == 'true')
82
+        if($details->parent_id && $request->shared == 'true')
83 83
         {
84 84
             $request->cust_id = $details->parent_id;
85 85
         }
Please login to merge, or discard this patch.
app/Http/Controllers/Customers/CustomerFilesController.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,8 @@  discard block
 block discarded – undo
100 100
 
101 101
         //  Determine if there is a parent site with shared files
102 102
         $parent = Customers::find($id)->parent_id;
103
-        if($parent) {
103
+        if($parent)
104
+        {
104 105
             $parentList = Customerfiles::where('cust_id', $parent)
105 106
                 ->where('shared', 1)
106 107
                 ->with('Files')
@@ -126,7 +127,8 @@  discard block
 block discarded – undo
126 127
         ]);
127 128
 
128 129
         $details = Customers::find($request->cust_id);
129
-        if($details->parent_id && $request->shared == 1) {
130
+        if($details->parent_id && $request->shared == 1)
131
+        {
130 132
             $request->cust_id = $details->parent_id;
131 133
         }
132 134
 
Please login to merge, or discard this patch.
app/Http/Controllers/TechTips/TechTipsController.php 1 patch
Braces   +17 added lines, -8 removed lines patch added patch discarded remove patch
@@ -53,14 +53,17 @@  discard block
 block discarded – undo
53 53
         Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name.'. Submitted Data - ', $request->toArray());
54 54
 
55 55
         //  See if there are any search paramaters entered
56
-        if(!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType'])) {
56
+        if(!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType']))
57
+        {
57 58
             //  No search paramaters, send all tech tips
58 59
             $tips = new TechTipsCollection(
59 60
                 TechTips::orderBy('created_at', 'DESC')
60 61
                     ->with('SystemTypes')
61 62
                     ->paginate($request->pagination['perPage'])
62 63
             );
63
-        } else {
64
+        }
65
+        else
66
+        {
64 67
             $article = isset($request->search['articleType']) ? true : false;
65 68
             $system  = isset($request->search['systemType']) ? true : false;
66 69
             //  Search paramaters, filter results
@@ -151,7 +154,8 @@  discard block
 block discarded – undo
151 154
         $save = $receiver->receive();
152 155
 
153 156
         //  See if the uploade has finished
154
-        if($save->isFinished()) {
157
+        if($save->isFinished())
158
+        {
155 159
             $this->saveFile($save->getFile());
156 160
 
157 161
             return 'uploaded successfully';
@@ -266,7 +270,8 @@  discard block
 block discarded – undo
266 270
     //  Details controller - will move to the show controller with just the tech tip id
267 271
     public function details($id, $subject)
268 272
     {
269
-        if(session()->has('newTipFile')) {
273
+        if(session()->has('newTipFile'))
274
+        {
270 275
             session()->forget('newTipFile');
271 276
         }
272 277
 
@@ -300,7 +305,8 @@  discard block
 block discarded – undo
300 305
     {
301 306
         Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
302 307
 
303
-        switch($action) {
308
+        switch($action)
309
+        {
304 310
             case 'add':
305 311
                 TechTipFavs::create([
306 312
                     'user_id' => Auth::user()->user_id,
@@ -329,7 +335,8 @@  discard block
 block discarded – undo
329 335
         $this->authorize('hasAccess', 'Edit Tech Tip');
330 336
         $tipData = TechTips::where('tip_id', $id)->with('User')->with('SystemTypes')->with('TechTipTypes')->first();
331 337
 
332
-        if(!$tipData) {
338
+        if(!$tipData)
339
+        {
333 340
             return view('tips.tipNotFound');
334 341
         }
335 342
 
@@ -362,7 +369,8 @@  discard block
 block discarded – undo
362 369
         $receiver = new FileReceiver('file', $request, HandlerFactory::classFromRequest($request));
363 370
 
364 371
         //  Verify if there is a file to be processed or not
365
-        if($receiver->isUploaded() === false || $request->_completed) {
372
+        if($receiver->isUploaded() === false || $request->_completed)
373
+        {
366 374
             $this->storeUpdatedTip($request, $id);
367 375
             Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
368 376
             return response()->json(['tip_id' => $id]);
@@ -372,7 +380,8 @@  discard block
 block discarded – undo
372 380
         $save = $receiver->receive();
373 381
 
374 382
         //  See if the uploade has finished
375
-        if($save->isFinished()) {
383
+        if($save->isFinished())
384
+        {
376 385
             $this->saveFile($save->getFile(), $id);
377 386
 
378 387
             return 'uploaded successfully';
Please login to merge, or discard this patch.
app/Http/Controllers/Installer/ModuleController.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -41,7 +41,8 @@  discard block
 block discarded – undo
41 41
             ];
42 42
         }
43 43
         $mods = Module::allDisabled();
44
-        foreach($mods as $name => $mod) {
44
+        foreach($mods as $name => $mod)
45
+        {
45 46
             $moduleList[] = [
46 47
                 'name' => $name,
47 48
                 'status' => 'Disabled',
@@ -78,7 +79,8 @@  discard block
 block discarded – undo
78 79
         $receiver = new FileReceiver('file', $request, HandlerFactory::classFromRequest($request));
79 80
 
80 81
         //  Verify that the upload is valid and being processed
81
-        if($receiver->isUploaded() === false) {
82
+        if($receiver->isUploaded() === false)
83
+        {
82 84
             Log::error('Upload File Missing - '.
83 85
                 /** @scrutinizer ignore-type */
84 86
                 $request->toArray());
@@ -89,7 +91,8 @@  discard block
 block discarded – undo
89 91
         $save = $receiver->receive();
90 92
 
91 93
         //  See if the uploade has finished
92
-        if($save->isFinished()) {
94
+        if($save->isFinished())
95
+        {
93 96
             $this->saveFile($save->getFile());
94 97
 
95 98
             return 'uploaded successfully';
Please login to merge, or discard this patch.
app/Http/Controllers/Installer/SettingsController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         ]);
81 81
 
82 82
         //  Update the site timezone
83
-        if (config('app.timezone') !== $request->timezone)
83
+        if(config('app.timezone') !== $request->timezone)
84 84
         {
85 85
             Settings::firstOrCreate(
86 86
                 ['key'   => 'app.timezone'],
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
             )->update(['value' => $request->timezone]);
89 89
         }
90 90
         //  Update the maximum file upload size
91
-        if (config('filesystems.paths.max_size') !== $request->filesize)
91
+        if(config('filesystems.paths.max_size') !== $request->filesize)
92 92
         {
93 93
             Settings::firstOrCreate(
94 94
                 ['key'   => 'filesystems.paths.max_size'],
Please login to merge, or discard this patch.
app/Http/Controllers/Installer/SystemsController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,7 +211,8 @@
 block discarded – undo
211 211
     public function destroy($id)
212 212
     {
213 213
         //
214
-        try {
214
+        try
215
+        {
215 216
             SystemTypes::find($id)->delete();
216 217
             return response()->json(['success' => true, 'reason' => 'Equipment Successfully Deleted']);
217 218
         }
Please login to merge, or discard this patch.
app/Http/Controllers/DownloadController.php 1 patch
Braces   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -59,9 +59,12 @@  discard block
 block discarded – undo
59 59
     public function archiveFiles(Request $request)
60 60
     {
61 61
         //  Debug Data
62
-        if(Auth::user()) {
62
+        if(Auth::user())
63
+        {
63 64
             $user = Auth::user()->full_name;
64
-        } else {
65
+        }
66
+        else
67
+        {
65 68
             $user = \Request::ip();
66 69
         }
67 70
         Log::debug('Route '.Route::currentRouteName().' visited by '.$user.'  Request Data:', $request->toArray());
@@ -107,9 +110,12 @@  discard block
 block discarded – undo
107 110
     public function downloadArchive($fileName)
108 111
     {
109 112
         //  Debug Data
110
-        if(Auth::user()) {
113
+        if(Auth::user())
114
+        {
111 115
             $user = Auth::user()->full_name;
112
-        } else {
116
+        }
117
+        else
118
+        {
113 119
             $user = \Request::ip();
114 120
         }
115 121
         Log::debug('Route '.Route::currentRouteName().' visited by '.$user);
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/AdminController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         Log::notice('User '.Auth::user()->full_name.' updated User Password Policy');
90 90
 
91 91
         //  If the setting is changing from never to xx days, update all users
92
-        if ($request->passExpire == 0)
92
+        if($request->passExpire == 0)
93 93
         {
94 94
             User::whereNotNull('password_expires')->update([
95 95
                 'password_expires' => null
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     public function roleSettings()
111 111
     {
112 112
         $this->authorize('hasAccess', 'Manage User Roles');
113
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by ' . Auth::user()->full_name);
113
+        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
114 114
         $roles = UserRoleType::with(['UserRolePermissions' => function($query) {
115 115
             $query->join('user_role_permission_types', 'user_role_permission_types.perm_type_id', '=', 'user_role_permissions.perm_type_id');
116 116
         }])->get();
Please login to merge, or discard this patch.