TechTipsController::update() - Code Metrics - Inspection of "Updated Tech Tips" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — dev6 ( ab8d6f...f89a9a )

by Ron

created 2021-10-16 19:19 UTC

TechTipsController::update() B

↳ Parent: TechTipsController

Complexity

Conditions	8
Paths	48

Size

Total Lines	73
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
eloc	35
c	3
b	0
f	0
dl	0
loc	73
rs	8.1155
cc	8
nc	48
nop	2

How to fix Long Method

<?php

namespace App\Http\Controllers\TechTips;

use Inertia\Inertia;
use Illuminate\Support\Str;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use App\Http\Controllers\Controller;

use App\Traits\FileTrait;

use App\Models\TechTip;
use App\Models\TechTipType;
use App\Models\TechTipFile;
use App\Models\TechTipEquipment;
use App\Models\EquipmentCategory;
use App\Models\UserTechTipBookmark;

use App\Events\TechTips\TechTipCreatedEvent;
use App\Events\TechTips\TechTipDeletedEvent;
use App\Events\TechTips\TechTipUpdatedEvent;
use App\Http\Requests\TechTips\CreateTipRequest;
use App\Http\Requests\TechTips\UpdateTipRequest;

class TechTipsController extends Controller
{
    use FileTrait;


    /**
     * Tech Tips search page
     */
    public function index(Request $request)
    {
        $filterData = [
            'tip_types'   => TechTipType::all(),
            'equip_types' => EquipmentCategory::with('EquipmentType')->get(),
        ];

        return Inertia::render('TechTips/Index', [
            'filter_data' => $filterData,
            'create'      => $request->user()->can('create', TechTip::class),
        ]);
    }

    /**
     * Show the form for creating a new Tech Tip
     */
    public function create()
    {
        $this->authorize('create', TechTip::class);

        return Inertia::render('TechTips/Create', [
            'tip_types' => TechTipType::all(),
            'equipment' => EquipmentCategory::with('EquipmentType')->get(),
        ]);
    }

    /**
     * Store a newly created Tech Tip
     */
    public function store(CreateTipRequest $request)
    {
        //  Create the new Tip
        $newTip = TechTip::create([
            'user_id'     => $request->user()->user_id,
            'tip_type_id' => $request->tip_type_id,
            'sticky'      => $request->sticky,
            'subject'     => $request->subject,
            'slug'        => Str::slug($request->subject),
            'details'     => $request->details,
        ]);

        //  Add the equipment for this Tech Tip
        foreach($request->equipment as $equip)
        {
            TechTipEquipment::create([
                'tip_id'   => $newTip->tip_id,
                'equip_id' => $equip['equip_id'],
            ]);
        }

        //  If any files were included, move them to the proper folder and attach to tip
        $fileData = $request->session()->pull('new-file-upload');
        if($fileData)
        {
            foreach($fileData as $file)
            {
                $this->moveStoredFile($file->file_id, $newTip->tip_id);
                TechTipFile::create([
                    'tip_id'  => $newTip->tip_id,
                    'file_id' => $file->file_id,
                ]);
            }
        }

        event(new TechTipCreatedEvent($newTip));
        return redirect(route('tech-tips.show', $newTip->slug));
    }

    /**
     * Display the Tech Tip
     */
    public function show($id)
    {
        //  Check if we are passing the Tech Tip name or number
        if(is_numeric($id))
        {
            //  To keep things uniform, redirect to a link that has the Tech Tip subject rather than the ID
            $tip = TechTip::findOrFail($id);
            return redirect(route('tech-tips.show', $tip->slug));
        }

        //  Pull the Tech Tip Information
        $tip = TechTip::where('slug', $id)
                ->with('EquipmentType')
                ->with('FileUploads')
                ->with('TechTipComment.User')
                ->firstOrFail()
                ->makeHidden(['summary', 'sticky']);

        //  Determine if the Tech Tip is bookmarked by the user
        $isFav = UserTechTipBookmark::where('user_id', Auth::user()->user_id)

                    ->where('tip_id', $tip->tip_id)
                    ->count();

        return Inertia::render('TechTips/Show', [
            'tip' => $tip,
            //  User Permissions for Tech Tips
            'user_data' => [
                'fav' => $isFav,
                'permissions' => [
                    'edit'      => Auth::user()->can('update', $tip),
                    'delete'    => Auth::user()->can('delete', $tip),
                    'manage'    => Auth::user()->can('manage', TechTip::class),
                    // 'comment'   => [
                    //     'create'  => Auth::user()->can('create', TechTipComment::class),
                    //     'manage'  => Auth::user()->can('manage', TechTipComment::class),
                    // ],
                ],
            ]
        ]);
    }

    /**
     * Show the form to Edit the Tech Tip
     */
    public function edit($id)
    {
        $tip = TechTip::with(['EquipmentType', 'FileUploads'])->findOrFail($id)->makeVisible(['tip_type_id']);
        $this->authorize('update', $tip);

        return Inertia::render('TechTips/Edit', [
            'data'      => $tip,
            'tip_types' => TechTipType::all(),
            'equipment' => EquipmentCategory::with('EquipmentType')->get(),
        ]);
    }

    /**
     * Update the Tech Tip
     */
    public function update(UpdateTipRequest $request, $id)
    {
        //  Update the Tech Tip
        $tip = TechTip::findOrFail($id);
        $tip->update([
            'updated_id'  => $request->user()->user_id,
            'tip_type_id' => $request->tip_type_id,
            'sticky'      => $request->sticky,
            'subject'     => $request->subject,
            'slug'        => Str::slug($request->subject),
            'details'     => $request->details,
        ]);

        //  Update the equipment attached to the Tech Tip
        $currentEquip = TechTipEquipment::where('tip_id', $id)->get();
        $newEquip     = [];

        foreach($request->equipment as $equip)
        {
            //  If the laravel_through_key value exists, then it was an existing equipment that has stayed in place
            if(isset($equip['laravel_through_key']))
            {
                //  Remove that piece from the current equipment list so it is not updated later
                $currentEquip = $currentEquip->filter(function($i) use ($equip)
                {
                    return $i->equip_id != $equip['equip_id'];
                });
            }
            else
            {
                $newEquip[] = $equip;
            }
        }

        //  Remove the Equipment left over in the CurrentEquipment array
        foreach($currentEquip as $cur)
        {
            TechTipEquipment::find($cur->tip_equip_id)->delete();
        }

        //  Add the new equipment
        foreach($newEquip as $new)
        {
            TechTipEquipment::create([
                'tip_id'   => $id,
                'equip_id' => $new['equip_id'],
            ]);
        }

        //  Remove any files that are no longer needed
        foreach($request->removedFiles as $file)
        {
            TechTipFile::where('tip_id', $tip->tip_id)->where('file_id', $file)->first()->delete();
            $this->deleteFile($file);
        }

        //  Add any additional files
        $fileData = $request->session()->pull('new-file-upload');
        if($fileData)
        {
            foreach($fileData as $file)
            {
                TechTipFile::create([
                    'tip_id'  => $tip->tip_id,
                    'file_id' => $file->file_id,
                ]);
            }
        }

        event(new TechTipUpdatedEvent($tip));
        return redirect(route('tech-tips.show', $tip->slug))->with([
            'message' => 'Tech Tip Updated',
            'type'    => 'success',
        ]);
    }

    /**
     * Soft Delete the Tech Tip
     */
    public function destroy($id)
    {
        $tip = TechTip::findOrFail($id);
        $this->authorize('delete', $tip);
        $tip->delete();

        event(new TechTipDeletedEvent($tip));
        return redirect(route('tech-tips.index'))->with([
            'message' => 'Tech Tip Deleted',
            'type'    => 'danger',
        ]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers\TechTips;
4
5			use Inertia\Inertia;
6			use Illuminate\Support\Str;
7			use Illuminate\Http\Request;
8			use Illuminate\Support\Facades\Auth;
9			use App\Http\Controllers\Controller;
10
11			use App\Traits\FileTrait;
12
13			use App\Models\TechTip;
14			use App\Models\TechTipType;
15			use App\Models\TechTipFile;
16			use App\Models\TechTipEquipment;
17			use App\Models\EquipmentCategory;
18			use App\Models\UserTechTipBookmark;
19
20			use App\Events\TechTips\TechTipCreatedEvent;
21			use App\Events\TechTips\TechTipDeletedEvent;
22			use App\Events\TechTips\TechTipUpdatedEvent;
23			use App\Http\Requests\TechTips\CreateTipRequest;
24			use App\Http\Requests\TechTips\UpdateTipRequest;
25
26			class TechTipsController extends Controller
27			{
28			use FileTrait;
			1 ignored issue – show Bug introduced 2021-10-16 19:39 UTC by Report Bug Copy Issue Report The trait `App\Traits\FileTrait` requires the property `$username` which is not provided by `App\Http\Controllers\TechTips\TechTipsController`. Loading history...
29
30			/**
31			* Tech Tips search page
32			*/
33			public function index(Request $request)
34			{
35			$filterData = [
36			'tip_types' => TechTipType::all(),
37			'equip_types' => EquipmentCategory::with('EquipmentType')->get(),
38			];
39
40			return Inertia::render('TechTips/Index', [
41			'filter_data' => $filterData,
42			'create' => $request->user()->can('create', TechTip::class),
43			]);
44			}
45
46			/**
47			* Show the form for creating a new Tech Tip
48			*/
49			public function create()
50			{
51			$this->authorize('create', TechTip::class);
52
53			return Inertia::render('TechTips/Create', [
54			'tip_types' => TechTipType::all(),
55			'equipment' => EquipmentCategory::with('EquipmentType')->get(),
56			]);
57			}
58
59			/**
60			* Store a newly created Tech Tip
61			*/
62			public function store(CreateTipRequest $request)
63			{
64			// Create the new Tip
65			$newTip = TechTip::create([
66			'user_id' => $request->user()->user_id,
67			'tip_type_id' => $request->tip_type_id,
68			'sticky' => $request->sticky,
69			'subject' => $request->subject,
70			'slug' => Str::slug($request->subject),
71			'details' => $request->details,
72			]);
73
74			// Add the equipment for this Tech Tip
75			foreach($request->equipment as $equip)
76			{
77			TechTipEquipment::create([
78			'tip_id' => $newTip->tip_id,
79			'equip_id' => $equip['equip_id'],
80			]);
81			}
82
83			// If any files were included, move them to the proper folder and attach to tip
84			$fileData = $request->session()->pull('new-file-upload');
85			if($fileData)
86			{
87			foreach($fileData as $file)
88			{
89			$this->moveStoredFile($file->file_id, $newTip->tip_id);
90			TechTipFile::create([
91			'tip_id' => $newTip->tip_id,
92			'file_id' => $file->file_id,
93			]);
94			}
95			}
96
97			event(new TechTipCreatedEvent($newTip));
98			return redirect(route('tech-tips.show', $newTip->slug));
99			}
100
101			/**
102			* Display the Tech Tip
103			*/
104			public function show($id)
105			{
106			// Check if we are passing the Tech Tip name or number
107			if(is_numeric($id))
108			{
109			// To keep things uniform, redirect to a link that has the Tech Tip subject rather than the ID
110			$tip = TechTip::findOrFail($id);
111			return redirect(route('tech-tips.show', $tip->slug));
112			}
113
114			// Pull the Tech Tip Information
115			$tip = TechTip::where('slug', $id)
116			->with('EquipmentType')
117			->with('FileUploads')
118			->with('TechTipComment.User')
119			->firstOrFail()
120			->makeHidden(['summary', 'sticky']);
121
122			// Determine if the Tech Tip is bookmarked by the user
123			$isFav = UserTechTipBookmark::where('user_id', Auth::user()->user_id)
			1 ignored issue – show Bug introduced 2021-10-16 19:39 UTC by Report Bug Copy Issue Report Accessing `user_id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
124			->where('tip_id', $tip->tip_id)
125			->count();
126
127			return Inertia::render('TechTips/Show', [
128			'tip' => $tip,
129			// User Permissions for Tech Tips
130			'user_data' => [
131			'fav' => $isFav,
132			'permissions' => [
133			'edit' => Auth::user()->can('update', $tip),
134			'delete' => Auth::user()->can('delete', $tip),
135			'manage' => Auth::user()->can('manage', TechTip::class),
136			// 'comment' => [
137			// 'create' => Auth::user()->can('create', TechTipComment::class),
138			// 'manage' => Auth::user()->can('manage', TechTipComment::class),
139			// ],
140			],
141			]
142			]);
143			}
144
145			/**
146			* Show the form to Edit the Tech Tip
147			*/
148			public function edit($id)
149			{
150			$tip = TechTip::with(['EquipmentType', 'FileUploads'])->findOrFail($id)->makeVisible(['tip_type_id']);
151			$this->authorize('update', $tip);
152
153			return Inertia::render('TechTips/Edit', [
154			'data' => $tip,
155			'tip_types' => TechTipType::all(),
156			'equipment' => EquipmentCategory::with('EquipmentType')->get(),
157			]);
158			}
159
160			/**
161			* Update the Tech Tip
162			*/
163			public function update(UpdateTipRequest $request, $id)
164			{
165			// Update the Tech Tip
166			$tip = TechTip::findOrFail($id);
167			$tip->update([
168			'updated_id' => $request->user()->user_id,
169			'tip_type_id' => $request->tip_type_id,
170			'sticky' => $request->sticky,
171			'subject' => $request->subject,
172			'slug' => Str::slug($request->subject),
173			'details' => $request->details,
174			]);
175
176			// Update the equipment attached to the Tech Tip
177			$currentEquip = TechTipEquipment::where('tip_id', $id)->get();
178			$newEquip = [];
179
180			foreach($request->equipment as $equip)
181			{
182			// If the laravel_through_key value exists, then it was an existing equipment that has stayed in place
183			if(isset($equip['laravel_through_key']))
184			{
185			// Remove that piece from the current equipment list so it is not updated later
186			$currentEquip = $currentEquip->filter(function($i) use ($equip)
187			{
188			return $i->equip_id != $equip['equip_id'];
189			});
190			}
191			else
192			{
193			$newEquip[] = $equip;
194			}
195			}
196
197			// Remove the Equipment left over in the CurrentEquipment array
198			foreach($currentEquip as $cur)
199			{
200			TechTipEquipment::find($cur->tip_equip_id)->delete();
201			}
202
203			// Add the new equipment
204			foreach($newEquip as $new)
205			{
206			TechTipEquipment::create([
207			'tip_id' => $id,
208			'equip_id' => $new['equip_id'],
209			]);
210			}
211
212			// Remove any files that are no longer needed
213			foreach($request->removedFiles as $file)
214			{
215			TechTipFile::where('tip_id', $tip->tip_id)->where('file_id', $file)->first()->delete();
216			$this->deleteFile($file);
217			}
218
219			// Add any additional files
220			$fileData = $request->session()->pull('new-file-upload');
221			if($fileData)
222			{
223			foreach($fileData as $file)
224			{
225			TechTipFile::create([
226			'tip_id' => $tip->tip_id,
227			'file_id' => $file->file_id,
228			]);
229			}
230			}
231
232			event(new TechTipUpdatedEvent($tip));
233			return redirect(route('tech-tips.show', $tip->slug))->with([
234			'message' => 'Tech Tip Updated',
235			'type' => 'success',
236			]);
237			}
238
239			/**
240			* Soft Delete the Tech Tip
241			*/
242			public function destroy($id)
243			{
244			$tip = TechTip::findOrFail($id);
245			$this->authorize('delete', $tip);
246			$tip->delete();
247
248			event(new TechTipDeletedEvent($tip));
249			return redirect(route('tech-tips.index'))->with([
250			'message' => 'Tech Tip Deleted',
251			'type' => 'danger',
252			]);
253			}
254			}
255

butcherman / Tech_Bench

Push — dev6 ( ab8d6f...f89a9a )

TechTipsController::update() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like