UserController::edit() - Code Metrics - Inspection of "Updated User Admin and DB Check" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — dev5 ( ba6069...125e24 )

by Ron

created 2020-05-13 01:37 UTC

UserController::edit() A

↳ Parent: UserController

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	7
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	12
ccs	8
cts	8
cp	1
crap	2
rs	10

<?php

namespace App\Http\Controllers\Admin;

use App\Domains\Users\UserList;
use App\Domains\Users\GetUserDetails;
use App\Domains\Users\GetUserRoles;
use App\Domains\Users\SetUserDetails;
use App\User;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;
use App\Http\Controllers\Controller;
use App\Http\Requests\AdminUserChangePasswordRequest;
use App\Http\Requests\UserBasicAccountRequest;
use App\Http\Requests\UserCreateRequest;
use Illuminate\Support\Facades\Route;
use App\Http\Resources\UserCollection;


class UserController extends Controller
{
    //  Constructor sets up middleware
    public function __construct()
    {
        $this->middleware('auth')->except('initializeUser', 'submitInitializeUser');
        $this->middleware(function($request, $next) {
            $this->authorize('hasAccess', 'Manage Users');
            return $next($request);
        });
    }

    //  Show the list of current users to edit
    public function index()
    {
        return view('admin.userIndex', [
            'userList' => (new UserList)->getActiveUsers()->toJson(),
        ]);
    }

    //  Check if a username is in use
    public function checkUser($username, $type)
    {
        $user = (new GetUserDetails)->checkForDuplicate($type, $username);

        if(!$user)
        {
            return response()->json(['duplicate' => false]);
        }

        return response()->json([
            'duplicate' => true,
            'user'      => $user->full_name,
            'username'  => $user->username,
            'active'    => $user->deleted_at == null ? 1 : 0,
        ]);
    }

    //  Show the Add User form
    public function create()
    {
        return view('admin.newUser', [
            'roles' => (new GetUserRoles)->getRoleList()->toJson(),
            'roles' => (new GetUserRoles)->getRoleList()->/** @scrutinizer ignore-call */ toJson(),
        ]);
    }

    //  Submit the Add User form
    public function store(UserCreateRequest $request)
    {
        (new SetUserDetails)->createNewUser($request);
        return response()->json(['success' => true]);
    }










    //  List all inactive users
    public function show($type)
    {
        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
        $route = '';

        if($type !== 'inactive')
        {
            Log::error('Someone tried to access the Inactive Users link with an improper argument - Argument: '.$type);
            return abort(404);
        }
        $userList = new UserCollection(User::onlyTrashed()->get()
                /** @scrutinizer ignore-call */
                ->makeVisible('user_id')
                ->makeVisible('deleted_at'));

        Log::debug('List of inactive users - ', array($userList));
        return view('admin.userDeleted', [
            'userList' => $userList,
            'route'    => $route,
        ]);
    }

    //  Reactivate a disabled user
    public function reactivateUser($id)
    {
        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
        User::withTrashed()->where('user_id', $id)->restore();

        Log::notice('User ID '.$id.' reactivated by '.Auth::user()->full_name);
        return response()->json([
            'success' => true,
        ]);
    }









    //  Open the edit user form
    public function edit($id)
    {
        $userObj = new GetUserDetails($id);
        $details = $userObj->getuserData()->makeVisible(['user_id', 'username', 'role_id']);
        if($details->role_id < Auth::user()->role_id)
        {
            abort(403, 'You cannot edit a user with more permissions than you');
        }

        return view('admin.userEdit', [
            'roles' => (new GetUserRoles)->getRoleList()->toJson(),
            'user'  => $details->toJson(),
        ]);
    }

    //  Submit the update user form
    public function update(UserBasicAccountRequest $request, $id)
    {
        $userObj = new SetUserDetails;
        $userObj->updateUserDetails($request, $id);

        return response()->json(['success' => true]);
    }

    //  Submit the change password form
    public function submitPassword(AdminUserChangePasswordRequest $request)
    {
        $userObj = new SetUserDetails;
        $userObj->updateUserPassword($request->password, $request->user_id, $request->force_change);

        return response()->json([
            'success' => true,
            'reason'  => 'Password successfully reset',
        ]);
    }

    //  Disable the user
    public function destroy($id)
    {
        $userObj = new SetUserDetails;
        $userObj->disableUser($id);

        return response()->json([
            'success' => true,
            'reason'  => 'User successfully deactivated',
        ]);
    }
}


butcherman / Tech_Bench

Push — dev5 ( ba6069...125e24 )

UserController::edit() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like