butcherman / Tech_Bench

app/Http/Controllers/Installer/SystemsController.php

Indentation +5 added lines, -5 removed lines

@@ -209,10 +209,10 @@ 
     }
 
     //  Delete an existing system - note this will fail if the system has any customers or tech tips assigned to it
-   public function destroy($id)
-   {
-       //
-       try {
+    public function destroy($id)
+    {
+        //
+        try {
             SystemTypes::find($id)->delete();
             return response()->json(['success' => true, 'reason' => 'Equipment Successfully Deleted']);
         }
@@ -220,5 +220,5 @@ 
         {
             return response()->json(['success' => false, 'reason' => 'Cannot delete this equipment.  It has Customers or Tech Tips assigned to it.  Please delete those first.']);
         }
-   }
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -18,7 +18,7 @@ 
     public function __construct()
     {
         $this->middleware('auth');
-        $this->middleware(function ($request, $next) {
+        $this->middleware(function($request, $next) {
             $this->authorize('hasAccess', 'Manage Equipment');
             return $next($request);
         });
@@ -120,7 +120,7 @@ 
         $fields = SystemDataFieldTypes::all();
         $cat = SystemCategories::where('name', str_replace('-', ' ', $cat))->first();
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         return view('installer.newSystem', [
             'cat'      => $cat,
             'dataList' => $fields,
@@ -136,7 +136,7 @@ 
             $query->join('system_data_field_types', 'system_data_fields.data_type_id', '=', 'system_data_field_types.data_type_id');
         }])->withCount('SystemDataFields')->first();
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         return view('installer.editSystem', [
             'system'   => $system,
             'dataList' => $fields,
@@ -216,7 +216,7 @@ 
             SystemTypes::find($id)->delete();
             return response()->json(['success' => true, 'reason' => 'Equipment Successfully Deleted']);
         }
-        catch (\Illuminate\Database\QueryException $e)
+        catch(\Illuminate\Database\QueryException $e)
         {
             return response()->json(['success' => false, 'reason' => 'Cannot delete this equipment.  It has Customers or Tech Tips assigned to it.  Please delete those first.']);
         }

Braces +3 added lines, -3 removed lines

@@ -131,8 +131,7 @@ 
     public function edit($id)
     {
         $fields = SystemDataFieldTypes::all();
-        $system = SystemTypes::where('sys_id', $id)->with(['SystemDataFields' => function($query)
-        {
+        $system = SystemTypes::where('sys_id', $id)->with(['SystemDataFields' => function($query) {
             $query->join('system_data_field_types', 'system_data_fields.data_type_id', '=', 'system_data_field_types.data_type_id');
         }])->withCount('SystemDataFields')->first();
 
@@ -212,7 +211,8 @@ 
    public function destroy($id)
    {
        //
-       try {
+       try
+       {
             SystemTypes::find($id)->delete();
             return response()->json(['success' => true, 'reason' => 'Equipment Successfully Deleted']);
         }

app/Http/Controllers/Installer/SettingsController.php

Spacing +7 added lines, -7 removed lines

@@ -39,14 +39,14 @@ 
 
         Settings::firstOrCreate(
             ['key'   => 'app.logo'],
-            ['key'   => 'app.logo', 'value' => '/storage/img/' . $fileName]
-        )->update(['value' => '/storage/img/' . $fileName]);
+            ['key'   => 'app.logo', 'value' => '/storage/img/'.$fileName]
+        )->update(['value' => '/storage/img/'.$fileName]);
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         Log::debug('Submitted Data - ', $request->toArray());
-        Log::notice('A new company logo has been uploaded by User ID-' . Auth::user()->user_id);
+        Log::notice('A new company logo has been uploaded by User ID-'.Auth::user()->user_id);
 
-        return response()->json(['url' => '/storage/img/' . $fileName]);
+        return response()->json(['url' => '/storage/img/'.$fileName]);
     }
 
     public function configuration()
@@ -81,14 +81,14 @@ 
             )->update(['value' => $request->url]);
         }
         //  Update the site timezone
-        if (config('app.timezone') !== $request->timezone) {
+        if(config('app.timezone') !== $request->timezone) {
             Settings::firstOrCreate(
                 ['key'   => 'app.timezone'],
                 ['key'   => 'app.timezone', 'value' => $request->timezone]
             )->update(['value' => $request->timezone]);
         }
         //  Update the maximum file upload size
-        if (config('filesystems.paths.max_size') !== $request->filesize) {
+        if(config('filesystems.paths.max_size') !== $request->filesize) {
             Settings::firstOrCreate(
                 ['key'   => 'filesystems.paths.max_size'],
                 ['key'   => 'filesystems.paths.max_size', 'value' => $request->filesize]

Braces +4 added lines, -2 removed lines

@@ -81,14 +81,16 @@
             )->update(['value' => $request->url]);
         }
         //  Update the site timezone
-        if (config('app.timezone') !== $request->timezone) {
+        if (config('app.timezone') !== $request->timezone)
+        {
             Settings::firstOrCreate(
                 ['key'   => 'app.timezone'],
                 ['key'   => 'app.timezone', 'value' => $request->timezone]
             )->update(['value' => $request->timezone]);
         }
         //  Update the maximum file upload size
-        if (config('filesystems.paths.max_size') !== $request->filesize) {
+        if (config('filesystems.paths.max_size') !== $request->filesize)
+        {
             Settings::firstOrCreate(
                 ['key'   => 'filesystems.paths.max_size'],
                 ['key'   => 'filesystems.paths.max_size', 'value' => $request->filesize]

app/Http/Middleware/CheckPasswordExpire.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
             if(Auth::user()->password_expires !== null)
             {
                 $passExp = new Carbon((Auth::user()->password_expires));
-                if(Carbon::now() > $passExp )
+                if(Carbon::now() > $passExp)
                 {
                     Log::notice('User ID-'.Auth::user()->user_id.' is being forced to change their password.');
                     $request->session()->flash('change_password', 'change_password');

app/Http/Controllers/Admin/AdminController.php

Spacing +5 added lines, -5 removed lines

@@ -55,7 +55,7 @@ 
     //  Show the links for the selected user
     public function showLinks($id)
     {
-        $user     = User::find($id);
+        $user = User::find($id);
 
         Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         return view('admin.linkDetails', [
@@ -88,7 +88,7 @@ 
         )->update(['value' => $request->passExpire]);
 
         //  If the setting is changing from never to xx days, update all users
-        if ($request->passExpire == 0) {
+        if($request->passExpire == 0) {
             User::whereNotNull('password_expires')->update([
                 'password_expires' => null
             ]);
@@ -101,9 +101,9 @@ 
             ]);
         }
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         Log::debug('Submitted Data - ', $request->toArray());
-        Log::notice('User Settings have been changed by User ID-' . Auth::user()->user_id);
+        Log::notice('User Settings have been changed by User ID-'.Auth::user()->user_id);
         return redirect()->back()->with('success', 'User Security Updated');
     }
 
@@ -162,7 +162,7 @@ 
             'name'        => $request->name,
             'description' => $request->description,
         ]);
-        foreach ($request->permissions as $perm)
+        foreach($request->permissions as $perm)
         {
             UserRolePermissions::create([
                 'role_id'      => $role->role_id,

Braces +4 added lines, -5 removed lines

@@ -37,8 +37,7 @@ 
         $userLinks = new UserCollection(
                         User::withCount([
                                 'FileLinks',
-                                'FileLinks as expired_file_links_count' => function($query)
-                                {
+                                'FileLinks as expired_file_links_count' => function($query) {
                                     $query->where('expire', '<', Carbon::now());
                                 }
                             ])
@@ -88,7 +87,8 @@ 
         )->update(['value' => $request->passExpire]);
 
         //  If the setting is changing from never to xx days, update all users
-        if ($request->passExpire == 0) {
+        if ($request->passExpire == 0)
+        {
             User::whereNotNull('password_expires')->update([
                 'password_expires' => null
             ]);
@@ -110,8 +110,7 @@ 
     public function roleSettings()
     {
         $this->authorize('hasAccess', 'Manage User Roles');
-        $roles = UserRoleType::with(['UserRolePermissions' => function($query)
-        {
+        $roles = UserRoleType::with(['UserRolePermissions' => function($query) {
             $query->join('user_role_permission_types', 'user_role_permission_types.perm_type_id', '=', 'user_role_permissions.perm_type_id');
         }])->get();
         $perms = UserRolePermissionTypes::all();

app/Http/Controllers/Customers/CustomerDetailsController.php

Spacing +2 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
         Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         Log::notice('New Customer ID-'.$request->custID.' created by User ID-'.Auth::user()->user_id);
 
-        return response()->json(['success' => true, 'cust_id' => $custData->cust_id ]);
+        return response()->json(['success' => true, 'cust_id' => $custData->cust_id]);
     }
 
     //  Show the customer details
@@ -142,7 +142,7 @@ 
 
         $parentsParent = Customers::find($request->parent_id);
 
-        if ($parentsParent->parent_id)
+        if($parentsParent->parent_id)
         {
             $request->parent_id = $parentsParent->parent_id;
         }

app/Http/Controllers/Customers/CustomerContactsController.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
 
         //  Determine if there is a parent site with shared contacts
         $parent = Customers::find($id)->parent_id;
-        if ($parent)
+        if($parent)
         {
             $parentList = CustomerContacts::where('cust_id', $parent)
                 ->where('shared', 1)

app/Http/Controllers/Customers/CustomerNotesController.php

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
 
         //  Determine if the note should go to the customer, or its parent
         $details = Customers::find($request->cust_id);
-        if ($details->parent_id && $request->shared) {
+        if($details->parent_id && $request->shared) {
             $request->cust_id = $details->parent_id;
         }
 
@@ -55,7 +55,7 @@ 
 
         //  Determine if there is a parent site with shared contacts
         $parent = Customers::find($id)->parent_id;
-        if ($parent) {
+        if($parent) {
             $parentList = CustomerNotes::where('cust_id', $parent)->orderBy('urgent', 'desc')->get();
 
             $notes = $notes->merge($parentList);

Braces +4 added lines, -2 removed lines

@@ -29,7 +29,8 @@ 
 
         //  Determine if the note should go to the customer, or its parent
         $details = Customers::find($request->cust_id);
-        if ($details->parent_id && $request->shared) {
+        if ($details->parent_id && $request->shared)
+        {
             $request->cust_id = $details->parent_id;
         }
 
@@ -55,7 +56,8 @@ 
 
         //  Determine if there is a parent site with shared contacts
         $parent = Customers::find($id)->parent_id;
-        if ($parent) {
+        if ($parent)
+        {
             $parentList = CustomerNotes::where('cust_id', $parent)->orderBy('urgent', 'desc')->get();
 
             $notes = $notes->merge($parentList);

app/Http/Controllers/Customers/CustomerFilesController.php

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
         //  Verify that the upload is valid and being processed
         if($receiver->isUploaded() === false)
         {
-            Log::error('Upload File Missing - ' .
+            Log::error('Upload File Missing - '.
             /** @scrutinizer ignore-type */
             $request->toArray());
             throw new UploadMissingFileException();
@@ -50,7 +50,7 @@ 
         {
             //  Determine if the note should go to the customer, or its parent
             $details = Customers::find($request->cust_id);
-            if ($details->parent_id && $request->shared)
+            if($details->parent_id && $request->shared)
             {
                 $request->cust_id = $details->parent_id;
             }
@@ -110,7 +110,7 @@ 
 
         //  Determine if there is a parent site with shared files
         $parent = Customers::find($id)->parent_id;
-        if ($parent) {
+        if($parent) {
             $parentList = Customerfiles::where('cust_id', $parent)
                 ->with('Files')
                 ->with('CustomerFileTypes')

Braces +2 added lines, -1 removed lines

@@ -110,7 +110,8 @@
 
         //  Determine if there is a parent site with shared files
         $parent = Customers::find($id)->parent_id;
-        if ($parent) {
+        if ($parent)
+        {
             $parentList = Customerfiles::where('cust_id', $parent)
                 ->with('Files')
                 ->with('CustomerFileTypes')

database/migrations/2019_11_30_215206_updates_for_version_5_0.php

Spacing +13 added lines, -13 removed lines

@@ -66,8 +66,8 @@ 
     private function updatePhoneIcons()
     {
         $newIcons = [
-            ['description' => 'Home',   'icon_class' => 'fas fa-home'],
-            ['description' => 'Work',   'icon_class' => 'fas fa-briefcase'],
+            ['description' => 'Home', 'icon_class' => 'fas fa-home'],
+            ['description' => 'Work', 'icon_class' => 'fas fa-briefcase'],
             ['description' => 'Mobile', 'icon_class' => 'fas fa-mobile-alt'],
         ];
 
@@ -99,7 +99,7 @@ 
         {
             if(!Schema::hasColumn('users', 'role_id'))
             {
-                Schema::table('users', function (Blueprint $table) {
+                Schema::table('users', function(Blueprint $table) {
                     $table->integer('role_id')->after('user_id')->unsigned()->default(4);
                     $table->foreign('role_id')->references('role_id')->on('user_role_descriptions')->onUpdate('cascade');
                 });
@@ -326,8 +326,8 @@ 
     //  Add soft deletes to tech tips table to prevent accidental deletes
     private function addSoftDeleteToTechTips()
     {
-        if (!Schema::hasColumn('tech_tips', 'deleted_at')) {
-            Schema::table('tech_tips', function (Blueprint $table) {
+        if(!Schema::hasColumn('tech_tips', 'deleted_at')) {
+            Schema::table('tech_tips', function(Blueprint $table) {
                 $table->softDeletes()->after('description');
             });
         }
@@ -345,7 +345,7 @@ 
             //  Migrate over all deactivated users
             DB::update('UPDATE `users` SET `deleted_at` = "'.Carbon::now().'" WHERE `active` = 0');
             //  Remove the Active column
-            Schema::table('users', function (Blueprint $table) {
+            Schema::table('users', function(Blueprint $table) {
                 $table->dropColumn('active');
             });
         }
@@ -364,27 +364,27 @@ 
         }
         if(!Schema::hasColumn('customer_systems', 'shared'))
         {
-            Schema::table('customer_systems', function (Blueprint $table)
+            Schema::table('customer_systems', function(Blueprint $table)
             {
                 $table->boolean('shared')->default(0)->after('sys_id');
             });
         }
-        if (!Schema::hasColumn('customer_contacts', 'shared'))
+        if(!Schema::hasColumn('customer_contacts', 'shared'))
         {
-            Schema::table('customer_contacts', function (Blueprint $table)
+            Schema::table('customer_contacts', function(Blueprint $table)
             {
                 $table->boolean('shared')->default(0)->after('cust_id');
             });
         }
-        if (!Schema::hasColumn('customer_notes', 'shared'))
+        if(!Schema::hasColumn('customer_notes', 'shared'))
         {
-            Schema::table('customer_notes', function (Blueprint $table)
+            Schema::table('customer_notes', function(Blueprint $table)
             {
                 $table->boolean('shared')->default(0)->after('user_id');
             });
         }
-        if (!Schema::hasColumn('customer_files', 'shared')) {
-            Schema::table('customer_files', function (Blueprint $table) {
+        if(!Schema::hasColumn('customer_files', 'shared')) {
+            Schema::table('customer_files', function(Blueprint $table) {
                 $table->boolean('shared')->default(0)->after('user_id');
             });
         }

Braces +29 added lines, -22 removed lines

@@ -83,7 +83,8 @@ 
     //  Added the ability to set an expiration date for user passwords - will force them to change after this expires
     private function addPasswordExpiresColumn()
     {
-        if(!Schema::hasColumn('users', 'password_expires')) {
+        if(!Schema::hasColumn('users', 'password_expires'))
+        {
             Schema::table('users', function(Blueprint $table) {
                 $table->timestamp('password_expires')
                     ->nullable()
@@ -119,7 +120,8 @@ 
     //  Added a 'hidden' attribute to system customer data types to allow passwords to not be viewed unless clicked or focus
     private function addHiddenColumn()
     {
-        if(!Schema::hasColumn('system_data_field_types', 'hidden')) {
+        if(!Schema::hasColumn('system_data_field_types', 'hidden'))
+        {
             Schema::table('system_cust_data_types', function(Blueprint $table) {
                 $table->boolean('hidden')
                     ->default(0)
@@ -131,7 +133,8 @@ 
     //  Update the File links table - add cust_id and note column
     private function addColumnsToFileLinksTable()
     {
-        if(!Schema::hasColumn('file_links', 'cust_id')) {
+        if(!Schema::hasColumn('file_links', 'cust_id'))
+        {
             Schema::table('file_links', function(Blueprint $table) {
                 $table->integer('cust_id')
                     ->unsigned()
@@ -140,7 +143,8 @@ 
                 $table->foreign('cust_id')->references('cust_id')->on('customers')->onUpdate('cascade')->onDelete('cascade');
             });
         }
-        if(!Schema::hasColumn('file_links', 'note')) {
+        if(!Schema::hasColumn('file_links', 'note'))
+        {
             Schema::table('file_links', function(Blueprint $table) {
                 $table->longText('note')
                     ->nullable()
@@ -148,7 +152,8 @@ 
             });
             //  Migrate the instructions from the old table to the new column
             $instructions = DB::select('SELECT * FROM `file_link_instructions`');
-            foreach($instructions as $ins) {
+            foreach($instructions as $ins)
+            {
                 FileLinks::find($ins->link_id)->update([
                     'note' => $ins->instruction
                 ]);
@@ -159,7 +164,8 @@ 
     //  Add Notes column to the file links files table
     private function addNotesColumnToFileLinkFiles()
     {
-        if(!Schema::hasColumn('file_link_files', 'note')) {
+        if(!Schema::hasColumn('file_link_files', 'note'))
+        {
             Schema::table('file_link_files', function(Blueprint $table) {
                 $table->longText('note')
                     ->nullable()
@@ -167,7 +173,8 @@ 
             });
             //  Migrate the existing notes to the new table
             $notes = DB::select('SELECT * FROM `file_link_notes`');
-            foreach($notes as $note) {
+            foreach($notes as $note)
+            {
                 FileLinkFiles::where('file_id', $note->file_id)->update([
                     'note' => $note->note
                 ]);
@@ -178,7 +185,8 @@ 
     //  Add the documentation column to the tech tips table
     private function migrateSystemDocumentation()
     {
-        if(!Schema::hasColumn('tech_tips', 'tip_type_id')) {
+        if(!Schema::hasColumn('tech_tips', 'tip_type_id'))
+        {
             Schema::table('tech_tips', function(Blueprint $table) {
                 $table->bigInteger('tip_type_id')->unsigned()->after('public')->default(1);
                 $table->foreign('tip_type_id')->references('tip_type_id')->on('tech_tip_types')->onUpdate('cascade');
@@ -186,7 +194,8 @@ 
 
             //  Move all of the system files over to the tech tips table
             $sysFiles = DB::select('SELECT * FROM `system_files`');
-            foreach($sysFiles as $sysFile) {
+            foreach($sysFiles as $sysFile)
+            {
                 $newTip = TechTips::create([
                     'user_id'       => $sysFile->user_id,
                     'public'        => 0,
@@ -280,7 +289,8 @@ 
     //  Remove the system files and system file types table
     private function removeSystemFilesTables()
     {
-        if(Schema::hasTable('system_files')) {
+        if(Schema::hasTable('system_files'))
+        {
             Schema::table('system_files', function(Blueprint $table) {
                 $table->dropForeign(['sys_id']);
                 $table->dropForeign(['type_id']);
@@ -326,7 +336,8 @@ 
     //  Add soft deletes to tech tips table to prevent accidental deletes
     private function addSoftDeleteToTechTips()
     {
-        if (!Schema::hasColumn('tech_tips', 'deleted_at')) {
+        if (!Schema::hasColumn('tech_tips', 'deleted_at'))
+        {
             Schema::table('tech_tips', function (Blueprint $table) {
                 $table->softDeletes()->after('description');
             });
@@ -338,8 +349,7 @@ 
     {
         if(!Schema::hasColumn('users', 'deleted_at'))
         {
-            Schema::table('users', function(Blueprint $table)
-            {
+            Schema::table('users', function(Blueprint $table) {
                 $table->softDeletes()->after('password_expires');
             });
             //  Migrate over all deactivated users
@@ -356,34 +366,31 @@ 
     {
         if(!Schema::hasColumn('customers', 'parent_id'))
         {
-            Schema::table('customers', function(Blueprint $table)
-            {
+            Schema::table('customers', function(Blueprint $table) {
                 $table->integer('parent_id')->after('cust_id')->nullable()->unsigned();
                 $table->foreign('parent_id')->references('cust_id')->on('customers')->onUpdate('cascade');
             });
         }
         if(!Schema::hasColumn('customer_systems', 'shared'))
         {
-            Schema::table('customer_systems', function (Blueprint $table)
-            {
+            Schema::table('customer_systems', function (Blueprint $table) {
                 $table->boolean('shared')->default(0)->after('sys_id');
             });
         }
         if (!Schema::hasColumn('customer_contacts', 'shared'))
         {
-            Schema::table('customer_contacts', function (Blueprint $table)
-            {
+            Schema::table('customer_contacts', function (Blueprint $table) {
                 $table->boolean('shared')->default(0)->after('cust_id');
             });
         }
         if (!Schema::hasColumn('customer_notes', 'shared'))
         {
-            Schema::table('customer_notes', function (Blueprint $table)
-            {
+            Schema::table('customer_notes', function (Blueprint $table) {
                 $table->boolean('shared')->default(0)->after('user_id');
             });
         }
-        if (!Schema::hasColumn('customer_files', 'shared')) {
+        if (!Schema::hasColumn('customer_files', 'shared'))
+        {
             Schema::table('customer_files', function (Blueprint $table) {
                 $table->boolean('shared')->default(0)->after('user_id');
             });