CreateCustomerSystemFieldsTable::up() - Code Metrics - Inspection of "Corrected 'use' paths to correct case" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5 ( b08d9a...c43caf )

by Ron

created 2019-11-09 04:12 UTC

CreateCustomerSystemFieldsTable::up() A

↳ Parent: CreateCustomerSystemFieldsTable

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

use Illuminate\Support\Facades\Schema;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

class CreateCustomerSystemFieldsTable extends Migration
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create('customer_system_fields', function(Blueprint $table) {
            $table->increments('id');
            $table->integer('cust_sys_id')->unsigned();
            $table->integer('field_id')->unsigned();
            $table->text('value')->nullable();
            $table->timestamps();
            $table->foreign('cust_sys_id')->references('cust_sys_id')->on('customer_systems')->onUpdate('cascade')->onDelete('cascade');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $table->foreign('field_id')->references('field_id')->on('system_cust_data_fields')->onUpdate('cascade')->onDelete('cascade');
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::dropIfExists('customer_system_fields');
    }
}


1			<?php
2
3			use Illuminate\Support\Facades\Schema;
4			use Illuminate\Database\Schema\Blueprint;
5			use Illuminate\Database\Migrations\Migration;
6
7			class CreateCustomerSystemFieldsTable extends Migration
8			{
9			/**
10			* Run the migrations.
11			*
12			* @return void
13			*/
14			public function up()
15			{
16			Schema::create('customer_system_fields', function(Blueprint $table) {
17			$table->increments('id');
18			$table->integer('cust_sys_id')->unsigned();
19			$table->integer('field_id')->unsigned();
20			$table->text('value')->nullable();
21			$table->timestamps();
22			$table->foreign('cust_sys_id')->references('cust_sys_id')->on('customer_systems')->onUpdate('cascade')->onDelete('cascade');
			0 ignored issues – show Bug introduced 2019-11-09 04:16 UTC by Report Bug Copy Issue Report The method `references` does only exist in `Illuminate\Database\Schema\ForeignKeyDefinition`, but not in `Illuminate\Support\Fluent`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23			$table->foreign('field_id')->references('field_id')->on('system_cust_data_fields')->onUpdate('cascade')->onDelete('cascade');
24			});
25			}
26
27			/**
28			* Reverse the migrations.
29			*
30			* @return void
31			*/
32			public function down()
33			{
34			Schema::dropIfExists('customer_system_fields');
35			}
36			}
37

butcherman / Tech_Bench

Push — dev5 ( b08d9a...c43caf )

CreateCustomerSystemFieldsTable::up() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like