App\Notifications\NewFileUpload

Complexity

Total Complexity

4

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

27.78%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	via()	0	4	1
A	toMail()	0	11	1
A	toArray()	0	12	1

<?php

namespace App\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;

class NewFileUpload extends Notification implements ShouldQueue
{
    use Queueable;
    protected $details;

    //  Constructor receives the file link details
    public function __construct($details)
    {
        $this->details = $details;
    }

    //  Notification is sent via email and dashboard notification
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail', 'database'];
    }

    //  Email notification
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return (new MailMessage)
            ->line('A new file has been uploaded to the file link - '.$this->details->link_name)
            ->action('Click to View Link',
                url(route('links.details',

It seems like url(route('links.details', array('id' => $this->details->link_id, 'name' => urlencode($this->details->link_name)))) targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Illuminate\Notifications\Messages\SimpleMessage::action() does only seem to accept string, maybe add an additional type check?

                [
                        'id' => $this->details->link_id,
                        'name' => urlencode($this->details->link_name)
                ])));
    }

    //  Dashboard notification
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            'type'    => 'warning',
            'message' => 'New File(s) Uploaded to link - '.$this->details->link_name,
            'link'    => url(route('links.details',
                            [
                            'id' => $this->details->link_id,
                                'name' => urlencode($this->details->link_name)
                            ]))
        ];
    }
}