App\Http\Controllers\Customers\CustomerController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	154
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

26.67%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	15	2
B	search()	0	55	2
A	checkID()	0	15	2
A	toggleFav()	0	24	3

<?php

namespace App\Http\Controllers\Customers;

use App\Customers;
use App\SystemTypes;
use App\CustomerFavs;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Route;
use App\Http\Resources\CustomerCollection;

class CustomerController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }

    //  Landing page to search for customer
    public function index()
    {
        $sysTypes = SystemTypes::all();

        $sysArr = [];
        foreach($sysTypes as $sys)
        {
            $sysArr[] = $sys->name;
        }

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return view('customer.index', [
            'sysTypes' => $sysArr
        ]);
    }

    //  Search for the customer based on their ID - For new file link form
    // public function searchID($id)
    // {
    //     $id = urldecode($id);
    //     if($id === 'NULL')
    //     {
    //         $id = '';
    //     }

    //     //  Determine if a customer number/name has already been entered
    //     if(!empty($id))
    //     {
    //         $split = explode(' ', $id);
    //         if(isset($split[1]) && $split[1] === '-')
    //         {
    //             $id = $split[0];
    //         }
    //     }

    //     $res = Customers::where('cust_id', 'like', '%'.$id.'%')
    //         ->orWhere('name', 'like', '%'.$id.'%')
    //         ->where('active', 1)
    //         ->orderBy('name')
    //         ->get();

    //     Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
    //     Log::debug('ID Entered - '.$id.' Resolution - '.$res);
    //     return response()->json($res);
    // }

    //  Search for a customer
    public function search(Request $request)
    {
        // $customers = Customers::
        //         with('CustomerSystems.SystemTypes')
        //         ->get();

        // $custList = [];
        // foreach($customers as $cust)
        // {
        //     $sysArr = '';
        //     foreach($cust->CustomerSystems as $sys)
        //     {
        //         $sysArr .= $sys->SystemTypes->name.'<br />';
        //     }

        //     $custList[] = [
        //         'cust_id' => $cust->cust_id,
        //         'name' => $cust->name,
        //         'dba'  => $cust->dba_name,
        //         'city' => $cust->city.', '.$cust->state,
        //         'url'  => route('customer.details', [$cust->cust_id, urlencode($cust->name)]),
        //         'sys'  => $sysArr
        //     ];


        // }

        // Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        // Log::debug('Customer Data - ', $custList);
        // return response()->json($custList);


        // $searchResults = new CustomerCollection(
        //     Customers::where('cust_id', $request->search)
        //         ->orWhere('name', $request->search)
        //         ->orWhere('dba_name', $request->search)
        //         ->get()
        //     );

        if($request->search)
        {
            $searchResults = new CustomerCollection(
            Customers::where('cust_id', 'like', '%'.$request->search.'%')
                ->orWhere('name', 'like', '%'.$request->search.'%')
                ->orWhere('dba_name', 'like', '%'.$request->search.'%')
                ->get()
            );
        }
        else
        {
            $searchResults = new CustomerCollection(Customers::all());
        }

        return $searchResults;
    }

    //  Check to see if a customer ID already exists
    public function checkID($id)
    {
        $cust = Customers::find($id);

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if($cust === null)
        {
            Log::debug('Customer ID - '.$id.' is available to use');
            return response()->json(['dup' => false]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

        }


        Log::debug('Customer ID is in use by - '.$cust->name);
        return response()->json(['dup' => true, 'url' => route('customer.details', [$cust->cust_id, urlencode($cust->name)])]);
    }

    //  Toggle whether or not the customer is listed as a user favorite
    public function toggleFav($action, $id)
    {
        switch($action)
        {
            case 'add':
                CustomerFavs::create([
                    'user_id' => Auth::user()->user_id,

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    'cust_id' => $id
                ]);
                break;
            case 'remove':
                $custFav = CustomerFavs::where('user_id', Auth::user()->user_id)->where('cust_id', $id)->first();

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                $custFav->delete();
                break;
        }

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        Log::debug('Customer Bookmark Updated.', [
            'user_id' => Auth::user()->user_id,

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            'cust_id' => $id,
            'action'  => $action
        ]);
        return response()->json(['success' => true]);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

    }
}