App\Files

Complexity

Total Complexity

9

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

42.86%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	systemFiles()	0	4	1
A	fileLinkFiles()	0	4	1
A	cleanFileName()	0	34	5
A	deleteFile()	0	23	2

<?php

namespace App;

use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Storage;

class Files extends Model
{
    protected $primaryKey = 'file_id';
    protected $fillable = ['file_name', 'file_link', 'mime_type'];

    public function systemFiles()
    {
        return $this->hasMany('App\SystemFiles', 'file_id', 'file_id');
    }

    public function fileLinkFiles()
    {
        return $this->belongsTo('App\FileLinkFiles', 'file_id', 'file_id');
    }

    //  Remove any illegal characters from filename and make sure it is unique
    public static function cleanFileName($path, $fileName)
    {
        //  Remove all spaces
        $fileName = str_replace(' ', '_', $fileName);

Consider using a different name than the parameter $fileName. This often makes code more readable.

        //  Determine if the filename already exists
        if(Storage::exists($path.DIRECTORY_SEPARATOR.$fileName))
        {
            $fileParts = pathinfo($fileName);
            $extension = isset($fileParts['extension']) ? ('.'.$fileParts['extension']) : '';

            //  Look to see if a number is already appended to a file.  (example - file(1).pdf)
            if(preg_match('/(.*?)(\d+)$/', $fileParts['filename'], $match))
            {
                // Has a number, increment it
                $base = $match[1];
                $number = intVal($match[2]);
            }
            else
            {
                // No number, add one
                $base = $fileParts['filename'];
                $number = 0;
            }

            //  Increase the number until one that is not in use is found
            do
            {
                $fileName = $base.'('.++$number.')'.$extension;

Consider using a different name than the parameter $fileName. This often makes code more readable.

            } while(Storage::exists($path.DIRECTORY_SEPARATOR.$fileName));
        }

        return $fileName;
    }

    //  Delete a file from both the database and file system
    public static function deleteFile($fileID)
    {
        $fileLink = '';
        try
        {
            //  Try to delete file from database - will throw error if foreign key is in use
            $fileData = Files::find($fileID);
            $fileLink = $fileData->file_link.$fileData->file_name;
            $fileData->delete();
        }
        catch(\Illuminate\Database\QueryException $e)
        {
            //  Unable to remove file from the database
            Log::info('File Unable to delete - '.$e, ['file_id' => $fileID, 'file_name' => $fileLink, 'user_id' => Auth::user()->user_id]);

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return false;
        }

        //  Delete the file from the storage system
        Storage::delete($fileLink);

        Log::info('File Deleted', ['file_id' => $fileID, 'file_name' => $fileLink, 'user_id' => Auth::user()->user_id]);

Accessing user_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return true;
    }
}