SystemsTrait::getFields() - Code Metrics - Inspection of "Added Customer Systems" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev5 ( 8afe4d...7a94ca )

by Ron

created 2019-05-02 04:34 UTC

SystemsTrait::getFields() A

↳ Parent: SystemsTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	1
dl	0
loc	9
rs	10
c	0
b	0
f	0

<?php

namespace App\Http\Traits;

use App\SystemTypes;
use App\SystemCustDataFields;
use Illuminate\Support\Facades\Log;

trait SystemsTrait
{
    //  Get a list of all systems
    public function getAllSystems()
    {
        $sysList = SystemTypes::select('system_types.*', 'system_categories.name AS cat_name')
            ->join('system_categories', 'system_types.cat_id', '=', 'system_categories.cat_id')
            
            ->orderBy('cat_name', 'ASC')
            ->get();
        
        $sysArr = [];
        foreach($sysList as $sys)
        {
            $sysArr[$sys->cat_name][] = [
                'sys_id' => $sys->sys_id,
                'name'   => $sys->name
            ];
        }
        
        return $sysArr;
    }
    
    //  Get the data fields attached to a system
    public function getFields($id)
    {
        $sysFields = SystemCustDataFields::where('sys_id', $id)
            ->join('system_cust_data_types', 'system_cust_data_types.data_type_id', '=', 'system_cust_data_fields.data_type_id')
            ->select('system_cust_data_types.data_type_id', 'system_cust_data_types.name', 'field_id', 'hidden', 'order')
            ->orderBy('order', 'ASC')
            ->get();
        
        return $sysFields;
    }
}


1			<?php
2
3			namespace App\Http\Traits;
4
5			use App\SystemTypes;
6			use App\SystemCustDataFields;
7			use Illuminate\Support\Facades\Log;
8
9			trait SystemsTrait
10			{
11			// Get a list of all systems
12			public function getAllSystems()
13			{
14			$sysList = SystemTypes::select('system_types.*', 'system_categories.name AS cat_name')
15			->join('system_categories', 'system_types.cat_id', '=', 'system_categories.cat_id')
16
17			->orderBy('cat_name', 'ASC')
18			->get();
19
20			$sysArr = [];
21			foreach($sysList as $sys)
22			{
23			$sysArr[$sys->cat_name][] = [
24			'sys_id' => $sys->sys_id,
25			'name' => $sys->name
26			];
27			}
28
29			return $sysArr;
30			}
31
32			// Get the data fields attached to a system
33			public function getFields($id)
34			{
35			$sysFields = SystemCustDataFields::where('sys_id', $id)
36			->join('system_cust_data_types', 'system_cust_data_types.data_type_id', '=', 'system_cust_data_fields.data_type_id')
37			->select('system_cust_data_types.data_type_id', 'system_cust_data_types.name', 'field_id', 'hidden', 'order')
38			->orderBy('order', 'ASC')
39			->get();
40
41			return $sysFields;
42			}
43			}
44

butcherman / Tech_Bench

Push — dev5 ( 8afe4d...7a94ca )

SystemsTrait::getFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like