CustomerIdController::update() - Code Metrics - Inspection of "Updated Testing" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev6 ( 1762ad...6b002f )

by Ron

created 2021-05-17 23:32 UTC

CustomerIdController::update() A

↳ Parent: CustomerIdController

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.351

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	16
ccs	5
cts	9
cp	0.5556
rs	9.9666
cc	2
nc	2
nop	2
crap	2.351

<?php

namespace App\Http\Controllers\Customers;

use Inertia\Inertia;

use App\Models\Customer;
use App\Http\Controllers\Controller;
use App\Http\Requests\Customers\CustIdRequest;

use Illuminate\Support\Facades\Log;
use Illuminate\Database\QueryException;

class CustomerIdController extends Controller
{
    /**
     *  Search parameter to select which ID to change
     */
    public function index()
    {
        $this->authorize('manage', Customer::class);

        return Inertia::render('Customer/changeId');
    }

    /**
     *  Show the Change ID Form
     */
    public function edit($id)
    {
        $this->authorize('manage', Customer::class);

        return Inertia::render('Customer/changeIdForm', [
            'details' => Customer::where('slug', $id)->firstOrFail(),
        ]);
    }

    /**
     *  Submit the Change ID Form
     */
    public function update(CustIdRequest $request, $id)
    {
        $cust = Customer::findOrFail($id);

        try{
            $cust->update($request->only(['cust_id']));
        }
        catch(QueryException $e)
        {
            Log::error('Update Customer ID failed');
            Log::error($e);
            return redirect()->back()->with(['message' => 'Unable to Update Customer ID for linked Customers', 'type' => 'danger']);
        }

        Log::channel('cust')->notice('Customer ID has been updated for Customer '.$cust->name.' from '.$id.' to '.$request->cust_id.' by '.$request->user()->username);
        return redirect()->route('admin.index');
    }
}


1		<?php
2
3		namespace App\Http\Controllers\Customers;
4
5		use Inertia\Inertia;
6
7		use App\Models\Customer;
8		use App\Http\Controllers\Controller;
9		use App\Http\Requests\Customers\CustIdRequest;
10
11		use Illuminate\Support\Facades\Log;
12		use Illuminate\Database\QueryException;
13
14		class CustomerIdController extends Controller
15		{
16		/**
17		* Search parameter to select which ID to change
18		*/
19	2	public function index()
20		{
21	2	$this->authorize('manage', Customer::class);
22
23	1	return Inertia::render('Customer/changeId');
24		}
25
26		/**
27		* Show the Change ID Form
28		*/
29	2	public function edit($id)
30		{
31	2	$this->authorize('manage', Customer::class);
32
33	1	return Inertia::render('Customer/changeIdForm', [
34	1	'details' => Customer::where('slug', $id)->firstOrFail(),
35		]);
36		}
37
38		/**
39		* Submit the Change ID Form
40		*/
41	1	public function update(CustIdRequest $request, $id)
42		{
43	1	$cust = Customer::findOrFail($id);
44
45		try{
46	1	$cust->update($request->only(['cust_id']));
47		}
48		catch(QueryException $e)
49		{
50		Log::error('Update Customer ID failed');
51		Log::error($e);
52		return redirect()->back()->with(['message' => 'Unable to Update Customer ID for linked Customers', 'type' => 'danger']);
53		}
54
55	1	Log::channel('cust')->notice('Customer ID has been updated for Customer '.$cust->name.' from '.$id.' to '.$request->cust_id.' by '.$request->user()->username);
56	1	return redirect()->route('admin.index');
57		}
58		}
59

butcherman / Tech_Bench

Push — dev6 ( 1762ad...6b002f )

CustomerIdController::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like