AdminController::userLinks() - Code Metrics - Inspection of "Updated Admin File Links page" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5 ( 8662bf...df64bd )

by Ron

created 2019-12-04 03:38 UTC

AdminController::userLinks() A

↳ Parent: AdminController

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	11
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	18
ccs	12
cts	12
cp	1
crap	1
rs	9.9

<?php

namespace App\Http\Controllers\Admin;

use Carbon\Carbon;
use App\User;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Route;

use App\Http\Resources\UserCollection;

class AdminController extends Controller
{
    public function __construct()
    {
        //  Only Authorized users with specific admin permissions are allowed
        $this->middleware(['auth', 'can:allow_admin']);
    }

    //  Admin landing page
    public function index()
    {
        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        return view('admin.index');
    }

    //  Display all file links
    public function userLinks()
    {
        $userLinks = new UserCollection(
                        User::where('active', 1)
                            ->withCount([
                                'FileLinks',
                                'FileLinks as expired_file_links_count' => function($query)
                                {
                                    $query->where('expire', '<', Carbon::now());
                                }
                            ])
                            ->get()
                            ->makeVisible('user_id')
                    );

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        return view('admin.userLinks', [
            'links' => $userLinks,
        ]);
    }

    //  Show the links for the selected user
    public function showLinks($id)
    {
        $user     = User::find($id);

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        return view('admin.linkDetails', [
            'user' => $user,
            // 'name'   => $userName
        ]);
    }
}


1		<?php
2
3		namespace App\Http\Controllers\Admin;
4
5		use Carbon\Carbon;
6		use App\User;
7		use Illuminate\Http\Request;
8		use Illuminate\Support\Facades\Log;
9		use Illuminate\Support\Facades\Auth;
10		use App\Http\Controllers\Controller;
11		use Illuminate\Support\Facades\Route;
12
13		use App\Http\Resources\UserCollection;
14
15		class AdminController extends Controller
16		{
17	26	public function __construct()
18		{
19		// Only Authorized users with specific admin permissions are allowed
20	26	$this->middleware(['auth', 'can:allow_admin']);
21	26	}
22
23		// Admin landing page
24	10	public function index()
25		{
26	10	Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
27	10	return view('admin.index');
28		}
29
30		// Display all file links
31	2	public function userLinks()
32		{
33	2	$userLinks = new UserCollection(
34	2	User::where('active', 1)
35	2	->withCount([
36	2	'FileLinks',
37		'FileLinks as expired_file_links_count' => function($query)
38		{
39	2	$query->where('expire', '<', Carbon::now());
40	2	}
41		])
42	2	->get()
43	2	->makeVisible('user_id')
44		);
45
46	2	Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
47	2	return view('admin.userLinks', [
48	2	'links' => $userLinks,
49		]);
50		}
51
52		// Show the links for the selected user
53	2	public function showLinks($id)
54		{
55	2	$user = User::find($id);
56
57	2	Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
58	2	return view('admin.linkDetails', [
59	2	'user' => $user,
60		// 'name' => $userName
61		]);
62		}
63		}
64

butcherman / Tech_Bench

Push — dev5 ( 8662bf...df64bd )

AdminController::userLinks() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like